-
Notifications
You must be signed in to change notification settings - Fork 680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: DarkMode #873
feat: DarkMode #873
Conversation
@pu-raihan Also, there was an issue with the GitHub action configs that's why some of the checks are forever waiting to be started. I had pushed a fix in #922. Can you try rebasing your branch against |
I have resolved the issue and rebased the branch |
From a quick look, I suggest changing the theme toggler from the sidebar to a selectable field under The automatic switching of theme based on the System Preference might confuse the user to revert it if they didn't like that theme. considering that, the theme-switching functionality should only be managed by the user, not the application. In simpler terms, |
…ode in Settings > System > Theme
I have removed toggler from sidebar and added a field in settings to enable dark mode. Please check. |
updated the code, please check. |
LGTM 👍🏻 |
Summary
Allow users to either follow system theme or manually set the mode (light or dark)