Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DarkMode #873

Merged
merged 15 commits into from
Sep 9, 2024
Merged

feat: DarkMode #873

merged 15 commits into from
Sep 9, 2024

Conversation

pu-raihan
Copy link
Contributor

Summary

Allow users to either follow system theme or manually set the mode (light or dark)

  • User's system theme as default theme.
  • Darkmode toggler in sidebar switches between dark and light mode

books-dark
Screenshot 2024-03-28 152801

@pu-raihan pu-raihan marked this pull request as ready for review August 17, 2024 15:15
@akshayitzme
Copy link
Collaborator

akshayitzme commented Aug 20, 2024

@pu-raihan
hi, could you take a look at the lining issues?

Also, there was an issue with the GitHub action configs that's why some of the checks are forever waiting to be started. I had pushed a fix in #922. Can you try rebasing your branch against upstream/master to get the latest changes so the pending actions will resume to work ?

@pu-raihan
Copy link
Contributor Author

@pu-raihan hi, could you take a look at the lining issues?

Also, there was an issue with the GitHub action configs that's why some of the checks are forever waiting to be started. I had pushed a fix in #922. Can you try rebasing your branch against upstream/master to get the latest changes so the pending actions will resume to work

I have resolved the issue and rebased the branch

@akshayitzme
Copy link
Collaborator

@pu-raihan hi, could you take a look at the lining issues?
Also, there was an issue with the GitHub action configs that's why some of the checks are forever waiting to be started. I had pushed a fix in #922. Can you try rebasing your branch against upstream/master to get the latest changes so the pending actions will resume to work

I have resolved the issue and rebased the branch

From a quick look, I suggest changing the theme toggler from the sidebar to a selectable field under Settings > System.

The automatic switching of theme based on the System Preference might confuse the user to revert it if they didn't like that theme. considering that, the theme-switching functionality should only be managed by the user, not the application.

In simpler terms,
Light theme, by default
Dark theme, only if chosen

@pu-raihan
Copy link
Contributor Author

I have removed toggler from sidebar and added a field in settings to enable dark mode. Please check.

@pu-raihan
Copy link
Contributor Author

updated the code, please check.

@AbleKSaju
Copy link
Contributor

Text Color seems to be inconsistent between Document LIst and New Document Form

Sales Invoice List image
New Sales Invoice Form image

@AbleKSaju
Copy link
Contributor

Can the scrollbar color be changed as it does not match the dark theme?

image

@pu-raihan
Copy link
Contributor Author

Text Color seems to be inconsistent between Document LIst and New Document Form

Sales Invoice List
New Sales Invoice Form

It is actually like that in the original theme

Sales Invoice List
New Sales Invoice Form

@pu-raihan
Copy link
Contributor Author

Can the scrollbar color be changed as it does not match the dark theme?

image

I might've missed it, I'll add it immediately.
Plz lemme know if there's anything to add.

@akshayitzme
Copy link
Collaborator

LGTM 👍🏻

@akshayitzme akshayitzme merged commit c285752 into frappe:master Sep 9, 2024
4 checks passed
@akshayitzme akshayitzme mentioned this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants