-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Preserve last visited tab #293
Conversation
d925f9a
to
b9f2730
Compare
@gopikrishnan13 This is not a correct way to fix this. And we can then store the last visited tab in local storage |
Hi @shariquerik I made some updates based on your feedback and implemented the feature in the suggested way. it works fine. Here’s the output video for your review. Screencast.from.20-09-24.02.27.01.PM.IST.webmCan I continue with this and make a commit? Let me know if you have any further suggestions! |
@gopikrishnan13 Yeah go ahead |
a55eff5
to
0b6d071
Compare
@shariquerik I updated this PR, please check it now,
Screencast.from.25-09-24.06.00.23.PM.IST.webm |
🎉 This PR is included in version 1.24.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
@gopikrishnan13 There is one problem occurred after this. It is very irritating Fixed: 2f58da9 |
@shariquerik I have another solution, I’ve tested it, and it works well. Instead of setting the hash directly, I replace the history state only the first time when setting the tab from local storage. This way, it doesn’t affect the browser history and this prevents adding extra history entries Do you think this is a better solution? |
Screencast.from.09-08-24.12.45.17.PM.IST.WEBM
Closes #192