Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full screen mode when editing only makes window taller not wider #11942

Closed
joolsr opened this issue Dec 11, 2017 · 4 comments
Closed

Full screen mode when editing only makes window taller not wider #11942

joolsr opened this issue Dec 11, 2017 · 4 comments

Comments

@joolsr
Copy link
Contributor

joolsr commented Dec 11, 2017

Using demo.erpnext.com
ERPNext: v9.x.x-develop (02ac901) (develop)
Frappe Framework: v9.x.x-develop (ec33e82) (develop)
Chromium Version 62.0.3202.94
Firefox 57.0.1

To replicate
On an opportunity, Click 'New Email' (Reply to email gives the same problem too)
Wish to use full screen mode to edit an email.
Click the full screen button in the editor toolbar
This problem is also seen on the Issues.

The window lengthens, but does not widen. This used to work and provide true full screen editing capability. Perhaps it should also be in one of the unit tests ? I note that for other screens such as To do that using the full screen button does provide full screen editing. Likewise on some modal views there is a 'Edit in Full page' link which works fine too. Perhaps the emails creation view should have this too?

full-screen-email

@rmehta
Copy link
Member

rmehta commented Mar 22, 2018

There is an ideal page width for reading text. Reading very wide text is cognitively harder to the human eye as you have to scan left to right.

Also in the world of 140 characters, we should not encourage long emails. No one reads emails longer than 5 sentences anyways.

https://lifehacker.com/280193/limit-your-email-messages-to-5-sentences
https://guykawasaki.com/the_effective_e/
https://www.themuse.com/advice/are-your-emails-too-long-hint-probably

@rmehta rmehta closed this as completed Mar 22, 2018
@joolsr
Copy link
Contributor Author

joolsr commented Mar 22, 2018

I appreciate your explanation Rushabh

But something that you haven't taken into account is when you have a long email conversation with customers. The usability gets greatly degraded as you have to scroll up and down the screen much more than you should with just a very narrow modal view ...

@achillesrasquinha
Copy link
Contributor

achillesrasquinha commented Mar 22, 2018

That modal is surely small sized for an embedded text editor, forget normal. Lol.

@karlosTM
Copy link

How do you get the full screen option at all?
I use v14 and it doesn't show at all. Would love to have it as an option, even if limited width.

image

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants