Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting the accounts in Chart of Accounts in ERPNext version 11 #16712

Closed
bghayad opened this issue Feb 18, 2019 · 10 comments
Closed

Sorting the accounts in Chart of Accounts in ERPNext version 11 #16712

bghayad opened this issue Feb 18, 2019 · 10 comments
Labels
accounts to-validate Old issues pending validation

Comments

@bghayad
Copy link
Contributor

bghayad commented Feb 18, 2019

This problem appears if the chart of account will be created from json file and not from .py file. And if it is required to be reproduced, then it can be tested by selecting france chart of account which use the file fr_plan_comptable_general.json.

The accounts are not sorted based on the account number or based on the alphanumeric of the account number and account name.

Below is the image of how the accounts are appearing in version 11 and this problem is not existed in version 10.

chartofaccount_accounts_sorting

@crescent28 crescent28 added accounts to-validate Old issues pending validation labels Feb 20, 2019
@dulhaver
Copy link
Contributor

dulhaver commented Feb 24, 2019

I confirm the behavior as per this issue.

Below the setup of my test Company

image


Below is the CoA of that french company

image


at least the children seem to be sorted numerically.

Can it be ERPNext sorts as per root account type rather then the numbers of the account groups?

@dulhaver
Copy link
Contributor

dulhaver commented Feb 24, 2019

I also see the same behavior with my own company's CoA (which also originates from a .json file):

  • Root Groups are not sorted numerically
  • Children are sorted numerically

my french is too bad to say whether the Root account Group sorting follows the same principle in both cases

@Nofal-Mami
Copy link

I confirm sorting is not working if account type is a group, but if account is a leaf sorting is fine. I have tested this issue and reported in the forum.

@bghayad
Copy link
Contributor Author

bghayad commented Mar 2, 2019

@crescent28
Can you help by classifying this issue to be bug so to be taken into consideration to work on it to be resolved because Chart of Account is very important and critical.
@Nofal-Mami In which forum you reported? Can we have the link?
Regards
Bilal

@bghayad
Copy link
Contributor Author

bghayad commented Mar 7, 2019

Hello @crescent28 @vrms @Nofal-Mami
How can we speed up to fix this?
Or at least if someone can advise from where it is possible to modify the code and resolve this bug?
Regards
Bilal

@Nofal-Mami
Copy link

@bghayad
Copy link
Contributor Author

bghayad commented Mar 9, 2019

Thank you @Nofal-Mami
@creador30 Please note that until now I am not able to user version 11 because of this problem which consider very important because it is related to chart of account which is important.

Regards
Bilal

@bghayad
Copy link
Contributor Author

bghayad commented Mar 15, 2019

Hello;
Any update on this?
The problem is preventing us from using version 11.
Regards
Bilal

@bghayad
Copy link
Contributor Author

bghayad commented Mar 17, 2019

Hello @jaichavan
Can you help please?
Regards
Bilal

@bghayad
Copy link
Contributor Author

bghayad commented May 10, 2019

Hello;
I have created fix for this problem at this pull request #17563

@bghayad bghayad closed this as completed May 10, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accounts to-validate Old issues pending validation
Projects
None yet
Development

No branches or pull requests

4 participants