-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explore types for JS and Python. #30199
Comments
Documentation from the developer's perspective might be helpful here. |
Fully typed code seems quite far-fetched since a lot of our code is very dynamic in nature. I've attempted to automate some typing when using Another problem is all DB methods are also dynamic and can load from any specified table with any type of return value. Typing all this manually is very error-prone and will just add more maintenance than reducing it 😅 Regardless of this, we are doing "best efforts" to add type hints on new code and plain non-dynamic code like utilities so it helps improve DX (autocomplete, lints). This won't be taken up as a concentrated effort anytime soon, but we are aware of this. Closing for now. |
@Abhirup-99 consider using https://github.com/frappe/intellisense |
I agree with the viewpoint. I think this can be better improved by having documentation from a developer's perspective. The frappe documentation is great and so is the documentation for the end-user. The JS frontend is using namespaces and is beautifully encapsulated, but you can understand the struggle from the developer aspect looking at things, not understanding where it is actually written. Side effects of inheritance and functions maybe :). Used https://zulip.readthedocs.io/en/latest/subsystems/index.html. Another codebase I had seen with great encapsulations. But this has a great corresponding documentation from developer perspective to understand it. |
Is your feature request related to a problem? Please describe.
We are a new company exploring the healthcare module. Types for the various Python and JS functions would have been of great help while exploring the codebase. Would be interested in pushing some types upstream while exploring the codebase more. I am more interested in the Python types at this point. We have a Go and TS codebase, so everything is typed.
Describe the solution you'd like
Python handler functions have types to get an idea of the default codebase.
Additional context
Explore mypy and the Zulip project for the types if interested.
The text was updated successfully, but these errors were encountered: