Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect account currency shown in new journal entry #32409

Closed
dgehriger opened this issue Sep 28, 2022 · 9 comments · Fixed by #32478
Closed

Incorrect account currency shown in new journal entry #32409

dgehriger opened this issue Sep 28, 2022 · 9 comments · Fixed by #32478
Labels
accounts bug released valid

Comments

@dgehriger
Copy link

Information about bug

I am using accounts in USD, EUR and CHF (the latter being the company currency).

When creating a new journal entry involving accounts in a currency different from the company currency, the correct currency is shown in the Account Currency column of the Accounting Entries table.

However, when either duplicating, or creating from a template, those same accounts will show, and use, the company currency, not their own currency, in that column, as well as in the detailed entry form.

The only way to correct this is to delete the account entry from the table and to re-enter it.

image

Module

accounts

Version

Frappe v14.5.0
ERPNext v14.1.2

Installation method

manual install

Relevant log output / Stack trace / Full Error Message.

No response
@dgehriger dgehriger added the bug label Sep 28, 2022
@rtdany10
Copy link
Contributor

Even though it shows wrong currency while duplicating, it will be updated to correct value when you save the journal entry.

@dgehriger
Copy link
Author

@rtdany10 : thanks for your answer. The problem is that the difference calculations will be incorrect. In the screenshot above, line 1 and 3 are in USD, whereas 2 is in the company currency, which is CHF.

I fill in 1 & 3, and then click on the difference entry button to calculate the amount for 2 (Sales Expenses). That value will be wrong if the currency is wrong.

@dj12djdjs
Copy link
Collaborator

@dgehriger Please see my attached screen capture, are we looking a the same bug?

Steps to Reproduce

  1. Duplicate an existing multi-currency journal entry.
  2. Modify the target company currency account.
  3. Clear previous company currency amount.
  4. Click "Make Difference Entry" (Note at this time UI shows transaction as balanced)
  5. Save -> throw validation error transaction is not balanced.

xxxx

@rtdany10
Copy link
Contributor

rtdany10 commented Oct 1, 2022

Unchecking No Copy for the currency field seems to have fixed the issue. But, was No Copy enabled for some other reason?
@deepeshgarg007

@dgehriger
Copy link
Author

@dgehriger Please see my attached screen capture, are we looking a the same bug?

Yes, that's exactly what I am observing.

@dgehriger
Copy link
Author

dgehriger commented Oct 3, 2022 •
edited
Loading

@rtdany10

Unchecking No Copy for the currency field seems to have fixed the issue. But, was No Copy enabled for some other reason?

Indeed, unchecking No Copy in Journal Entry Account_ fixes it when duplicating existing journal entries. It does, however, not fix it for Journal Entry Templates. The latter directly reference the Account DocType, which doesn't have No Copy checked anyway.

rtdany10 added a commit to rtdany10/erpnext that referenced this issue Oct 3, 2022
@rtdany10
feat(JE): trigger account field when fetched from template
c35adcf 
Closes frappe#32409
@rtdany10 rtdany10 mentioned this issue Oct 3, 2022
Merged
@rtdany10
Copy link
Contributor

rtdany10 commented Oct 3, 2022

@rtdany10

Unchecking No Copy for the currency field seems to have fixed the issue. But, was No Copy enabled for some other reason?

Indeed, unchecking No Copy in Journal Entry Account_ fixes it when duplicating existing journal entries. It does, however, not fix it for Journal Entry Templates. The latter directly reference the Account DocType, which doesn't have No Copy checked anyway.

@dgehriger I've sent a PR to fix the issue.

mergify bot pushed a commit that referenced this issue Oct 5, 2022
@rtdany10 @mergify
feat(JE): trigger account field when fetched from template
baa4fec 
Closes #32409

(cherry picked from commit c35adcf)
mergify bot pushed a commit that referenced this issue Oct 5, 2022
@rtdany10 @mergify
feat(JE): trigger account field when fetched from template
17dd1ab 
Closes #32409

(cherry picked from commit c35adcf)
frappe-pr-bot pushed a commit that referenced this issue Oct 12, 2022
@frappe-bot
chore(release): Bumped to Version 13.40.0
49c9c68 
# [13.40.0](v13.39.5...v13.40.0) (2022-10-12)

### Bug Fixes

* Do not add tax withheld vouchers post tax withheding in one document ([e1c41b9](e1c41b9))
* future attendance marking ([cb4fbd5](cb4fbd5))
* make readings status mandatory in Quality Inspection ([257a2a3](257a2a3))
* mark attendance issue with joining date ([6f8d620](6f8d620))
* mark attendance issue with relieving date ([a9546dd](a9546dd))
* PO cancel post advance payment cancel against PO ([41599cf](41599cf))
* set Quality Inspection status based on readings status ([d67b44f](d67b44f))
* Tax withholding related fixes ([32a9575](32a9575))
* **test:** `test_rejected_qi_validation` ([2763d06](2763d06))
* TooManyWritesError during reposting of stock ([476175b](476175b))

### Features

* cst ux improvement ([552c595](552c595))
* **JE:** trigger account field when fetched from template ([baa4fec](baa4fec)), closes [#32409](#32409)
@frappe-pr-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 13.40.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

frappe-pr-bot pushed a commit that referenced this issue Oct 12, 2022
@frappe-bot
chore(release): Bumped to Version 14.3.0
36b9926 
# [14.3.0](v14.2.3...v14.3.0) (2022-10-12)

### Bug Fixes

* consider outgoingrate while valuation rate calculate ([423c019](423c019))
* consider sales rate as incoming rate for transit warehouse in purchase flow ([948b231](948b231))
* Do not add tax withheld vouchers post tax withheding in one document ([bd8e61b](bd8e61b))
* Explicitly update modified (backport [#32519](#32519)) ([#32575](#32575)) ([154904e](154904e))
* Hanlde rounding loss for internal transfer ([8eda2db](8eda2db))
* Incoming rate precision fixes for intra company transfer ([b653f43](b653f43))
* make readings status mandatory in Quality Inspection ([50d790c](50d790c))
* minor cleanup ([236a5f3](236a5f3))
* more fields reordering related to Tab Break ([db4fbc9](db4fbc9))
* PO cancel post advance payment cancel against PO ([bda25c4](bda25c4))
* removed unnecessary imports ([31782d6](31782d6))
* set Quality Inspection status based on readings status ([e25db8b](e25db8b))
* single column indexes (backport [#32425](#32425)) ([#32513](#32513)) ([2f1b8af](2f1b8af))
* Tax withholding related fixes ([d5f6938](d5f6938))
* test case ([0b26131](0b26131))
* **test:** `test_rejected_qi_validation` ([943e619](943e619))
* TooManyWritesError during reposting of stock ([73742ff](73742ff))
* unlink payment on invoice cancellation ([8ba503b](8ba503b))
* use naming_series in budget ([0a24859](0a24859))
* value error on pos submit ([4b65dd7](4b65dd7))

### Features

* **JE:** trigger account field when fetched from template ([17dd1ab](17dd1ab)), closes [#32409](#32409)
* provision to return non consumed components against the work order ([d0f3818](d0f3818))
* Tab Break in Material Request ([79151be](79151be))
* Tab Break in Purchase Invoice ([89314d4](89314d4))
* Tab Break in Purchase Order ([5a8329a](5a8329a))
* Tab Break in Purchase Receipt ([b092791](b092791))
* Tab Break in Quotation ([b0a9f79](b0a9f79))
* Tab Break in Sales Order, Delivery Note, Sales Invoice and Purchase Order ([31cd96b](31cd96b))
* Tab Break in Supplier Quotation ([22ad3ad](22ad3ad))
@frappe-pr-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 14.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

developmentforpeople pushed a commit to Ayuda-Efectiva/erpnext that referenced this issue Jan 26, 2023
@rtdany10 @developmentforpeople
feat(JE): trigger account field when fetched from template
0957e19 
Closes frappe#32409

(cherry picked from commit c35adcf)
developmentforpeople pushed a commit to Ayuda-Efectiva/erpnext that referenced this issue Jan 26, 2023
@frappe-bot @developmentforpeople
chore(release): Bumped to Version 13.40.0
67e2e63 
# [13.40.0](frappe/erpnext@v13.39.5...v13.40.0) (2022-10-12)

### Bug Fixes

* Do not add tax withheld vouchers post tax withheding in one document ([e1c41b9](frappe@e1c41b9))
* future attendance marking ([cb4fbd5](frappe@cb4fbd5))
* make readings status mandatory in Quality Inspection ([257a2a3](frappe@257a2a3))
* mark attendance issue with joining date ([6f8d620](frappe@6f8d620))
* mark attendance issue with relieving date ([a9546dd](frappe@a9546dd))
* PO cancel post advance payment cancel against PO ([41599cf](frappe@41599cf))
* set Quality Inspection status based on readings status ([d67b44f](frappe@d67b44f))
* Tax withholding related fixes ([32a9575](frappe@32a9575))
* **test:** `test_rejected_qi_validation` ([2763d06](frappe@2763d06))
* TooManyWritesError during reposting of stock ([476175b](frappe@476175b))

### Features

* cst ux improvement ([552c595](frappe@552c595))
* **JE:** trigger account field when fetched from template ([baa4fec](frappe@baa4fec)), closes [frappe#32409](frappe#32409)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accounts bug released valid
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(JE): trigger account field when fetched from template rtdany10/erpnext
4 participants
@frappe-pr-bot @dj12djdjs @rtdany10 @dgehriger