fix: Explicitly update modified #32519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #32519 +/- ##
===========================================
+ Coverage 63.77% 63.78% +0.01%
===========================================
Files 817 817
Lines 58162 58158 -4
===========================================
+ Hits 37091 37098 +7
+ Misses 21071 21060 -11
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 12, 2022
* fix: Explicitly update modified required after frappe/frappe#18301 * chore: fix broken translations (cherry picked from commit 8376fbc)
ankush
added a commit
that referenced
this pull request
Oct 12, 2022
fix: Explicitly update modified (#32519) * fix: Explicitly update modified required after frappe/frappe#18301 * chore: fix broken translations (cherry picked from commit 8376fbc) Co-authored-by: Ankush Menat <ankush@frappe.io>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Oct 12, 2022
# [14.3.0](v14.2.3...v14.3.0) (2022-10-12) ### Bug Fixes * consider outgoingrate while valuation rate calculate ([423c019](423c019)) * consider sales rate as incoming rate for transit warehouse in purchase flow ([948b231](948b231)) * Do not add tax withheld vouchers post tax withheding in one document ([bd8e61b](bd8e61b)) * Explicitly update modified (backport [#32519](#32519)) ([#32575](#32575)) ([154904e](154904e)) * Hanlde rounding loss for internal transfer ([8eda2db](8eda2db)) * Incoming rate precision fixes for intra company transfer ([b653f43](b653f43)) * make readings status mandatory in Quality Inspection ([50d790c](50d790c)) * minor cleanup ([236a5f3](236a5f3)) * more fields reordering related to Tab Break ([db4fbc9](db4fbc9)) * PO cancel post advance payment cancel against PO ([bda25c4](bda25c4)) * removed unnecessary imports ([31782d6](31782d6)) * set Quality Inspection status based on readings status ([e25db8b](e25db8b)) * single column indexes (backport [#32425](#32425)) ([#32513](#32513)) ([2f1b8af](2f1b8af)) * Tax withholding related fixes ([d5f6938](d5f6938)) * test case ([0b26131](0b26131)) * **test:** `test_rejected_qi_validation` ([943e619](943e619)) * TooManyWritesError during reposting of stock ([73742ff](73742ff)) * unlink payment on invoice cancellation ([8ba503b](8ba503b)) * use naming_series in budget ([0a24859](0a24859)) * value error on pos submit ([4b65dd7](4b65dd7)) ### Features * **JE:** trigger account field when fetched from template ([17dd1ab](17dd1ab)), closes [#32409](#32409) * provision to return non consumed components against the work order ([d0f3818](d0f3818)) * Tab Break in Material Request ([79151be](79151be)) * Tab Break in Purchase Invoice ([89314d4](89314d4)) * Tab Break in Purchase Order ([5a8329a](5a8329a)) * Tab Break in Purchase Receipt ([b092791](b092791)) * Tab Break in Quotation ([b0a9f79](b0a9f79)) * Tab Break in Sales Order, Delivery Note, Sales Invoice and Purchase Order ([31cd96b](31cd96b)) * Tab Break in Supplier Quotation ([22ad3ad](22ad3ad))
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
required after frappe/frappe#18301
People use Bin doctype's modified timestamp to write integrations, hence updating it explicitly.
Found out cause my old-timey test started failing 😄 #29746