fix(Payment Entry): splitting outstanding rows as per payment terms #27946

Anuja-pawar · 2021-10-13T11:01:51Z

Issue: Some of the Outstanding invoices gets repeated in Payment Entry irrespective of their Payment Terms.
It occurs while fetching Outstanding Invoices (split as per Payment Terms) in the Payment Entry

Steps to replicate:

Enable Allocate Payment Based on Payment Terms in Payment Terms Template
Create 3 or more Purchase Invoices which has Payment Terms
Try fetching these invoices in a Payment Entry, you would get one or two of the invoices multiple times and one of the outstanding invoices would be missing

In following example, Purchase Invoices PINV-21-00035, PINV-21-00036 should be split in 1 row while PINV-21-00034 should be split in 2 rows as per their payment terms. PINV-21-00037, which doesn't have any payment terms should be fetched along with these.

Before

After

codecov · 2021-10-13T11:43:47Z

Codecov Report

Merging #27946 (e111026) into develop (98f4b90) will increase coverage by 8.87%.
The diff coverage is 6.66%.

@@             Coverage Diff             @@
##           develop   #27946      +/-   ##
===========================================
+ Coverage    46.50%   55.37%   +8.87%     
===========================================
  Files         1248     1248              
  Lines        67681    67685       +4     
===========================================
+ Hits         31475    37482    +6007     
+ Misses       36206    30203    -6003

Impacted Files	Coverage Δ
...xt/accounts/doctype/payment_entry/payment_entry.py	`69.42% <6.66%> (+9.60%)`	⬆️
...e/asset_value_adjustment/asset_value_adjustment.py	`87.80% <0.00%> (-3.66%)`	⬇️
erpnext/portal/utils.py	`30.00% <0.00%> (ø)`
...stock/doctype/purchase_receipt/purchase_receipt.py	`90.61% <0.00%> (+0.26%)`	⬆️
erpnext/projects/doctype/project/project.py	`54.25% <0.00%> (+0.35%)`	⬆️
erpnext/accounts/doctype/account/account.py	`71.09% <0.00%> (+0.39%)`	⬆️
erpnext/projects/doctype/task/task.py	`64.44% <0.00%> (+0.44%)`	⬆️
erpnext/controllers/buying_controller.py	`86.42% <0.00%> (+0.47%)`	⬆️
...cturing/doctype/production_plan/production_plan.py	`69.56% <0.00%> (+0.59%)`	⬆️
...ext/manufacturing/doctype/work_order/work_order.py	`73.33% <0.00%> (+0.65%)`	⬆️
... and 181 more

…awar/erpnext into payment-terms-split-rows

Anuja-pawar · 2021-11-03T09:17:23Z

@Mergifyio backport version-13-hotfix

…27946) (cherry picked from commit d72709d)

mergify · 2021-11-03T09:18:16Z

backport version-13-hotfix

✅ Backports have been created

#28220 fix(Payment Entry): splitting outstanding rows as per payment terms (backport #27946) has been created for branch version-13-hotfix

Anuja-pawar · 2021-11-03T09:18:17Z

@Mergifyio backport version-13-pre-release

…27946) (cherry picked from commit d72709d)

mergify · 2021-11-03T09:18:43Z

backport version-13-pre-release

✅ Backports have been created

#28221 fix(Payment Entry): splitting outstanding rows as per payment terms (backport #27946) has been created for branch version-13-pre-release

…-27946 fix(Payment Entry): splitting outstanding rows as per payment terms (backport #27946)

…se/pr-27946 fix(Payment Entry): splitting outstanding rows as per payment terms (backport #27946)

…rappe#27946) (cherry picked from commit d72709d)

…-release/pr-27946 fix(Payment Entry): splitting outstanding rows as per payment terms (backport frappe#27946)

…rappe#27946) (cherry picked from commit d72709d)

* feat(manufacturing): add link field for quality inspection template on operation (cherry picked from commit 281a9cc) * feat: provision to have limited parameters for in-process quality inspection (cherry picked from commit 6c45f8b) * refactor: use fetch from property for qi template on job card (cherry picked from commit 467324c) * perf: skip get_pricing_rules if no pricing rule exists (cherry picked from commit a500252) * perf: fetch mode of payments data in single query (cherry picked from commit 7b691be) * perf: get total company stock only for purchase order (cherry picked from commit eb3aae8) * perf: skip insertion of stock ledger entry (cherry picked from commit c7fc609) * fix: undo changes to allow negative stock flag (cherry picked from commit 7bafa11) * fix: sider (cherry picked from commit ac381d2) * fix(Payment Entry): splitting outstanding rows as per payment terms (frappe#27946) (cherry picked from commit d72709d) * fix: TDS round off not working from second transaction (cherry picked from commit ca00672) * fix: TDS round off not working from second transaction (cherry picked from commit b7a0853) * fix: Update receivable/payable account on company change (backport frappe#28057) * fix: changes in schedules gets overwritten on save (cherry picked from commit af1b9e1) * fix: Fetch thumbnail from Item master instead of regenerating (cherry picked from commit 94177c0) * fix: re-run patch - Patch will just fetch thumbnails if website items are created, else it will create new website items (cherry picked from commit 11c498d) * fix: Get db values as dict when checking for thumbnail in existing web item (cherry picked from commit 46a5a83) * fix: Check if thumbnail column exists in case of table trimming (cherry picked from commit ac8014e) * fix: Move thumbnail updation to different patch - Thumbnail updation handled via different patch - create_website_items will only have one purpose - added progress bar to `create_website_items` - code cleanup (cherry picked from commit 348a961) * fix: Serial Nos not set in the row after scanning in popup - Avoid whitspaces while calculating length of serial nos (cherry picked from commit 734b57d) * fix: don't reset rates in Timesheet Detail when Activity Type is cleared (backport frappe#28056) * fix: show full item name in search widget (backport frappe#28283) * fix: Avoid automatic customer creation on website user login (cherry picked from commit d824a90) # Conflicts: # erpnext/e_commerce/shopping_cart/utils.py * fix: Sider, Linter - Moved return to next line - Space between function import and body (cherry picked from commit a780f78) * fix: Merge conflicts with e-commerce * fix: POS Closing Entry without linked invoices (backport frappe#28042) * fix: update production plan status (backport frappe#27567) * refactor: shows opening balance from filtered from_date (backport frappe#26877) * fix: Remove warehouse filter on Batch field for Material Receipt (cherry picked from commit 048210a) * chore: Add comment above fix for future reference (cherry picked from commit 48886ee) * fix: Autoemail report not showing dynamic report filters (cherry picked from commit 3a6894f) * Update employee_leave_balance.py fix: Employee Leave Balance report showing wrong figures (cherry picked from commit 632f784) * fix: Make status filter in Fixed Asset Register optional (backport frappe#28126) * fix: Skip empty rows while updating unsaved BOM cost (backport frappe#28136) * v.13.14.1 * feat: employee initial work history updated when transfer is performed (backport frappe#27768) Co-authored-by: Diksha Jadhav <dikshajadhav11.dj@gmail.com> Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com> Co-authored-by: Ankush Menat <ankushmenat@gmail.com> Co-authored-by: Anuja Pawar <60467153+Anuja-pawar@users.noreply.github.com> Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com> Co-authored-by: Noah Jacob <noahjacobkurian@gmail.com> Co-authored-by: marination <maricadsouza221197@gmail.com> Co-authored-by: Goh Yan Chang <yanchang.goh@itechstro.com>

* feat(manufacturing): add link field for quality inspection template on operation (cherry picked from commit 281a9cc) * feat: provision to have limited parameters for in-process quality inspection (cherry picked from commit 6c45f8b) * refactor: use fetch from property for qi template on job card (cherry picked from commit 467324c) * perf: skip get_pricing_rules if no pricing rule exists (cherry picked from commit a500252) * perf: fetch mode of payments data in single query (cherry picked from commit 7b691be) * perf: get total company stock only for purchase order (cherry picked from commit eb3aae8) * perf: skip insertion of stock ledger entry (cherry picked from commit c7fc609) * fix: undo changes to allow negative stock flag (cherry picked from commit 7bafa11) * fix: sider (cherry picked from commit ac381d2) * fix(Payment Entry): splitting outstanding rows as per payment terms (frappe#27946) (cherry picked from commit d72709d) * fix: TDS round off not working from second transaction (cherry picked from commit ca00672) * fix: TDS round off not working from second transaction (cherry picked from commit b7a0853) * fix: Update receivable/payable account on company change (backport frappe#28057) * fix: changes in schedules gets overwritten on save (cherry picked from commit af1b9e1) * fix: Fetch thumbnail from Item master instead of regenerating (cherry picked from commit 94177c0) * fix: re-run patch - Patch will just fetch thumbnails if website items are created, else it will create new website items (cherry picked from commit 11c498d) * fix: Get db values as dict when checking for thumbnail in existing web item (cherry picked from commit 46a5a83) * fix: Check if thumbnail column exists in case of table trimming (cherry picked from commit ac8014e) * fix: Move thumbnail updation to different patch - Thumbnail updation handled via different patch - create_website_items will only have one purpose - added progress bar to `create_website_items` - code cleanup (cherry picked from commit 348a961) * fix: Serial Nos not set in the row after scanning in popup - Avoid whitspaces while calculating length of serial nos (cherry picked from commit 734b57d) * fix: don't reset rates in Timesheet Detail when Activity Type is cleared (backport frappe#28056) * fix: show full item name in search widget (backport frappe#28283) * fix: Avoid automatic customer creation on website user login (cherry picked from commit d824a90) * fix: Sider, Linter - Moved return to next line - Space between function import and body (cherry picked from commit a780f78) * fix: Merge conflicts with e-commerce * fix: POS Closing Entry without linked invoices (backport frappe#28042) * fix: update production plan status (backport frappe#27567) * refactor: shows opening balance from filtered from_date (backport frappe#26877) * fix: Remove warehouse filter on Batch field for Material Receipt (cherry picked from commit 048210a) * chore: Add comment above fix for future reference (cherry picked from commit 48886ee) * fix: Autoemail report not showing dynamic report filters (cherry picked from commit 3a6894f) * Update employee_leave_balance.py fix: Employee Leave Balance report showing wrong figures (cherry picked from commit 632f784) * fix: Make status filter in Fixed Asset Register optional (backport frappe#28126) * fix: Skip empty rows while updating unsaved BOM cost (backport frappe#28136) * v.13.14.1 * feat: employee initial work history updated when transfer is performed (backport frappe#27768) Co-authored-by: Diksha Jadhav <dikshajadhav11.dj@gmail.com> Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com> Co-authored-by: Ankush Menat <ankushmenat@gmail.com> Co-authored-by: Anuja Pawar <60467153+Anuja-pawar@users.noreply.github.com> Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com> Co-authored-by: Noah Jacob <noahjacobkurian@gmail.com> Co-authored-by: marination <maricadsouza221197@gmail.com> Co-authored-by: Goh Yan Chang <yanchang.goh@itechstro.com>

* feat(manufacturing): add link field for quality inspection template on operation (cherry picked from commit 281a9cc) * feat: provision to have limited parameters for in-process quality inspection (cherry picked from commit 6c45f8b) * refactor: use fetch from property for qi template on job card (cherry picked from commit 467324c) * perf: skip get_pricing_rules if no pricing rule exists (cherry picked from commit a500252) * perf: fetch mode of payments data in single query (cherry picked from commit 7b691be) * perf: get total company stock only for purchase order (cherry picked from commit eb3aae8) * perf: skip insertion of stock ledger entry (cherry picked from commit c7fc609) * fix: undo changes to allow negative stock flag (cherry picked from commit 7bafa11) * fix: sider (cherry picked from commit ac381d2) * fix(Payment Entry): splitting outstanding rows as per payment terms (frappe#27946) (cherry picked from commit d72709d) * fix: TDS round off not working from second transaction (cherry picked from commit ca00672) * fix: TDS round off not working from second transaction (cherry picked from commit b7a0853) * fix: Update receivable/payable account on company change (backport frappe#28057) * fix: changes in schedules gets overwritten on save (cherry picked from commit af1b9e1) * fix: Fetch thumbnail from Item master instead of regenerating (cherry picked from commit 94177c0) * fix: re-run patch - Patch will just fetch thumbnails if website items are created, else it will create new website items (cherry picked from commit 11c498d) * fix: Get db values as dict when checking for thumbnail in existing web item (cherry picked from commit 46a5a83) * fix: Check if thumbnail column exists in case of table trimming (cherry picked from commit ac8014e) * fix: Move thumbnail updation to different patch - Thumbnail updation handled via different patch - create_website_items will only have one purpose - added progress bar to `create_website_items` - code cleanup (cherry picked from commit 348a961) * fix: Serial Nos not set in the row after scanning in popup - Avoid whitspaces while calculating length of serial nos (cherry picked from commit 734b57d) * fix: don't reset rates in Timesheet Detail when Activity Type is cleared (backport frappe#28056) * fix: show full item name in search widget (backport frappe#28283) * fix: Avoid automatic customer creation on website user login (cherry picked from commit d824a90) * fix: Sider, Linter - Moved return to next line - Space between function import and body (cherry picked from commit a780f78) * fix: Merge conflicts with e-commerce * fix: POS Closing Entry without linked invoices (backport frappe#28042) * fix: update production plan status (backport frappe#27567) * refactor: shows opening balance from filtered from_date (backport frappe#26877) * fix: Remove warehouse filter on Batch field for Material Receipt (cherry picked from commit 048210a) * chore: Add comment above fix for future reference (cherry picked from commit 48886ee) * fix: Autoemail report not showing dynamic report filters (cherry picked from commit 3a6894f) * Update employee_leave_balance.py fix: Employee Leave Balance report showing wrong figures (cherry picked from commit 632f784) * fix: Make status filter in Fixed Asset Register optional (backport frappe#28126) * fix: Skip empty rows while updating unsaved BOM cost (backport frappe#28136) * v.13.14.1 * feat: employee initial work history updated when transfer is performed (backport frappe#27768) Co-authored-by: Diksha Jadhav <dikshajadhav11.dj@gmail.com> Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com> Co-authored-by: Ankush Menat <ankushmenat@gmail.com> Co-authored-by: Anuja Pawar <60467153+Anuja-pawar@users.noreply.github.com> Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com> Co-authored-by: Noah Jacob <noahjacobkurian@gmail.com> Co-authored-by: marination <maricadsouza221197@gmail.com> Co-authored-by: Goh Yan Chang <yanchang.goh@itechstro.com> Co-authored-by: Diksha Jadhav <dikshajadhav11.dj@gmail.com> Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com> Co-authored-by: Ankush Menat <ankushmenat@gmail.com> Co-authored-by: Anuja Pawar <60467153+Anuja-pawar@users.noreply.github.com> Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com> Co-authored-by: Noah Jacob <noahjacobkurian@gmail.com> Co-authored-by: marination <maricadsouza221197@gmail.com> Co-authored-by: Goh Yan Chang <yanchang.goh@itechstro.com>

* feat(manufacturing): add link field for quality inspection template on operation (cherry picked from commit 281a9cc) * feat: provision to have limited parameters for in-process quality inspection (cherry picked from commit 6c45f8b) * refactor: use fetch from property for qi template on job card (cherry picked from commit 467324c) * perf: skip get_pricing_rules if no pricing rule exists (cherry picked from commit a500252) * perf: fetch mode of payments data in single query (cherry picked from commit 7b691be) * perf: get total company stock only for purchase order (cherry picked from commit eb3aae8) * perf: skip insertion of stock ledger entry (cherry picked from commit c7fc609) * fix: undo changes to allow negative stock flag (cherry picked from commit 7bafa11) * fix: sider (cherry picked from commit ac381d2) * fix(Payment Entry): splitting outstanding rows as per payment terms (frappe#27946) (cherry picked from commit d72709d) * fix: TDS round off not working from second transaction (cherry picked from commit ca00672) * fix: TDS round off not working from second transaction (cherry picked from commit b7a0853) * fix: Update receivable/payable account on company change (backport frappe#28057) * fix: changes in schedules gets overwritten on save (cherry picked from commit af1b9e1) * fix: Fetch thumbnail from Item master instead of regenerating (cherry picked from commit 94177c0) * fix: re-run patch - Patch will just fetch thumbnails if website items are created, else it will create new website items (cherry picked from commit 11c498d) * fix: Get db values as dict when checking for thumbnail in existing web item (cherry picked from commit 46a5a83) * fix: Check if thumbnail column exists in case of table trimming (cherry picked from commit ac8014e) * fix: Move thumbnail updation to different patch - Thumbnail updation handled via different patch - create_website_items will only have one purpose - added progress bar to `create_website_items` - code cleanup (cherry picked from commit 348a961) * fix: Serial Nos not set in the row after scanning in popup - Avoid whitspaces while calculating length of serial nos (cherry picked from commit 734b57d) * fix: don't reset rates in Timesheet Detail when Activity Type is cleared (backport frappe#28056) * fix: show full item name in search widget (backport frappe#28283) * fix: Avoid automatic customer creation on website user login (cherry picked from commit d824a90) # Conflicts: # erpnext/e_commerce/shopping_cart/utils.py * fix: Sider, Linter - Moved return to next line - Space between function import and body (cherry picked from commit a780f78) * fix: Merge conflicts with e-commerce * fix: POS Closing Entry without linked invoices (backport frappe#28042) * fix: update production plan status (backport frappe#27567) * refactor: shows opening balance from filtered from_date (backport frappe#26877) * fix: Remove warehouse filter on Batch field for Material Receipt (cherry picked from commit 048210a) * chore: Add comment above fix for future reference (cherry picked from commit 48886ee) * fix: Autoemail report not showing dynamic report filters (cherry picked from commit 3a6894f) * Update employee_leave_balance.py fix: Employee Leave Balance report showing wrong figures (cherry picked from commit 632f784) * fix: Make status filter in Fixed Asset Register optional (backport frappe#28126) * fix: Skip empty rows while updating unsaved BOM cost (backport frappe#28136) * v.13.14.1 * feat: employee initial work history updated when transfer is performed (backport frappe#27768) Co-authored-by: Diksha Jadhav <dikshajadhav11.dj@gmail.com> Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com> Co-authored-by: Ankush Menat <ankushmenat@gmail.com> Co-authored-by: Anuja Pawar <60467153+Anuja-pawar@users.noreply.github.com> Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com> Co-authored-by: Noah Jacob <noahjacobkurian@gmail.com> Co-authored-by: marination <maricadsouza221197@gmail.com> Co-authored-by: Goh Yan Chang <yanchang.goh@itechstro.com> Co-authored-by: Francisco Roldán <franciscoproldan@gmail.com> Co-authored-by: Diksha Jadhav <dikshajadhav11.dj@gmail.com> Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com> Co-authored-by: Ankush Menat <ankushmenat@gmail.com> Co-authored-by: Anuja Pawar <60467153+Anuja-pawar@users.noreply.github.com> Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com> Co-authored-by: Noah Jacob <noahjacobkurian@gmail.com> Co-authored-by: marination <maricadsouza221197@gmail.com> Co-authored-by: Goh Yan Chang <yanchang.goh@itechstro.com>

* feat(manufacturing): add link field for quality inspection template on operation (cherry picked from commit 281a9cc) * feat: provision to have limited parameters for in-process quality inspection (cherry picked from commit 6c45f8b) * refactor: use fetch from property for qi template on job card (cherry picked from commit 467324c) * perf: skip get_pricing_rules if no pricing rule exists (cherry picked from commit a500252) * perf: fetch mode of payments data in single query (cherry picked from commit 7b691be) * perf: get total company stock only for purchase order (cherry picked from commit eb3aae8) * perf: skip insertion of stock ledger entry (cherry picked from commit c7fc609) * fix: undo changes to allow negative stock flag (cherry picked from commit 7bafa11) * fix: sider (cherry picked from commit ac381d2) * fix(Payment Entry): splitting outstanding rows as per payment terms (frappe#27946) (cherry picked from commit d72709d) * fix: TDS round off not working from second transaction (cherry picked from commit ca00672) * fix: TDS round off not working from second transaction (cherry picked from commit b7a0853) * fix: Update receivable/payable account on company change (backport frappe#28057) * fix: changes in schedules gets overwritten on save (cherry picked from commit af1b9e1) * fix: Fetch thumbnail from Item master instead of regenerating (cherry picked from commit 94177c0) * fix: re-run patch - Patch will just fetch thumbnails if website items are created, else it will create new website items (cherry picked from commit 11c498d) * fix: Get db values as dict when checking for thumbnail in existing web item (cherry picked from commit 46a5a83) * fix: Check if thumbnail column exists in case of table trimming (cherry picked from commit ac8014e) * fix: Move thumbnail updation to different patch - Thumbnail updation handled via different patch - create_website_items will only have one purpose - added progress bar to `create_website_items` - code cleanup (cherry picked from commit 348a961) * fix: Serial Nos not set in the row after scanning in popup - Avoid whitspaces while calculating length of serial nos (cherry picked from commit 734b57d) * fix: don't reset rates in Timesheet Detail when Activity Type is cleared (backport frappe#28056) * fix: show full item name in search widget (backport frappe#28283) * fix: Avoid automatic customer creation on website user login (cherry picked from commit d824a90) * fix: Sider, Linter - Moved return to next line - Space between function import and body (cherry picked from commit a780f78) * fix: Merge conflicts with e-commerce * fix: POS Closing Entry without linked invoices (backport frappe#28042) * fix: update production plan status (backport frappe#27567) * refactor: shows opening balance from filtered from_date (backport frappe#26877) * fix: Remove warehouse filter on Batch field for Material Receipt (cherry picked from commit 048210a) * chore: Add comment above fix for future reference (cherry picked from commit 48886ee) * fix: Autoemail report not showing dynamic report filters (cherry picked from commit 3a6894f) * Update employee_leave_balance.py fix: Employee Leave Balance report showing wrong figures (cherry picked from commit 632f784) * fix: Make status filter in Fixed Asset Register optional (backport frappe#28126) * fix: Skip empty rows while updating unsaved BOM cost (backport frappe#28136) * v.13.14.1 * feat: employee initial work history updated when transfer is performed (backport frappe#27768) Co-authored-by: Diksha Jadhav <dikshajadhav11.dj@gmail.com> Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com> Co-authored-by: Ankush Menat <ankushmenat@gmail.com> Co-authored-by: Anuja Pawar <60467153+Anuja-pawar@users.noreply.github.com> Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com> Co-authored-by: Noah Jacob <noahjacobkurian@gmail.com> Co-authored-by: marination <maricadsouza221197@gmail.com> Co-authored-by: Goh Yan Chang <yanchang.goh@itechstro.com> Co-authored-by: Diksha Jadhav <dikshajadhav11.dj@gmail.com> Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com> Co-authored-by: Ankush Menat <ankushmenat@gmail.com> Co-authored-by: Anuja Pawar <60467153+Anuja-pawar@users.noreply.github.com> Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com> Co-authored-by: Noah Jacob <noahjacobkurian@gmail.com> Co-authored-by: marination <maricadsouza221197@gmail.com> Co-authored-by: Goh Yan Chang <yanchang.goh@itechstro.com>

fix: splitting outstanding rows wrt payment terms

ac63383

Anuja-pawar requested review from nextchamp-saqib and deepeshgarg007 October 13, 2021 11:02

Merge branch 'develop' into payment-terms-split-rows

c3a3cbe

Anuja-pawar and others added 7 commits October 13, 2021 23:24

Merge branch 'develop' into payment-terms-split-rows

26ee5d9

fix: date condition for negative outstanding invoices

7a58cff

Merge branch 'payment-terms-split-rows' of https://github.com/Anuja-p…

fc97425

…awar/erpnext into payment-terms-split-rows

Merge branch 'develop' into payment-terms-split-rows

a1c1a84

Merge branch 'develop' into payment-terms-split-rows

384eb32

fix: to allocate amount based on paid amount

9248697

Merge branch 'payment-terms-split-rows' of https://github.com/Anuja-p…

a28704f

…awar/erpnext into payment-terms-split-rows

Anuja-pawar marked this pull request as ready for review October 18, 2021 18:32

Anuja-pawar and others added 9 commits October 19, 2021 00:02

Merge branch 'develop' into payment-terms-split-rows

a0b64a0

Merge branch 'develop' into payment-terms-split-rows

66e034a

fix: added row no. in error message

65e3a33

Merge branch 'develop' into payment-terms-split-rows

d223494

Merge branch 'develop' into payment-terms-split-rows

ebaeb5f

Merge branch 'develop' into payment-terms-split-rows

01bf991

Merge branch 'develop' into payment-terms-split-rows

09287af

Merge branch 'develop' into payment-terms-split-rows

7f555cf

Merge branch 'develop' into payment-terms-split-rows

e111026

nextchamp-saqib approved these changes Nov 2, 2021

View reviewed changes

nextchamp-saqib merged commit d72709d into frappe:develop Nov 2, 2021

mergify bot mentioned this pull request Nov 3, 2021

fix(Payment Entry): splitting outstanding rows as per payment terms (backport #27946) #28220

Merged

mergify bot pushed a commit that referenced this pull request Nov 3, 2021

fix(Payment Entry): splitting outstanding rows as per payment terms (#…

fa24b98

…27946) (cherry picked from commit d72709d)

mergify bot pushed a commit that referenced this pull request Nov 3, 2021

fix(Payment Entry): splitting outstanding rows as per payment terms (#…

2c92668

…27946) (cherry picked from commit d72709d)

mergify bot mentioned this pull request Nov 3, 2021

fix(Payment Entry): splitting outstanding rows as per payment terms (backport #27946) #28221

Merged

nextchamp-saqib added a commit that referenced this pull request Nov 3, 2021

Merge pull request #28220 from frappe/mergify/bp/version-13-hotfix/pr…

1ba2a47

…-27946 fix(Payment Entry): splitting outstanding rows as per payment terms (backport #27946)

nextchamp-saqib added a commit that referenced this pull request Nov 3, 2021

Merge pull request #28221 from frappe/mergify/bp/version-13-pre-relea…

9a3c669

…se/pr-27946 fix(Payment Entry): splitting outstanding rows as per payment terms (backport #27946)

rohitwaghchaure mentioned this pull request Nov 9, 2021

chore: Added change log for version 13.14.0 #28305

Merged

asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021

fix(Payment Entry): splitting outstanding rows as per payment terms (f…

9e740ec

…rappe#27946) (cherry picked from commit d72709d)

asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021

Merge pull request frappe#28221 from frappe/mergify/bp/version-13-pre…

bc3959e

…-release/pr-27946 fix(Payment Entry): splitting outstanding rows as per payment terms (backport frappe#27946)

fproldan pushed a commit to fproldan/erpnext that referenced this pull request Aug 2, 2022

fix(Payment Entry): splitting outstanding rows as per payment terms (f…

dbfcc57

…rappe#27946) (cherry picked from commit d72709d)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(Payment Entry): splitting outstanding rows as per payment terms #27946

fix(Payment Entry): splitting outstanding rows as per payment terms #27946

Anuja-pawar commented Oct 13, 2021 •

edited

codecov bot commented Oct 13, 2021 •

edited

Anuja-pawar commented Nov 3, 2021

mergify bot commented Nov 3, 2021

Anuja-pawar commented Nov 3, 2021

mergify bot commented Nov 3, 2021

fix(Payment Entry): splitting outstanding rows as per payment terms #27946

fix(Payment Entry): splitting outstanding rows as per payment terms #27946

Conversation

Anuja-pawar commented Oct 13, 2021 • edited

codecov bot commented Oct 13, 2021 • edited

Codecov Report

Anuja-pawar commented Nov 3, 2021

mergify bot commented Nov 3, 2021

✅ Backports have been created

Anuja-pawar commented Nov 3, 2021

mergify bot commented Nov 3, 2021

✅ Backports have been created

Anuja-pawar commented Oct 13, 2021 •

edited

codecov bot commented Oct 13, 2021 •

edited