refactor: shows opening balance from filtered from_date #26877

noahjacob · 2021-08-10T08:54:10Z

Before

Stock Balance

While calculating opening balances for the stock balance report, opening balances were only calculated for stock recos created before the filtered from_date and not the set from_date.
If a "Stock Reconciliation" was created for opening stock and the stock balance report was generated with from_date set to the date when the opening stock was created, the "Opening Balance " would not reflect.

Stock Balances

Stock Balance with same date as the Stock Reconciliation

Stock Balance with a date after the Stock Reconciliation

Stock Ledger

If a stock entry was created on filtered from_date at 00:00:00, the entry was considered as the Opening Balance.

Stock Ledgers

Stock Ledger with a date before the Stock Entry

Stock Ledger with same date as the Stock Entry created at 00:00:00

After

Stock Balance

Now also calculates opening balances if the date is the same as from_date in the filters.

Stock Reconciliation

Stock Ledger

Initially only considers sles before the from_date.
Now checks if any "Stock Reconciliation" Entry is present with the same filtered from_date. If any, the entry is removed from the Stock Ledger and added as the Opening Balance.

no_docs

erpnext/stock/report/stock_balance/stock_balance.py

… ledger

codecov · 2021-10-19T14:51:26Z

Codecov Report

Merging #26877 (a2aed39) into develop (35fe065) will decrease coverage by 0.07%.
The diff coverage is 42.85%.

@@             Coverage Diff             @@
##           develop   #26877      +/-   ##
===========================================
- Coverage    55.19%   55.12%   -0.08%     
===========================================
  Files         1255     1255              
  Lines        67871    67875       +4     
===========================================
- Hits         37464    37415      -49     
- Misses       30407    30460      +53

Impacted Files	Coverage Δ
erpnext/stock/report/stock_ledger/stock_ledger.py	`78.22% <33.33%> (-1.78%)`	⬇️
...rpnext/stock/report/stock_balance/stock_balance.py	`79.41% <100.00%> (ø)`
erpnext/utilities/product.py	`15.94% <0.00%> (-34.79%)`	⬇️
...wise_balance_history/batch_wise_balance_history.py	`69.49% <0.00%> (-23.73%)`	⬇️
erpnext/shopping_cart/product_info.py	`32.35% <0.00%> (-20.59%)`	⬇️
...eport/item_variant_details/item_variant_details.py	`84.52% <0.00%> (-3.58%)`	⬇️
...e/shopping_cart_settings/shopping_cart_settings.py	`66.03% <0.00%> (-1.89%)`	⬇️
.../hr/doctype/upload_attendance/upload_attendance.py	`45.11% <0.00%> (-1.51%)`	⬇️
erpnext/shopping_cart/product_query.py	`61.19% <0.00%> (-1.50%)`	⬇️
.../report/stock_projected_qty/stock_projected_qty.py	`88.31% <0.00%> (-1.30%)`	⬇️
... and 15 more

* refactor: shows opening balance from filtered from_date * refactor: opening balance considered from filtered from_date in stock ledger * fix: check if stock reco is opening and misc cleanups (cherry picked from commit fdaf93f)

) * refactor: shows opening balance from filtered from_date * refactor: opening balance considered from filtered from_date in stock ledger * fix: check if stock reco is opening and misc cleanups (cherry picked from commit fdaf93f) Co-authored-by: Noah Jacob <noahjacobkurian@gmail.com>

frappe#28072) * refactor: shows opening balance from filtered from_date * refactor: opening balance considered from filtered from_date in stock ledger * fix: check if stock reco is opening and misc cleanups (cherry picked from commit fdaf93f) Co-authored-by: Noah Jacob <noahjacobkurian@gmail.com>

…ppe#26877)

* feat(manufacturing): add link field for quality inspection template on operation (cherry picked from commit 281a9cc) * feat: provision to have limited parameters for in-process quality inspection (cherry picked from commit 6c45f8b) * refactor: use fetch from property for qi template on job card (cherry picked from commit 467324c) * perf: skip get_pricing_rules if no pricing rule exists (cherry picked from commit a500252) * perf: fetch mode of payments data in single query (cherry picked from commit 7b691be) * perf: get total company stock only for purchase order (cherry picked from commit eb3aae8) * perf: skip insertion of stock ledger entry (cherry picked from commit c7fc609) * fix: undo changes to allow negative stock flag (cherry picked from commit 7bafa11) * fix: sider (cherry picked from commit ac381d2) * fix(Payment Entry): splitting outstanding rows as per payment terms (frappe#27946) (cherry picked from commit d72709d) * fix: TDS round off not working from second transaction (cherry picked from commit ca00672) * fix: TDS round off not working from second transaction (cherry picked from commit b7a0853) * fix: Update receivable/payable account on company change (backport frappe#28057) * fix: changes in schedules gets overwritten on save (cherry picked from commit af1b9e1) * fix: Fetch thumbnail from Item master instead of regenerating (cherry picked from commit 94177c0) * fix: re-run patch - Patch will just fetch thumbnails if website items are created, else it will create new website items (cherry picked from commit 11c498d) * fix: Get db values as dict when checking for thumbnail in existing web item (cherry picked from commit 46a5a83) * fix: Check if thumbnail column exists in case of table trimming (cherry picked from commit ac8014e) * fix: Move thumbnail updation to different patch - Thumbnail updation handled via different patch - create_website_items will only have one purpose - added progress bar to `create_website_items` - code cleanup (cherry picked from commit 348a961) * fix: Serial Nos not set in the row after scanning in popup - Avoid whitspaces while calculating length of serial nos (cherry picked from commit 734b57d) * fix: don't reset rates in Timesheet Detail when Activity Type is cleared (backport frappe#28056) * fix: show full item name in search widget (backport frappe#28283) * fix: Avoid automatic customer creation on website user login (cherry picked from commit d824a90) # Conflicts: # erpnext/e_commerce/shopping_cart/utils.py * fix: Sider, Linter - Moved return to next line - Space between function import and body (cherry picked from commit a780f78) * fix: Merge conflicts with e-commerce * fix: POS Closing Entry without linked invoices (backport frappe#28042) * fix: update production plan status (backport frappe#27567) * refactor: shows opening balance from filtered from_date (backport frappe#26877) * fix: Remove warehouse filter on Batch field for Material Receipt (cherry picked from commit 048210a) * chore: Add comment above fix for future reference (cherry picked from commit 48886ee) * fix: Autoemail report not showing dynamic report filters (cherry picked from commit 3a6894f) * Update employee_leave_balance.py fix: Employee Leave Balance report showing wrong figures (cherry picked from commit 632f784) * fix: Make status filter in Fixed Asset Register optional (backport frappe#28126) * fix: Skip empty rows while updating unsaved BOM cost (backport frappe#28136) * v.13.14.1 * feat: employee initial work history updated when transfer is performed (backport frappe#27768) Co-authored-by: Diksha Jadhav <dikshajadhav11.dj@gmail.com> Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com> Co-authored-by: Ankush Menat <ankushmenat@gmail.com> Co-authored-by: Anuja Pawar <60467153+Anuja-pawar@users.noreply.github.com> Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com> Co-authored-by: Noah Jacob <noahjacobkurian@gmail.com> Co-authored-by: marination <maricadsouza221197@gmail.com> Co-authored-by: Goh Yan Chang <yanchang.goh@itechstro.com>

* feat(manufacturing): add link field for quality inspection template on operation (cherry picked from commit 281a9cc) * feat: provision to have limited parameters for in-process quality inspection (cherry picked from commit 6c45f8b) * refactor: use fetch from property for qi template on job card (cherry picked from commit 467324c) * perf: skip get_pricing_rules if no pricing rule exists (cherry picked from commit a500252) * perf: fetch mode of payments data in single query (cherry picked from commit 7b691be) * perf: get total company stock only for purchase order (cherry picked from commit eb3aae8) * perf: skip insertion of stock ledger entry (cherry picked from commit c7fc609) * fix: undo changes to allow negative stock flag (cherry picked from commit 7bafa11) * fix: sider (cherry picked from commit ac381d2) * fix(Payment Entry): splitting outstanding rows as per payment terms (frappe#27946) (cherry picked from commit d72709d) * fix: TDS round off not working from second transaction (cherry picked from commit ca00672) * fix: TDS round off not working from second transaction (cherry picked from commit b7a0853) * fix: Update receivable/payable account on company change (backport frappe#28057) * fix: changes in schedules gets overwritten on save (cherry picked from commit af1b9e1) * fix: Fetch thumbnail from Item master instead of regenerating (cherry picked from commit 94177c0) * fix: re-run patch - Patch will just fetch thumbnails if website items are created, else it will create new website items (cherry picked from commit 11c498d) * fix: Get db values as dict when checking for thumbnail in existing web item (cherry picked from commit 46a5a83) * fix: Check if thumbnail column exists in case of table trimming (cherry picked from commit ac8014e) * fix: Move thumbnail updation to different patch - Thumbnail updation handled via different patch - create_website_items will only have one purpose - added progress bar to `create_website_items` - code cleanup (cherry picked from commit 348a961) * fix: Serial Nos not set in the row after scanning in popup - Avoid whitspaces while calculating length of serial nos (cherry picked from commit 734b57d) * fix: don't reset rates in Timesheet Detail when Activity Type is cleared (backport frappe#28056) * fix: show full item name in search widget (backport frappe#28283) * fix: Avoid automatic customer creation on website user login (cherry picked from commit d824a90) * fix: Sider, Linter - Moved return to next line - Space between function import and body (cherry picked from commit a780f78) * fix: Merge conflicts with e-commerce * fix: POS Closing Entry without linked invoices (backport frappe#28042) * fix: update production plan status (backport frappe#27567) * refactor: shows opening balance from filtered from_date (backport frappe#26877) * fix: Remove warehouse filter on Batch field for Material Receipt (cherry picked from commit 048210a) * chore: Add comment above fix for future reference (cherry picked from commit 48886ee) * fix: Autoemail report not showing dynamic report filters (cherry picked from commit 3a6894f) * Update employee_leave_balance.py fix: Employee Leave Balance report showing wrong figures (cherry picked from commit 632f784) * fix: Make status filter in Fixed Asset Register optional (backport frappe#28126) * fix: Skip empty rows while updating unsaved BOM cost (backport frappe#28136) * v.13.14.1 * feat: employee initial work history updated when transfer is performed (backport frappe#27768) Co-authored-by: Diksha Jadhav <dikshajadhav11.dj@gmail.com> Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com> Co-authored-by: Ankush Menat <ankushmenat@gmail.com> Co-authored-by: Anuja Pawar <60467153+Anuja-pawar@users.noreply.github.com> Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com> Co-authored-by: Noah Jacob <noahjacobkurian@gmail.com> Co-authored-by: marination <maricadsouza221197@gmail.com> Co-authored-by: Goh Yan Chang <yanchang.goh@itechstro.com>

* feat(manufacturing): add link field for quality inspection template on operation (cherry picked from commit 281a9cc) * feat: provision to have limited parameters for in-process quality inspection (cherry picked from commit 6c45f8b) * refactor: use fetch from property for qi template on job card (cherry picked from commit 467324c) * perf: skip get_pricing_rules if no pricing rule exists (cherry picked from commit a500252) * perf: fetch mode of payments data in single query (cherry picked from commit 7b691be) * perf: get total company stock only for purchase order (cherry picked from commit eb3aae8) * perf: skip insertion of stock ledger entry (cherry picked from commit c7fc609) * fix: undo changes to allow negative stock flag (cherry picked from commit 7bafa11) * fix: sider (cherry picked from commit ac381d2) * fix(Payment Entry): splitting outstanding rows as per payment terms (frappe#27946) (cherry picked from commit d72709d) * fix: TDS round off not working from second transaction (cherry picked from commit ca00672) * fix: TDS round off not working from second transaction (cherry picked from commit b7a0853) * fix: Update receivable/payable account on company change (backport frappe#28057) * fix: changes in schedules gets overwritten on save (cherry picked from commit af1b9e1) * fix: Fetch thumbnail from Item master instead of regenerating (cherry picked from commit 94177c0) * fix: re-run patch - Patch will just fetch thumbnails if website items are created, else it will create new website items (cherry picked from commit 11c498d) * fix: Get db values as dict when checking for thumbnail in existing web item (cherry picked from commit 46a5a83) * fix: Check if thumbnail column exists in case of table trimming (cherry picked from commit ac8014e) * fix: Move thumbnail updation to different patch - Thumbnail updation handled via different patch - create_website_items will only have one purpose - added progress bar to `create_website_items` - code cleanup (cherry picked from commit 348a961) * fix: Serial Nos not set in the row after scanning in popup - Avoid whitspaces while calculating length of serial nos (cherry picked from commit 734b57d) * fix: don't reset rates in Timesheet Detail when Activity Type is cleared (backport frappe#28056) * fix: show full item name in search widget (backport frappe#28283) * fix: Avoid automatic customer creation on website user login (cherry picked from commit d824a90) * fix: Sider, Linter - Moved return to next line - Space between function import and body (cherry picked from commit a780f78) * fix: Merge conflicts with e-commerce * fix: POS Closing Entry without linked invoices (backport frappe#28042) * fix: update production plan status (backport frappe#27567) * refactor: shows opening balance from filtered from_date (backport frappe#26877) * fix: Remove warehouse filter on Batch field for Material Receipt (cherry picked from commit 048210a) * chore: Add comment above fix for future reference (cherry picked from commit 48886ee) * fix: Autoemail report not showing dynamic report filters (cherry picked from commit 3a6894f) * Update employee_leave_balance.py fix: Employee Leave Balance report showing wrong figures (cherry picked from commit 632f784) * fix: Make status filter in Fixed Asset Register optional (backport frappe#28126) * fix: Skip empty rows while updating unsaved BOM cost (backport frappe#28136) * v.13.14.1 * feat: employee initial work history updated when transfer is performed (backport frappe#27768) Co-authored-by: Diksha Jadhav <dikshajadhav11.dj@gmail.com> Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com> Co-authored-by: Ankush Menat <ankushmenat@gmail.com> Co-authored-by: Anuja Pawar <60467153+Anuja-pawar@users.noreply.github.com> Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com> Co-authored-by: Noah Jacob <noahjacobkurian@gmail.com> Co-authored-by: marination <maricadsouza221197@gmail.com> Co-authored-by: Goh Yan Chang <yanchang.goh@itechstro.com> Co-authored-by: Diksha Jadhav <dikshajadhav11.dj@gmail.com> Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com> Co-authored-by: Ankush Menat <ankushmenat@gmail.com> Co-authored-by: Anuja Pawar <60467153+Anuja-pawar@users.noreply.github.com> Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com> Co-authored-by: Noah Jacob <noahjacobkurian@gmail.com> Co-authored-by: marination <maricadsouza221197@gmail.com> Co-authored-by: Goh Yan Chang <yanchang.goh@itechstro.com>

* feat(manufacturing): add link field for quality inspection template on operation (cherry picked from commit 281a9cc) * feat: provision to have limited parameters for in-process quality inspection (cherry picked from commit 6c45f8b) * refactor: use fetch from property for qi template on job card (cherry picked from commit 467324c) * perf: skip get_pricing_rules if no pricing rule exists (cherry picked from commit a500252) * perf: fetch mode of payments data in single query (cherry picked from commit 7b691be) * perf: get total company stock only for purchase order (cherry picked from commit eb3aae8) * perf: skip insertion of stock ledger entry (cherry picked from commit c7fc609) * fix: undo changes to allow negative stock flag (cherry picked from commit 7bafa11) * fix: sider (cherry picked from commit ac381d2) * fix(Payment Entry): splitting outstanding rows as per payment terms (frappe#27946) (cherry picked from commit d72709d) * fix: TDS round off not working from second transaction (cherry picked from commit ca00672) * fix: TDS round off not working from second transaction (cherry picked from commit b7a0853) * fix: Update receivable/payable account on company change (backport frappe#28057) * fix: changes in schedules gets overwritten on save (cherry picked from commit af1b9e1) * fix: Fetch thumbnail from Item master instead of regenerating (cherry picked from commit 94177c0) * fix: re-run patch - Patch will just fetch thumbnails if website items are created, else it will create new website items (cherry picked from commit 11c498d) * fix: Get db values as dict when checking for thumbnail in existing web item (cherry picked from commit 46a5a83) * fix: Check if thumbnail column exists in case of table trimming (cherry picked from commit ac8014e) * fix: Move thumbnail updation to different patch - Thumbnail updation handled via different patch - create_website_items will only have one purpose - added progress bar to `create_website_items` - code cleanup (cherry picked from commit 348a961) * fix: Serial Nos not set in the row after scanning in popup - Avoid whitspaces while calculating length of serial nos (cherry picked from commit 734b57d) * fix: don't reset rates in Timesheet Detail when Activity Type is cleared (backport frappe#28056) * fix: show full item name in search widget (backport frappe#28283) * fix: Avoid automatic customer creation on website user login (cherry picked from commit d824a90) # Conflicts: # erpnext/e_commerce/shopping_cart/utils.py * fix: Sider, Linter - Moved return to next line - Space between function import and body (cherry picked from commit a780f78) * fix: Merge conflicts with e-commerce * fix: POS Closing Entry without linked invoices (backport frappe#28042) * fix: update production plan status (backport frappe#27567) * refactor: shows opening balance from filtered from_date (backport frappe#26877) * fix: Remove warehouse filter on Batch field for Material Receipt (cherry picked from commit 048210a) * chore: Add comment above fix for future reference (cherry picked from commit 48886ee) * fix: Autoemail report not showing dynamic report filters (cherry picked from commit 3a6894f) * Update employee_leave_balance.py fix: Employee Leave Balance report showing wrong figures (cherry picked from commit 632f784) * fix: Make status filter in Fixed Asset Register optional (backport frappe#28126) * fix: Skip empty rows while updating unsaved BOM cost (backport frappe#28136) * v.13.14.1 * feat: employee initial work history updated when transfer is performed (backport frappe#27768) Co-authored-by: Diksha Jadhav <dikshajadhav11.dj@gmail.com> Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com> Co-authored-by: Ankush Menat <ankushmenat@gmail.com> Co-authored-by: Anuja Pawar <60467153+Anuja-pawar@users.noreply.github.com> Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com> Co-authored-by: Noah Jacob <noahjacobkurian@gmail.com> Co-authored-by: marination <maricadsouza221197@gmail.com> Co-authored-by: Goh Yan Chang <yanchang.goh@itechstro.com> Co-authored-by: Francisco Roldán <franciscoproldan@gmail.com> Co-authored-by: Diksha Jadhav <dikshajadhav11.dj@gmail.com> Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com> Co-authored-by: Ankush Menat <ankushmenat@gmail.com> Co-authored-by: Anuja Pawar <60467153+Anuja-pawar@users.noreply.github.com> Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com> Co-authored-by: Noah Jacob <noahjacobkurian@gmail.com> Co-authored-by: marination <maricadsouza221197@gmail.com> Co-authored-by: Goh Yan Chang <yanchang.goh@itechstro.com>

* feat(manufacturing): add link field for quality inspection template on operation (cherry picked from commit 281a9cc) * feat: provision to have limited parameters for in-process quality inspection (cherry picked from commit 6c45f8b) * refactor: use fetch from property for qi template on job card (cherry picked from commit 467324c) * perf: skip get_pricing_rules if no pricing rule exists (cherry picked from commit a500252) * perf: fetch mode of payments data in single query (cherry picked from commit 7b691be) * perf: get total company stock only for purchase order (cherry picked from commit eb3aae8) * perf: skip insertion of stock ledger entry (cherry picked from commit c7fc609) * fix: undo changes to allow negative stock flag (cherry picked from commit 7bafa11) * fix: sider (cherry picked from commit ac381d2) * fix(Payment Entry): splitting outstanding rows as per payment terms (frappe#27946) (cherry picked from commit d72709d) * fix: TDS round off not working from second transaction (cherry picked from commit ca00672) * fix: TDS round off not working from second transaction (cherry picked from commit b7a0853) * fix: Update receivable/payable account on company change (backport frappe#28057) * fix: changes in schedules gets overwritten on save (cherry picked from commit af1b9e1) * fix: Fetch thumbnail from Item master instead of regenerating (cherry picked from commit 94177c0) * fix: re-run patch - Patch will just fetch thumbnails if website items are created, else it will create new website items (cherry picked from commit 11c498d) * fix: Get db values as dict when checking for thumbnail in existing web item (cherry picked from commit 46a5a83) * fix: Check if thumbnail column exists in case of table trimming (cherry picked from commit ac8014e) * fix: Move thumbnail updation to different patch - Thumbnail updation handled via different patch - create_website_items will only have one purpose - added progress bar to `create_website_items` - code cleanup (cherry picked from commit 348a961) * fix: Serial Nos not set in the row after scanning in popup - Avoid whitspaces while calculating length of serial nos (cherry picked from commit 734b57d) * fix: don't reset rates in Timesheet Detail when Activity Type is cleared (backport frappe#28056) * fix: show full item name in search widget (backport frappe#28283) * fix: Avoid automatic customer creation on website user login (cherry picked from commit d824a90) * fix: Sider, Linter - Moved return to next line - Space between function import and body (cherry picked from commit a780f78) * fix: Merge conflicts with e-commerce * fix: POS Closing Entry without linked invoices (backport frappe#28042) * fix: update production plan status (backport frappe#27567) * refactor: shows opening balance from filtered from_date (backport frappe#26877) * fix: Remove warehouse filter on Batch field for Material Receipt (cherry picked from commit 048210a) * chore: Add comment above fix for future reference (cherry picked from commit 48886ee) * fix: Autoemail report not showing dynamic report filters (cherry picked from commit 3a6894f) * Update employee_leave_balance.py fix: Employee Leave Balance report showing wrong figures (cherry picked from commit 632f784) * fix: Make status filter in Fixed Asset Register optional (backport frappe#28126) * fix: Skip empty rows while updating unsaved BOM cost (backport frappe#28136) * v.13.14.1 * feat: employee initial work history updated when transfer is performed (backport frappe#27768) Co-authored-by: Diksha Jadhav <dikshajadhav11.dj@gmail.com> Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com> Co-authored-by: Ankush Menat <ankushmenat@gmail.com> Co-authored-by: Anuja Pawar <60467153+Anuja-pawar@users.noreply.github.com> Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com> Co-authored-by: Noah Jacob <noahjacobkurian@gmail.com> Co-authored-by: marination <maricadsouza221197@gmail.com> Co-authored-by: Goh Yan Chang <yanchang.goh@itechstro.com> Co-authored-by: Diksha Jadhav <dikshajadhav11.dj@gmail.com> Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com> Co-authored-by: Ankush Menat <ankushmenat@gmail.com> Co-authored-by: Anuja Pawar <60467153+Anuja-pawar@users.noreply.github.com> Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com> Co-authored-by: Noah Jacob <noahjacobkurian@gmail.com> Co-authored-by: marination <maricadsouza221197@gmail.com> Co-authored-by: Goh Yan Chang <yanchang.goh@itechstro.com>

noahjacob requested review from ankush, marination and rohitwaghchaure as code owners August 10, 2021 08:54

ankush reviewed Aug 10, 2021

View reviewed changes

erpnext/stock/report/stock_balance/stock_balance.py Outdated Show resolved Hide resolved

ankush added old-backport version-12-hotfix backport version-13-hotfix labels Aug 10, 2021

refactor: shows opening balance from filtered from_date

6296552

noahjacob force-pushed the stock_balance_feat branch from 96db5b9 to 6296552 Compare August 10, 2021 13:43

This was referenced Aug 10, 2021

refactor: shows opening balance from filtered from_date (bp #26877) #26886

Closed

refactor: shows opening balance from filtered from_date (bp #26877) #26887

Closed

ankush removed old-backport version-12-hotfix backport version-13-hotfix labels Aug 10, 2021

ankush reviewed Aug 11, 2021

View reviewed changes

erpnext/stock/report/stock_balance/stock_balance.py Outdated Show resolved Hide resolved

marination assigned ankush Aug 25, 2021

stale bot added the inactive label Sep 9, 2021

frappe deleted a comment from stale bot Sep 9, 2021

ankush removed the inactive label Sep 9, 2021

nabinhait and others added 2 commits September 14, 2021 11:41

Merge branch 'develop' into stock_balance_feat

2c2c127

refactor: opening balance considered from filtered from_date in stock…

b31013b

… ledger

stale bot added the inactive label Oct 6, 2021

stale bot closed this Oct 9, 2021

noahjacob reopened this Oct 11, 2021

stale bot removed the inactive label Oct 11, 2021

frappe deleted a comment from stale bot Oct 19, 2021

frappe deleted a comment from codecov bot Oct 19, 2021

Merge branch 'develop' into stock_balance_feat

9a50978

ankush added the backport version-13-hotfix label Oct 19, 2021

ankush and others added 2 commits October 23, 2021 20:21

Merge branch 'develop' into stock_balance_feat

c613a08

fix: check if stock reco is opening and misc cleanups

a2aed39

ankush approved these changes Oct 23, 2021

View reviewed changes

ankush added the squash Meant to tell reviewers that this PR should be squashed into a single commit while merging. label Oct 23, 2021

ankush merged commit fdaf93f into frappe:develop Oct 23, 2021

mergify bot mentioned this pull request Oct 23, 2021

refactor: shows opening balance from filtered from_date (backport #26877) #28072

Merged

rohitwaghchaure mentioned this pull request Nov 9, 2021

chore: Added change log for version 13.14.0 #28305

Merged

deepeshgarg007 mentioned this pull request Jul 18, 2022

List of V14 features & enhancements #31620

Closed

fproldan added a commit to fproldan/erpnext that referenced this pull request Aug 2, 2022

refactor: shows opening balance from filtered from_date (backport fra…

d3cf4ee

…ppe#26877)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: shows opening balance from filtered from_date #26877

refactor: shows opening balance from filtered from_date #26877

noahjacob commented Aug 10, 2021 •

edited

codecov bot commented Oct 19, 2021 •

edited

refactor: shows opening balance from filtered from_date #26877

refactor: shows opening balance from filtered from_date #26877

Conversation

noahjacob commented Aug 10, 2021 • edited

Before

Stock Balance

Stock Balance with same date as the Stock Reconciliation

Stock Balance with a date after the Stock Reconciliation

Stock Ledger

Stock Ledger with a date before the Stock Entry

Stock Ledger with same date as the Stock Entry created at 00:00:00

After

Stock Balance

Stock Ledger

codecov bot commented Oct 19, 2021 • edited

Codecov Report

noahjacob commented Aug 10, 2021 •

edited

codecov bot commented Oct 19, 2021 •

edited