Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update receivable/payable account on company change #28057

Merged
merged 2 commits into from
Oct 26, 2021

Conversation

deepeshgarg007
Copy link
Member

@deepeshgarg007 deepeshgarg007 commented Oct 21, 2021

On changing the company in Sales/Purchase Invoice the Debit To/Credit To was not getting auto-updated and users were getting an error on submission. This PR fixes that.

Steps to test:

  1. Check the Debit To/Credit To account in Sales/Purchase Invoice
  2. Change the company to some other company.
  3. The above mentioned accounts should be auto updated based on the company

@deepeshgarg007
Copy link
Member Author

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Oct 26, 2021

backport version-13-hotfix

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

@mergify
Copy link
Contributor

mergify bot commented Oct 26, 2021

backport version-13-hotfix

✅ Backports have been created

AfshanKhan added a commit that referenced this pull request Oct 27, 2021
…8057) (#28087)

* fix: Update receivable/payable account on company change

(cherry picked from commit 65025fb)

# Conflicts:
#	erpnext/accounts/doctype/sales_invoice/sales_invoice.js

* fix: Update sales_invoice.js

Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com>
Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com>
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
…appe#28057) (frappe#28087)

* fix: Update receivable/payable account on company change

(cherry picked from commit 65025fb)

# Conflicts:
#	erpnext/accounts/doctype/sales_invoice/sales_invoice.js

* fix: Update sales_invoice.js

Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com>
Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com>
fproldan added a commit to fproldan/erpnext that referenced this pull request Aug 2, 2022
ValentinaPruvost pushed a commit to fproldan/erpnext that referenced this pull request Aug 8, 2022
* feat(manufacturing): add link field for  quality inspection template on operation

(cherry picked from commit 281a9cc)

* feat: provision to have limited parameters for in-process quality inspection

(cherry picked from commit 6c45f8b)

* refactor: use fetch from property for qi template on job card

(cherry picked from commit 467324c)

* perf: skip get_pricing_rules if no pricing rule exists

(cherry picked from commit a500252)

* perf: fetch mode of payments data in single query

(cherry picked from commit 7b691be)

* perf: get total company stock only for purchase order

(cherry picked from commit eb3aae8)

* perf: skip insertion of stock ledger entry

(cherry picked from commit c7fc609)

* fix: undo changes to allow negative stock flag

(cherry picked from commit 7bafa11)

* fix: sider

(cherry picked from commit ac381d2)

* fix(Payment Entry): splitting outstanding rows as per payment terms (frappe#27946)

(cherry picked from commit d72709d)

* fix: TDS round off not working from second transaction

(cherry picked from commit ca00672)

* fix: TDS round off not working from second transaction

(cherry picked from commit b7a0853)

* fix: Update receivable/payable account on company change (backport frappe#28057)

* fix: changes in schedules gets overwritten on save

(cherry picked from commit af1b9e1)

* fix: Fetch thumbnail from Item master instead of regenerating

(cherry picked from commit 94177c0)

* fix: re-run patch

- Patch will just fetch thumbnails if website items are created, else it will create new website items

(cherry picked from commit 11c498d)

* fix: Get db values as dict when checking for thumbnail in existing web item

(cherry picked from commit 46a5a83)

* fix: Check if thumbnail column exists in case of table trimming

(cherry picked from commit ac8014e)

* fix: Move thumbnail updation to different patch

- Thumbnail updation handled via different patch
- create_website_items will only have one purpose
- added progress bar to `create_website_items`
- code cleanup

(cherry picked from commit 348a961)

* fix: Serial Nos not set in the row after scanning in popup

- Avoid whitspaces while calculating length of serial nos

(cherry picked from commit 734b57d)

* fix: don't reset rates in Timesheet Detail when Activity Type is cleared (backport frappe#28056)

* fix: show full item name in search widget (backport frappe#28283)

* fix: Avoid automatic customer creation on website user login

(cherry picked from commit d824a90)

# Conflicts:
#	erpnext/e_commerce/shopping_cart/utils.py

* fix: Sider, Linter

- Moved return to next line
- Space between function import and body

(cherry picked from commit a780f78)

* fix: Merge conflicts with e-commerce

* fix: POS Closing Entry without linked invoices (backport frappe#28042)

* fix: update production plan status (backport frappe#27567)

* refactor: shows opening balance from filtered from_date (backport frappe#26877)

* fix: Remove warehouse filter on Batch field for Material Receipt

(cherry picked from commit 048210a)

* chore: Add comment above fix for future reference

(cherry picked from commit 48886ee)

* fix: Autoemail report not showing dynamic report filters

(cherry picked from commit 3a6894f)

* Update employee_leave_balance.py

fix: Employee Leave Balance report showing wrong figures
(cherry picked from commit 632f784)

* fix: Make status filter in Fixed Asset Register optional (backport frappe#28126)

* fix: Skip empty rows while updating unsaved BOM cost (backport frappe#28136)

* v.13.14.1

* feat: employee initial work history updated when transfer is performed (backport frappe#27768)

Co-authored-by: Diksha Jadhav <dikshajadhav11.dj@gmail.com>
Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com>
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
Co-authored-by: Anuja Pawar <60467153+Anuja-pawar@users.noreply.github.com>
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
Co-authored-by: Noah Jacob <noahjacobkurian@gmail.com>
Co-authored-by: marination <maricadsouza221197@gmail.com>
Co-authored-by: Goh Yan Chang <yanchang.goh@itechstro.com>
github-actions bot pushed a commit to fproldan/erpnext that referenced this pull request Aug 8, 2022
* feat(manufacturing): add link field for  quality inspection template on operation

(cherry picked from commit 281a9cc)

* feat: provision to have limited parameters for in-process quality inspection

(cherry picked from commit 6c45f8b)

* refactor: use fetch from property for qi template on job card

(cherry picked from commit 467324c)

* perf: skip get_pricing_rules if no pricing rule exists

(cherry picked from commit a500252)

* perf: fetch mode of payments data in single query

(cherry picked from commit 7b691be)

* perf: get total company stock only for purchase order

(cherry picked from commit eb3aae8)

* perf: skip insertion of stock ledger entry

(cherry picked from commit c7fc609)

* fix: undo changes to allow negative stock flag

(cherry picked from commit 7bafa11)

* fix: sider

(cherry picked from commit ac381d2)

* fix(Payment Entry): splitting outstanding rows as per payment terms (frappe#27946)

(cherry picked from commit d72709d)

* fix: TDS round off not working from second transaction

(cherry picked from commit ca00672)

* fix: TDS round off not working from second transaction

(cherry picked from commit b7a0853)

* fix: Update receivable/payable account on company change (backport frappe#28057)

* fix: changes in schedules gets overwritten on save

(cherry picked from commit af1b9e1)

* fix: Fetch thumbnail from Item master instead of regenerating

(cherry picked from commit 94177c0)

* fix: re-run patch

- Patch will just fetch thumbnails if website items are created, else it will create new website items

(cherry picked from commit 11c498d)

* fix: Get db values as dict when checking for thumbnail in existing web item

(cherry picked from commit 46a5a83)

* fix: Check if thumbnail column exists in case of table trimming

(cherry picked from commit ac8014e)

* fix: Move thumbnail updation to different patch

- Thumbnail updation handled via different patch
- create_website_items will only have one purpose
- added progress bar to `create_website_items`
- code cleanup

(cherry picked from commit 348a961)

* fix: Serial Nos not set in the row after scanning in popup

- Avoid whitspaces while calculating length of serial nos

(cherry picked from commit 734b57d)

* fix: don't reset rates in Timesheet Detail when Activity Type is cleared (backport frappe#28056)

* fix: show full item name in search widget (backport frappe#28283)

* fix: Avoid automatic customer creation on website user login

(cherry picked from commit d824a90)

# Conflicts:
#	erpnext/e_commerce/shopping_cart/utils.py

* fix: Sider, Linter

- Moved return to next line
- Space between function import and body

(cherry picked from commit a780f78)

* fix: Merge conflicts with e-commerce

* fix: POS Closing Entry without linked invoices (backport frappe#28042)

* fix: update production plan status (backport frappe#27567)

* refactor: shows opening balance from filtered from_date (backport frappe#26877)

* fix: Remove warehouse filter on Batch field for Material Receipt

(cherry picked from commit 048210a)

* chore: Add comment above fix for future reference

(cherry picked from commit 48886ee)

* fix: Autoemail report not showing dynamic report filters

(cherry picked from commit 3a6894f)

* Update employee_leave_balance.py

fix: Employee Leave Balance report showing wrong figures
(cherry picked from commit 632f784)

* fix: Make status filter in Fixed Asset Register optional (backport frappe#28126)

* fix: Skip empty rows while updating unsaved BOM cost (backport frappe#28136)

* v.13.14.1

* feat: employee initial work history updated when transfer is performed (backport frappe#27768)

Co-authored-by: Diksha Jadhav <dikshajadhav11.dj@gmail.com>
Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com>
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
Co-authored-by: Anuja Pawar <60467153+Anuja-pawar@users.noreply.github.com>
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
Co-authored-by: Noah Jacob <noahjacobkurian@gmail.com>
Co-authored-by: marination <maricadsouza221197@gmail.com>
Co-authored-by: Goh Yan Chang <yanchang.goh@itechstro.com>
fproldan added a commit to fproldan/erpnext that referenced this pull request Aug 8, 2022
* feat(manufacturing): add link field for  quality inspection template on operation

(cherry picked from commit 281a9cc)

* feat: provision to have limited parameters for in-process quality inspection

(cherry picked from commit 6c45f8b)

* refactor: use fetch from property for qi template on job card

(cherry picked from commit 467324c)

* perf: skip get_pricing_rules if no pricing rule exists

(cherry picked from commit a500252)

* perf: fetch mode of payments data in single query

(cherry picked from commit 7b691be)

* perf: get total company stock only for purchase order

(cherry picked from commit eb3aae8)

* perf: skip insertion of stock ledger entry

(cherry picked from commit c7fc609)

* fix: undo changes to allow negative stock flag

(cherry picked from commit 7bafa11)

* fix: sider

(cherry picked from commit ac381d2)

* fix(Payment Entry): splitting outstanding rows as per payment terms (frappe#27946)

(cherry picked from commit d72709d)

* fix: TDS round off not working from second transaction

(cherry picked from commit ca00672)

* fix: TDS round off not working from second transaction

(cherry picked from commit b7a0853)

* fix: Update receivable/payable account on company change (backport frappe#28057)

* fix: changes in schedules gets overwritten on save

(cherry picked from commit af1b9e1)

* fix: Fetch thumbnail from Item master instead of regenerating

(cherry picked from commit 94177c0)

* fix: re-run patch

- Patch will just fetch thumbnails if website items are created, else it will create new website items

(cherry picked from commit 11c498d)

* fix: Get db values as dict when checking for thumbnail in existing web item

(cherry picked from commit 46a5a83)

* fix: Check if thumbnail column exists in case of table trimming

(cherry picked from commit ac8014e)

* fix: Move thumbnail updation to different patch

- Thumbnail updation handled via different patch
- create_website_items will only have one purpose
- added progress bar to `create_website_items`
- code cleanup

(cherry picked from commit 348a961)

* fix: Serial Nos not set in the row after scanning in popup

- Avoid whitspaces while calculating length of serial nos

(cherry picked from commit 734b57d)

* fix: don't reset rates in Timesheet Detail when Activity Type is cleared (backport frappe#28056)

* fix: show full item name in search widget (backport frappe#28283)

* fix: Avoid automatic customer creation on website user login

(cherry picked from commit d824a90)

* fix: Sider, Linter

- Moved return to next line
- Space between function import and body

(cherry picked from commit a780f78)

* fix: Merge conflicts with e-commerce

* fix: POS Closing Entry without linked invoices (backport frappe#28042)

* fix: update production plan status (backport frappe#27567)

* refactor: shows opening balance from filtered from_date (backport frappe#26877)

* fix: Remove warehouse filter on Batch field for Material Receipt

(cherry picked from commit 048210a)

* chore: Add comment above fix for future reference

(cherry picked from commit 48886ee)

* fix: Autoemail report not showing dynamic report filters

(cherry picked from commit 3a6894f)

* Update employee_leave_balance.py

fix: Employee Leave Balance report showing wrong figures
(cherry picked from commit 632f784)

* fix: Make status filter in Fixed Asset Register optional (backport frappe#28126)

* fix: Skip empty rows while updating unsaved BOM cost (backport frappe#28136)

* v.13.14.1

* feat: employee initial work history updated when transfer is performed (backport frappe#27768)

Co-authored-by: Diksha Jadhav <dikshajadhav11.dj@gmail.com>
Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com>
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
Co-authored-by: Anuja Pawar <60467153+Anuja-pawar@users.noreply.github.com>
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
Co-authored-by: Noah Jacob <noahjacobkurian@gmail.com>
Co-authored-by: marination <maricadsouza221197@gmail.com>
Co-authored-by: Goh Yan Chang <yanchang.goh@itechstro.com>
fproldan added a commit to fproldan/erpnext that referenced this pull request Aug 8, 2022
* feat(manufacturing): add link field for  quality inspection template on operation

(cherry picked from commit 281a9cc)

* feat: provision to have limited parameters for in-process quality inspection

(cherry picked from commit 6c45f8b)

* refactor: use fetch from property for qi template on job card

(cherry picked from commit 467324c)

* perf: skip get_pricing_rules if no pricing rule exists

(cherry picked from commit a500252)

* perf: fetch mode of payments data in single query

(cherry picked from commit 7b691be)

* perf: get total company stock only for purchase order

(cherry picked from commit eb3aae8)

* perf: skip insertion of stock ledger entry

(cherry picked from commit c7fc609)

* fix: undo changes to allow negative stock flag

(cherry picked from commit 7bafa11)

* fix: sider

(cherry picked from commit ac381d2)

* fix(Payment Entry): splitting outstanding rows as per payment terms (frappe#27946)

(cherry picked from commit d72709d)

* fix: TDS round off not working from second transaction

(cherry picked from commit ca00672)

* fix: TDS round off not working from second transaction

(cherry picked from commit b7a0853)

* fix: Update receivable/payable account on company change (backport frappe#28057)

* fix: changes in schedules gets overwritten on save

(cherry picked from commit af1b9e1)

* fix: Fetch thumbnail from Item master instead of regenerating

(cherry picked from commit 94177c0)

* fix: re-run patch

- Patch will just fetch thumbnails if website items are created, else it will create new website items

(cherry picked from commit 11c498d)

* fix: Get db values as dict when checking for thumbnail in existing web item

(cherry picked from commit 46a5a83)

* fix: Check if thumbnail column exists in case of table trimming

(cherry picked from commit ac8014e)

* fix: Move thumbnail updation to different patch

- Thumbnail updation handled via different patch
- create_website_items will only have one purpose
- added progress bar to `create_website_items`
- code cleanup

(cherry picked from commit 348a961)

* fix: Serial Nos not set in the row after scanning in popup

- Avoid whitspaces while calculating length of serial nos

(cherry picked from commit 734b57d)

* fix: don't reset rates in Timesheet Detail when Activity Type is cleared (backport frappe#28056)

* fix: show full item name in search widget (backport frappe#28283)

* fix: Avoid automatic customer creation on website user login

(cherry picked from commit d824a90)

* fix: Sider, Linter

- Moved return to next line
- Space between function import and body

(cherry picked from commit a780f78)

* fix: Merge conflicts with e-commerce

* fix: POS Closing Entry without linked invoices (backport frappe#28042)

* fix: update production plan status (backport frappe#27567)

* refactor: shows opening balance from filtered from_date (backport frappe#26877)

* fix: Remove warehouse filter on Batch field for Material Receipt

(cherry picked from commit 048210a)

* chore: Add comment above fix for future reference

(cherry picked from commit 48886ee)

* fix: Autoemail report not showing dynamic report filters

(cherry picked from commit 3a6894f)

* Update employee_leave_balance.py

fix: Employee Leave Balance report showing wrong figures
(cherry picked from commit 632f784)

* fix: Make status filter in Fixed Asset Register optional (backport frappe#28126)

* fix: Skip empty rows while updating unsaved BOM cost (backport frappe#28136)

* v.13.14.1

* feat: employee initial work history updated when transfer is performed (backport frappe#27768)

Co-authored-by: Diksha Jadhav <dikshajadhav11.dj@gmail.com>
Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com>
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
Co-authored-by: Anuja Pawar <60467153+Anuja-pawar@users.noreply.github.com>
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
Co-authored-by: Noah Jacob <noahjacobkurian@gmail.com>
Co-authored-by: marination <maricadsouza221197@gmail.com>
Co-authored-by: Goh Yan Chang <yanchang.goh@itechstro.com>
ValentinaPruvost pushed a commit to fproldan/erpnext that referenced this pull request Sep 7, 2022
* feat(manufacturing): add link field for  quality inspection template on operation

(cherry picked from commit 281a9cc)

* feat: provision to have limited parameters for in-process quality inspection

(cherry picked from commit 6c45f8b)

* refactor: use fetch from property for qi template on job card

(cherry picked from commit 467324c)

* perf: skip get_pricing_rules if no pricing rule exists

(cherry picked from commit a500252)

* perf: fetch mode of payments data in single query

(cherry picked from commit 7b691be)

* perf: get total company stock only for purchase order

(cherry picked from commit eb3aae8)

* perf: skip insertion of stock ledger entry

(cherry picked from commit c7fc609)

* fix: undo changes to allow negative stock flag

(cherry picked from commit 7bafa11)

* fix: sider

(cherry picked from commit ac381d2)

* fix(Payment Entry): splitting outstanding rows as per payment terms (frappe#27946)

(cherry picked from commit d72709d)

* fix: TDS round off not working from second transaction

(cherry picked from commit ca00672)

* fix: TDS round off not working from second transaction

(cherry picked from commit b7a0853)

* fix: Update receivable/payable account on company change (backport frappe#28057)

* fix: changes in schedules gets overwritten on save

(cherry picked from commit af1b9e1)

* fix: Fetch thumbnail from Item master instead of regenerating

(cherry picked from commit 94177c0)

* fix: re-run patch

- Patch will just fetch thumbnails if website items are created, else it will create new website items

(cherry picked from commit 11c498d)

* fix: Get db values as dict when checking for thumbnail in existing web item

(cherry picked from commit 46a5a83)

* fix: Check if thumbnail column exists in case of table trimming

(cherry picked from commit ac8014e)

* fix: Move thumbnail updation to different patch

- Thumbnail updation handled via different patch
- create_website_items will only have one purpose
- added progress bar to `create_website_items`
- code cleanup

(cherry picked from commit 348a961)

* fix: Serial Nos not set in the row after scanning in popup

- Avoid whitspaces while calculating length of serial nos

(cherry picked from commit 734b57d)

* fix: don't reset rates in Timesheet Detail when Activity Type is cleared (backport frappe#28056)

* fix: show full item name in search widget (backport frappe#28283)

* fix: Avoid automatic customer creation on website user login

(cherry picked from commit d824a90)

* fix: Sider, Linter

- Moved return to next line
- Space between function import and body

(cherry picked from commit a780f78)

* fix: Merge conflicts with e-commerce

* fix: POS Closing Entry without linked invoices (backport frappe#28042)

* fix: update production plan status (backport frappe#27567)

* refactor: shows opening balance from filtered from_date (backport frappe#26877)

* fix: Remove warehouse filter on Batch field for Material Receipt

(cherry picked from commit 048210a)

* chore: Add comment above fix for future reference

(cherry picked from commit 48886ee)

* fix: Autoemail report not showing dynamic report filters

(cherry picked from commit 3a6894f)

* Update employee_leave_balance.py

fix: Employee Leave Balance report showing wrong figures
(cherry picked from commit 632f784)

* fix: Make status filter in Fixed Asset Register optional (backport frappe#28126)

* fix: Skip empty rows while updating unsaved BOM cost (backport frappe#28136)

* v.13.14.1

* feat: employee initial work history updated when transfer is performed (backport frappe#27768)

Co-authored-by: Diksha Jadhav <dikshajadhav11.dj@gmail.com>
Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com>
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
Co-authored-by: Anuja Pawar <60467153+Anuja-pawar@users.noreply.github.com>
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
Co-authored-by: Noah Jacob <noahjacobkurian@gmail.com>
Co-authored-by: marination <maricadsouza221197@gmail.com>
Co-authored-by: Goh Yan Chang <yanchang.goh@itechstro.com>

Co-authored-by: Diksha Jadhav <dikshajadhav11.dj@gmail.com>
Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com>
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
Co-authored-by: Anuja Pawar <60467153+Anuja-pawar@users.noreply.github.com>
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
Co-authored-by: Noah Jacob <noahjacobkurian@gmail.com>
Co-authored-by: marination <maricadsouza221197@gmail.com>
Co-authored-by: Goh Yan Chang <yanchang.goh@itechstro.com>
ValentinaPruvost pushed a commit to fproldan/erpnext that referenced this pull request Sep 7, 2022
* feat(manufacturing): add link field for  quality inspection template on operation

(cherry picked from commit 281a9cc)

* feat: provision to have limited parameters for in-process quality inspection

(cherry picked from commit 6c45f8b)

* refactor: use fetch from property for qi template on job card

(cherry picked from commit 467324c)

* perf: skip get_pricing_rules if no pricing rule exists

(cherry picked from commit a500252)

* perf: fetch mode of payments data in single query

(cherry picked from commit 7b691be)

* perf: get total company stock only for purchase order

(cherry picked from commit eb3aae8)

* perf: skip insertion of stock ledger entry

(cherry picked from commit c7fc609)

* fix: undo changes to allow negative stock flag

(cherry picked from commit 7bafa11)

* fix: sider

(cherry picked from commit ac381d2)

* fix(Payment Entry): splitting outstanding rows as per payment terms (frappe#27946)

(cherry picked from commit d72709d)

* fix: TDS round off not working from second transaction

(cherry picked from commit ca00672)

* fix: TDS round off not working from second transaction

(cherry picked from commit b7a0853)

* fix: Update receivable/payable account on company change (backport frappe#28057)

* fix: changes in schedules gets overwritten on save

(cherry picked from commit af1b9e1)

* fix: Fetch thumbnail from Item master instead of regenerating

(cherry picked from commit 94177c0)

* fix: re-run patch

- Patch will just fetch thumbnails if website items are created, else it will create new website items

(cherry picked from commit 11c498d)

* fix: Get db values as dict when checking for thumbnail in existing web item

(cherry picked from commit 46a5a83)

* fix: Check if thumbnail column exists in case of table trimming

(cherry picked from commit ac8014e)

* fix: Move thumbnail updation to different patch

- Thumbnail updation handled via different patch
- create_website_items will only have one purpose
- added progress bar to `create_website_items`
- code cleanup

(cherry picked from commit 348a961)

* fix: Serial Nos not set in the row after scanning in popup

- Avoid whitspaces while calculating length of serial nos

(cherry picked from commit 734b57d)

* fix: don't reset rates in Timesheet Detail when Activity Type is cleared (backport frappe#28056)

* fix: show full item name in search widget (backport frappe#28283)

* fix: Avoid automatic customer creation on website user login

(cherry picked from commit d824a90)

# Conflicts:
#	erpnext/e_commerce/shopping_cart/utils.py

* fix: Sider, Linter

- Moved return to next line
- Space between function import and body

(cherry picked from commit a780f78)

* fix: Merge conflicts with e-commerce

* fix: POS Closing Entry without linked invoices (backport frappe#28042)

* fix: update production plan status (backport frappe#27567)

* refactor: shows opening balance from filtered from_date (backport frappe#26877)

* fix: Remove warehouse filter on Batch field for Material Receipt

(cherry picked from commit 048210a)

* chore: Add comment above fix for future reference

(cherry picked from commit 48886ee)

* fix: Autoemail report not showing dynamic report filters

(cherry picked from commit 3a6894f)

* Update employee_leave_balance.py

fix: Employee Leave Balance report showing wrong figures
(cherry picked from commit 632f784)

* fix: Make status filter in Fixed Asset Register optional (backport frappe#28126)

* fix: Skip empty rows while updating unsaved BOM cost (backport frappe#28136)

* v.13.14.1

* feat: employee initial work history updated when transfer is performed (backport frappe#27768)

Co-authored-by: Diksha Jadhav <dikshajadhav11.dj@gmail.com>
Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com>
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
Co-authored-by: Anuja Pawar <60467153+Anuja-pawar@users.noreply.github.com>
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
Co-authored-by: Noah Jacob <noahjacobkurian@gmail.com>
Co-authored-by: marination <maricadsouza221197@gmail.com>
Co-authored-by: Goh Yan Chang <yanchang.goh@itechstro.com>

Co-authored-by: Francisco Roldán <franciscoproldan@gmail.com>
Co-authored-by: Diksha Jadhav <dikshajadhav11.dj@gmail.com>
Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com>
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
Co-authored-by: Anuja Pawar <60467153+Anuja-pawar@users.noreply.github.com>
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
Co-authored-by: Noah Jacob <noahjacobkurian@gmail.com>
Co-authored-by: marination <maricadsouza221197@gmail.com>
Co-authored-by: Goh Yan Chang <yanchang.goh@itechstro.com>
ValentinaPruvost pushed a commit to fproldan/erpnext that referenced this pull request Sep 7, 2022
* feat(manufacturing): add link field for  quality inspection template on operation

(cherry picked from commit 281a9cc)

* feat: provision to have limited parameters for in-process quality inspection

(cherry picked from commit 6c45f8b)

* refactor: use fetch from property for qi template on job card

(cherry picked from commit 467324c)

* perf: skip get_pricing_rules if no pricing rule exists

(cherry picked from commit a500252)

* perf: fetch mode of payments data in single query

(cherry picked from commit 7b691be)

* perf: get total company stock only for purchase order

(cherry picked from commit eb3aae8)

* perf: skip insertion of stock ledger entry

(cherry picked from commit c7fc609)

* fix: undo changes to allow negative stock flag

(cherry picked from commit 7bafa11)

* fix: sider

(cherry picked from commit ac381d2)

* fix(Payment Entry): splitting outstanding rows as per payment terms (frappe#27946)

(cherry picked from commit d72709d)

* fix: TDS round off not working from second transaction

(cherry picked from commit ca00672)

* fix: TDS round off not working from second transaction

(cherry picked from commit b7a0853)

* fix: Update receivable/payable account on company change (backport frappe#28057)

* fix: changes in schedules gets overwritten on save

(cherry picked from commit af1b9e1)

* fix: Fetch thumbnail from Item master instead of regenerating

(cherry picked from commit 94177c0)

* fix: re-run patch

- Patch will just fetch thumbnails if website items are created, else it will create new website items

(cherry picked from commit 11c498d)

* fix: Get db values as dict when checking for thumbnail in existing web item

(cherry picked from commit 46a5a83)

* fix: Check if thumbnail column exists in case of table trimming

(cherry picked from commit ac8014e)

* fix: Move thumbnail updation to different patch

- Thumbnail updation handled via different patch
- create_website_items will only have one purpose
- added progress bar to `create_website_items`
- code cleanup

(cherry picked from commit 348a961)

* fix: Serial Nos not set in the row after scanning in popup

- Avoid whitspaces while calculating length of serial nos

(cherry picked from commit 734b57d)

* fix: don't reset rates in Timesheet Detail when Activity Type is cleared (backport frappe#28056)

* fix: show full item name in search widget (backport frappe#28283)

* fix: Avoid automatic customer creation on website user login

(cherry picked from commit d824a90)

* fix: Sider, Linter

- Moved return to next line
- Space between function import and body

(cherry picked from commit a780f78)

* fix: Merge conflicts with e-commerce

* fix: POS Closing Entry without linked invoices (backport frappe#28042)

* fix: update production plan status (backport frappe#27567)

* refactor: shows opening balance from filtered from_date (backport frappe#26877)

* fix: Remove warehouse filter on Batch field for Material Receipt

(cherry picked from commit 048210a)

* chore: Add comment above fix for future reference

(cherry picked from commit 48886ee)

* fix: Autoemail report not showing dynamic report filters

(cherry picked from commit 3a6894f)

* Update employee_leave_balance.py

fix: Employee Leave Balance report showing wrong figures
(cherry picked from commit 632f784)

* fix: Make status filter in Fixed Asset Register optional (backport frappe#28126)

* fix: Skip empty rows while updating unsaved BOM cost (backport frappe#28136)

* v.13.14.1

* feat: employee initial work history updated when transfer is performed (backport frappe#27768)

Co-authored-by: Diksha Jadhav <dikshajadhav11.dj@gmail.com>
Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com>
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
Co-authored-by: Anuja Pawar <60467153+Anuja-pawar@users.noreply.github.com>
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
Co-authored-by: Noah Jacob <noahjacobkurian@gmail.com>
Co-authored-by: marination <maricadsouza221197@gmail.com>
Co-authored-by: Goh Yan Chang <yanchang.goh@itechstro.com>

Co-authored-by: Diksha Jadhav <dikshajadhav11.dj@gmail.com>
Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com>
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
Co-authored-by: Anuja Pawar <60467153+Anuja-pawar@users.noreply.github.com>
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
Co-authored-by: Noah Jacob <noahjacobkurian@gmail.com>
Co-authored-by: marination <maricadsouza221197@gmail.com>
Co-authored-by: Goh Yan Chang <yanchang.goh@itechstro.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant