-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Respect system precision for user facing balance qty values #30837
Conversation
- `get_precision` -> `set_precision` - Use system wide currency precision for `stock_value` - Round of qty defiiciency as per user defined precision (system flt precision), so that it is WYSIWYG for users
Codecov Report
@@ Coverage Diff @@
## develop #30837 +/- ##
===========================================
+ Coverage 63.06% 63.63% +0.56%
===========================================
Files 984 984
Lines 67556 67570 +14
===========================================
+ Hits 42604 42996 +392
+ Misses 24952 24574 -378
|
This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
The test is getting a bit hard. Values set are not honouring system precision, will take a look at EOW |
This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
- Test for Immediate Negative Qty precision - Stock Entry Negative Qty message: Format available qty in system precision - Pass `stock_uom` as confugrable option in `make_item`
- `get_field_precision` defaults to number format for precision (maintain old behaviour) - Don't pass `currency` to `get_field_precision` as its not used anymore
) * fix: Respect system precision for user facing balance qty values - `get_precision` -> `set_precision` - Use system wide currency precision for `stock_value` - Round of qty defiiciency as per user defined precision (system flt precision), so that it is WYSIWYG for users * fix: Consider system precision when validating future negative qty * test: Immediate Negative Qty precision test - Test for Immediate Negative Qty precision - Stock Entry Negative Qty message: Format available qty in system precision - Pass `stock_uom` as confugrable option in `make_item` * test: Future Negative Qty validation with precision * fix: Use `get_field_precision` for currency precision as it used to - `get_field_precision` defaults to number format for precision (maintain old behaviour) - Don't pass `currency` to `get_field_precision` as its not used anymore (cherry picked from commit d6078aa) # Conflicts: # erpnext/stock/doctype/stock_ledger_entry/test_stock_ledger_entry.py
…-30837 fix: Respect system precision for user facing balance qty values (backport #30837)
## [13.34.2](v13.34.1...v13.34.2) (2022-06-28) ### Bug Fixes * add UOM validation for planned-qty ([559bde3](559bde3)) * dont update RM items table if not required (backport [#31408](#31408)) ([#31457](#31457)) ([8155306](8155306)) * General Ledger and TB opening entries mismatch issues ([a0c5c73](a0c5c73)) * Monthly depreciation using WDV method ([e7659a1](e7659a1)) * Quotation and Sales Order item sync ([2219132](2219132)) * Respect system precision for user facing balance qty values ([#30837](#30837)) ([642b9c5](642b9c5)) * **Salary Slip:** Components not updated when amount evaluates to 0 due to payment days ([#31425](#31425)) ([abfe926](abfe926)) * translation for filter status on report ([736f206](736f206)) * update ru translate (backport [#31404](#31404)) ([#31417](#31417)) ([8b78a12](8b78a12))
Issue:
Consider the following ledger:
Solution:
To the reviewer:
Todo: