fix(Salary Slip): Components not updated when amount evaluates to 0 due to payment days #31425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ue to payment days
|
This will add 0 valued components to the table though 🤔 (which doesn't happen right now). Need to handle that. |
ruchamahabal
added
the
backport develop
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jun 28, 2022
## [13.34.2](v13.34.1...v13.34.2) (2022-06-28) ### Bug Fixes * add UOM validation for planned-qty ([559bde3](559bde3)) * dont update RM items table if not required (backport [#31408](#31408)) ([#31457](#31457)) ([8155306](8155306)) * General Ledger and TB opening entries mismatch issues ([a0c5c73](a0c5c73)) * Monthly depreciation using WDV method ([e7659a1](e7659a1)) * Quotation and Sales Order item sync ([2219132](2219132)) * Respect system precision for user facing balance qty values ([#30837](#30837)) ([642b9c5](642b9c5)) * **Salary Slip:** Components not updated when amount evaluates to 0 due to payment days ([#31425](#31425)) ([abfe926](abfe926)) * translation for filter status on report ([736f206](736f206)) * update ru translate (backport [#31404](#31404)) ([#31417](#31417)) ([8b78a12](8b78a12))
|
🎉 This PR is included in version 13.34.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This was referenced Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to Replicate:
Salary component Professional Tax is dependent on Gross Pay and Bonus and these components are dependent on payment days:
If the Payment Days are altered after saving by updating "Leave Without Pay", the gross changes to 12000 from 15000 and the professional tax should be 0 as per the formula. But this amount isn't updated because it fails the check made before calling
update_componentFix:
Explicitly check whether the
amount is not Noneso that 0 valued components get updated after payment days are altered: