-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Use frappe.as_unicode
to decode output of redis module list
#31282
Merged
ankush
merged 1 commit into
frappe:develop
from
marination:redisearch-loaded-maintenance
Jun 8, 2022
Merged
fix: Use frappe.as_unicode
to decode output of redis module list
#31282
ankush
merged 1 commit into
frappe:develop
from
marination:redisearch-loaded-maintenance
Jun 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- As of redis 7, a list is added to the result of fetching the module list - This list cannot be "decoded",so use `frappe.as_unicode` that handles bytes as well as other types
Codecov Report
@@ Coverage Diff @@
## develop #31282 +/- ##
===========================================
+ Coverage 63.48% 63.56% +0.08%
===========================================
Files 986 986
Lines 67457 67457
===========================================
+ Hits 42827 42882 +55
+ Misses 24630 24575 -55
|
ankush
approved these changes
Jun 8, 2022
frappe.as_unicode
to decode output of redis module listfrappe.as_unicode
to decode output of redis module list
ankush
pushed a commit
that referenced
this pull request
Jun 8, 2022
…ackport #31282) (#31283) fix: Use `frappe.as_unicode` to decode output of redis module list (#31282) - As of redis 7, a list is added to the result of fetching the module list - This list cannot be "decoded",so use `frappe.as_unicode` that handles bytes as well as other types (cherry picked from commit 2832731) Co-authored-by: Marica <maricadsouza221197@gmail.com>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jun 14, 2022
# [13.34.0](v13.33.0...v13.34.0) (2022-06-14) ### Bug Fixes * (auto-merge) Use `frappe.log_error` instead of `doc.log_error` ([bced6a0](bced6a0)) * `test_work_order_with_non_stock_item` ([b827c3b](b827c3b)) * Add cost center in loan document ([c19dfbe](c19dfbe)) * **asset:** failing test case ([#31277](#31277)) ([8a4c9d1](8a4c9d1)) * Auto Insert Item Price If Missing when discount & blank UOM (backport [#31168](#31168)) ([#31267](#31267)) ([e69bff0](e69bff0)) * Call `calculate_cost` for Draft BOM and typo in argument ([d035aa2](d035aa2)) * Company address filter in quotation ([d375939](d375939)) * DB update child items, remove redundancy, fix perf ([cbc52a2](cbc52a2)) * Depreciate Asset before generating GL Entries on sale ([#30759](#30759)) ([dfbfe40](dfbfe40)) * Get fresh RM rate in `calculate_rm_cost` ([9a513fd](9a513fd)) * **India:** Incorrect taxable in GSTR-3B report ([e5d2c59](e5d2c59)) * **India:** Sales taxes and charges template fetching in quotation ([a1ba847](a1ba847)) * locale Currency and Float setting in update_employee ([391ed9c](391ed9c)) * misaligned columns in print format of AR/AP report ([81e32e2](81e32e2)) * Partially Ordered status for quotation ([37ba550](37ba550)) * purchase invoice standalone return GLEs (backport [#31209](#31209)) ([#31263](#31263)) ([6d99b5a](6d99b5a)) * Reset represents company on disabling internal customer and supplier (backport [#31302](#31302)) ([#31306](#31306)) ([fb9b302](fb9b302)) * Safe cast `row.rate` (in case of faulty exploded items, edge case but oh well) ([6d65e2b](6d65e2b)) * Supplied Qty not updated on Stock Entry cancel ([79b2062](79b2062)) * Trial Balance failing to ignore Finance Book ([00371f4](00371f4)) * typo in sql condition ([894f945](894f945)) * update fr translation (backport [#31232](#31232)) ([#31334](#31334)) ([5d0f271](5d0f271)) * update Period Closing Voucher per Company ([5ebbe81](5ebbe81)) * update ru translate (backport [#31200](#31200)) ([#31304](#31304)) ([77e4755](77e4755)) * Use `frappe.as_unicode` to decode output of redis module list (backport [#31282](#31282)) ([#31283](#31283)) ([633a452](633a452)) * **ux:** hide new version btn on unsaved BOM (backport [#31297](#31297)) ([#31298](#31298)) ([9f6b32a](9f6b32a)) * **UX:** use doc.status for Job Card status ([#31320](#31320)) ([78473b8](78473b8)) ### Features * Add german translations ([a3f2cf3](a3f2cf3)) * Level-wise BOM cost updation ([74d7d81](74d7d81)) * Only update exploded items rate and amount ([a26da58](a26da58)) * Track progress in Log Batch/Job wise ([3b2a8bf](3b2a8bf)) ### Performance Improvements * `get_boms_in_bottom_up_order` ([87c2b3b](87c2b3b)) * `get_next_higher_level_boms` ([767a775](767a775)) * Use cached doc instead of `get_doc` ([faa69c9](faa69c9))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
element.decode()
Fix:
frappe.as_unicode
that handles bytes as well as other types