Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Salary Slip): Components not updated when amount evaluates to 0 due to payment days (backport #31425) #31432

Merged
merged 3 commits into from
Jul 1, 2022

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 23, 2022

This is an automatic backport of pull request #31425 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

…ue to payment days (#31425)

* fix(Salary Slip): Components not updated when amount evaluates to 0 due to payment days

* fix: remove 0 valued components that have been updated later

(cherry picked from commit abfe926)
@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jun 23, 2022
@ruchamahabal ruchamahabal removed the needs-tests This PR needs automated unit-tests. label Jun 23, 2022
@ruchamahabal
Copy link
Member

Unrelated test failure: test_backflushed_batch_raw_materials_based_on_transferred

@ruchamahabal ruchamahabal merged commit 7b093e5 into develop Jul 1, 2022
@ruchamahabal ruchamahabal deleted the mergify/bp/develop/pr-31425 branch July 1, 2022 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant