fix: Incorrect exchange rate in payment entries #33481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepeshgarg007
requested review from
nextchamp-saqib and
ruthra-kumar
as code owners
…ent_entry_exchange_rates
deepeshgarg007
requested review from
rohitwaghchaure and
s-aga-r
as code owners
…ent_entry_exchange_rates
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #33481 +/- ##
========================================
Coverage 64.18% 64.18%
========================================
Files 819 819
Lines 59040 59040
========================================
Hits 37893 37893
Misses 21147 21147
|
deepeshgarg007
added
backport version-14-hotfix
mergify bot
pushed a commit
that referenced
this pull request
Jan 10, 2023
* fix: Incorrect exchange rate in payment entries * test: Update failing tests (cherry picked from commit 0ed938a)
mergify bot
pushed a commit
that referenced
this pull request
Jan 10, 2023
* fix: Incorrect exchange rate in payment entries * test: Update failing tests (cherry picked from commit 0ed938a) # Conflicts: # erpnext/buying/doctype/purchase_order/test_purchase_order.py
deepeshgarg007
added a commit
that referenced
this pull request
Jan 10, 2023
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jan 10, 2023
## [14.12.1](v14.12.0...v14.12.1) (2023-01-10) ### Bug Fixes * **accounts:** currency fields no longer read as strings by validation function in Payment Entry ([#33535](#33535)) ([44a95da](44a95da)) * better handling of duplicate bundle items ([b96a97f](b96a97f)) * customer/supplier quick entry dialog ([#33496](#33496)) ([914e2fd](914e2fd)) * don't check other warehouse ledgers to calculate valuation rate ([ab0a2b4](ab0a2b4)) * Exchange gain and loss booking on multi-currency invoice reconciliation ([#32900](#32900)) ([fe82ebc](fe82ebc)) * Exchange gain and loss booking on multi-currency invoice reconciliation ([#32900](#32900)) ([259639a](259639a)) * Incorrect exchange rate in payment entries ([#33481](#33481)) ([e995e95](e995e95)) * incorrect status in the work order ([2658fc9](2658fc9)) * incorrect warehouse and selling amount on bundled products ([#33549](#33549)) ([c6c3ac3](c6c3ac3)) * RFQ emails not sent with pdf attachment ([#33604](#33604)) ([34df9ab](34df9ab)) * **stock entry:** wrong valuation rate in repack ([#33579](#33579)) ([a92b4e7](a92b4e7)) * Timeout error while saving the purchase invoice ([#33577](#33577)) ([d2e3701](d2e3701)) ### Performance Improvements * Drop `name` part from posting sort index ([#33551](#33551)) ([f501575](f501575))
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
source_exchange_rateas some arbitrary value using browser console or UI.The
target_exchange_ratealso gets updated to the same value even though both thepaid_from_account_currencyandpaid_to_account_currencyare same as Company currency (Non multi currency transactions)The server side updation was not getting triggered because of the following check hence removed it.