Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: customer/supplier quick entry dialog #33496

Merged
merged 2 commits into from
Jan 9, 2023

Conversation

dj12djdjs
Copy link
Collaborator

@dj12djdjs dj12djdjs commented Dec 31, 2022

closes: #33472
closes: #33361
closes: #32786

TODO:

  • Customer Quick Entry
  • Supplier Quick Entry
  • Maybe refactor into one class as Supplier an Customer custom quick entry form is the same.

@dj12djdjs dj12djdjs marked this pull request as ready for review December 31, 2022 22:29
@dj12djdjs
Copy link
Collaborator Author

To add tests, do they have to be added here? https://github.com/erpnext/erpnext_ui_tests

@deepeshgarg007 deepeshgarg007 merged commit 6bc8bb2 into frappe:develop Jan 9, 2023
mergify bot pushed a commit that referenced this pull request Jan 9, 2023
* fix: readonly primary contact fields.

* refactor: supplier and customer quick entry form into common class.

(cherry picked from commit 6bc8bb2)
mergify bot pushed a commit that referenced this pull request Jan 9, 2023
* fix: readonly primary contact fields.

* refactor: supplier and customer quick entry form into common class.

(cherry picked from commit 6bc8bb2)

# Conflicts:
#	erpnext/public/js/erpnext.bundle.js
#	erpnext/public/js/utils/customer_quick_entry.js
deepeshgarg007 pushed a commit that referenced this pull request Jan 10, 2023
fix: customer/supplier quick entry dialog (#33496)

* fix: readonly primary contact fields.

* refactor: supplier and customer quick entry form into common class.

(cherry picked from commit 6bc8bb2)

Co-authored-by: Devin Slauenwhite <devin.slauenwhite@gmail.com>
frappe-pr-bot pushed a commit that referenced this pull request Jan 10, 2023
## [14.12.1](v14.12.0...v14.12.1) (2023-01-10)

### Bug Fixes

* **accounts:** currency fields no longer read as strings by validation function in Payment Entry ([#33535](#33535)) ([44a95da](44a95da))
* better handling of duplicate bundle items ([b96a97f](b96a97f))
* customer/supplier quick entry dialog ([#33496](#33496)) ([914e2fd](914e2fd))
* don't check other warehouse ledgers to calculate valuation rate ([ab0a2b4](ab0a2b4))
* Exchange gain and loss booking on multi-currency invoice reconciliation ([#32900](#32900)) ([fe82ebc](fe82ebc))
* Exchange gain and loss booking on multi-currency invoice reconciliation ([#32900](#32900)) ([259639a](259639a))
* Incorrect exchange rate in payment entries ([#33481](#33481)) ([e995e95](e995e95))
* incorrect status in the work order ([2658fc9](2658fc9))
* incorrect warehouse and selling amount on bundled products ([#33549](#33549)) ([c6c3ac3](c6c3ac3))
* RFQ emails not sent with pdf attachment ([#33604](#33604)) ([34df9ab](34df9ab))
* **stock entry:** wrong valuation rate in repack ([#33579](#33579)) ([a92b4e7](a92b4e7))
* Timeout error while saving the purchase invoice ([#33577](#33577)) ([d2e3701](d2e3701))

### Performance Improvements

* Drop `name` part from posting sort index ([#33551](#33551)) ([f501575](f501575))
@barredterra barredterra mentioned this pull request Mar 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.