perf: index in Item and Item Variant Attribute
#36133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-aga-r
added
backport version-13-hotfix
backport version-14-hotfix
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #36133 +/- ##
===========================================
- Coverage 64.26% 64.21% -0.06%
===========================================
Files 785 785
Lines 60700 60681 -19
===========================================
- Hits 39008 38965 -43
- Misses 21692 21716 +24
|
This was referenced Jul 15, 2023
s-aga-r
added a commit
that referenced
this pull request
Jul 15, 2023
…36145) * perf: index `variant_of` and `attribute` in `Item Variant Attribute` (cherry picked from commit e4128a5) * perf: index `disabled` in `Item` (cherry picked from commit 04400eb) # Conflicts: # erpnext/stock/doctype/item/item.json * chore: `conflicts` --------- Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jul 18, 2023
## [13.52.6](v13.52.5...v13.52.6) (2023-07-18) ### Bug Fixes * allow manual asset receipt mov from nowhere (backport [#36093](#36093)) ([#36095](#36095)) ([2993eb5](2993eb5)) * HSN code not showing up in GST itemised register reports ([#36142](#36142)) ([1d3917b](1d3917b)) * improve "Update Items" modal ([#36105](#36105)) ([3bc899f](3bc899f)) ### Performance Improvements * index in `Item` and `Item Variant Attribute` (backport [#36133](#36133)) ([#36145](#36145)) ([120de24](120de24))
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jul 18, 2023
# [14.31.0](v14.30.7...v14.31.0) (2023-07-18) ### Bug Fixes * `TypeError` while creating WO from PP (backport [#36136](#36136)) ([#36137](#36137)) ([dd51010](dd51010)) * Account balance patch and query fixes ([#36117](#36117)) ([0147754](0147754)) * Accounts closing balance patch ([#36113](#36113)) ([cf29156](cf29156)) * allow manual asset receipt mov from nowhere ([#36093](#36093)) ([4aaa1a1](4aaa1a1)) * Ambiguous column error while submitting stock entry ([#36058](#36058)) ([a3a052b](a3a052b)) * circular dependency during reposting causing timeout error ([2c21404](2c21404)) * get_dimension with_cost_center_and_project=false is not working ([#35974](#35974)) ([42c93a1](42c93a1)) * Handle multi-company in patch ([#36127](#36127)) ([e7f5754](e7f5754)) * improve "Update Items" modal ([#36105](#36105)) ([b86571d](b86571d)) * incorrect Balance Qty in the stock ledger for the item with Serial and Batch no ([373b868](373b868)) * incorrect Reserved Qty for Production Plan in BIN for multi-uom case ([2f632d0](2f632d0)) * Opening balance in TB report ([#36171](#36171)) ([313ad7a](313ad7a)) * Opening entries showing up incorrectly in TB report ([#36135](#36135)) ([d10e5e6](d10e5e6)) * Remove current fiscal year from Global Defaults ([#35960](#35960)) ([b877fa6](b877fa6)) * Trailing opening entries in Accounts closing balance ([#36175](#36175)) ([8a607db](8a607db)) * validate docs in closed accounting period on save ([#36157](#36157)) ([5985e02](5985e02)) ### Features * add local holidays ([#36116](#36116)) ([94caf7f](94caf7f)) * add project filter in reports importing financial statements js file ([#36097](#36097)) ([63e26e3](63e26e3)) ### Performance Improvements * index in `Item` and `Item Variant Attribute` (backport [#36133](#36133)) ([#36144](#36144)) ([6198983](6198983)) * send SLA doctypes in boot ([adb6918](adb6918))
|
Would you also share anonymized contents of the ISS-23-24-02011 as part of the description? |
The ISS-23-24-02011 is for our reference. I don't think this PR needs any description (?) It's just a simple change to enable Index for some columns used in a query. If you're asking about performance improvements that will be negligible for most of the users as this user has ~1 Cr Item Variant Attributes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Source / Ref: ISS-23-24-02011
Add Index for columns used in this query.