Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve "Update Items" modal #36105

Merged
merged 2 commits into from
Jul 14, 2023
Merged

fix: improve "Update Items" modal #36105

merged 2 commits into from
Jul 14, 2023

Conversation

barredterra
Copy link
Collaborator

@barredterra barredterra commented Jul 12, 2023 •
edited
Loading

Before

  • The modal was quite small, hard to make sense of long item names and many items
  • Item list showed a column Conversion Factor, which seemed pretty random. This would only make sense with two different UOMs next to it.

Bildschirmfoto 2023-07-12 um 13 22 42

After

  • Increased the size of the modal to look less crammed
  • Removed the column Conversion Factor from the overview. (It stays available in the detail view.)

Bildschirmfoto 2023-07-12 um 13 30 58

@barredterra
fix: make "Update Items" modal larger
246270a
@barredterra
fix: remove conversion factor from overview
20536f8 
Conversion factor doesn't make much sense without two different UOMs
next to it, hence moving it to row detail view
@barredterra barredterra changed the title update items modal fix: improve "Update Items" modal Jul 12, 2023
@deepeshgarg007 deepeshgarg007 merged commit d5fe143 into frappe:develop Jul 14, 2023
9 checks passed
mergify bot pushed a commit that referenced this pull request Jul 14, 2023
@barredterra @mergify
fix: improve "Update Items" modal (#36105)
1379c1e 
* fix: make "Update Items" modal larger

* fix: remove conversion factor from overview

Conversion factor doesn't make much sense without two different UOMs
next to it, hence moving it to row detail view

(cherry picked from commit d5fe143)
@mergify mergify bot mentioned this pull request Jul 14, 2023
Merged
mergify bot pushed a commit that referenced this pull request Jul 14, 2023
@barredterra @mergify
fix: improve "Update Items" modal (#36105)
54a20c9 
* fix: make "Update Items" modal larger

* fix: remove conversion factor from overview

Conversion factor doesn't make much sense without two different UOMs
next to it, hence moving it to row detail view

(cherry picked from commit d5fe143)
@mergify mergify bot mentioned this pull request Jul 14, 2023
Merged
@barredterra barredterra deleted the update-items-modal branch July 14, 2023 07:29
deepeshgarg007 pushed a commit that referenced this pull request Jul 14, 2023
@mergify @barredterra
fix: improve "Update Items" modal (#36105)
b86571d 
fix: improve "Update Items" modal (#36105)

* fix: make "Update Items" modal larger

* fix: remove conversion factor from overview

Conversion factor doesn't make much sense without two different UOMs
next to it, hence moving it to row detail view

(cherry picked from commit d5fe143)

Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
deepeshgarg007 pushed a commit that referenced this pull request Jul 14, 2023
@mergify @barredterra
fix: improve "Update Items" modal (#36105)
3bc899f 
fix: improve "Update Items" modal (#36105)

* fix: make "Update Items" modal larger

* fix: remove conversion factor from overview

Conversion factor doesn't make much sense without two different UOMs
next to it, hence moving it to row detail view

(cherry picked from commit d5fe143)

Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
frappe-pr-bot pushed a commit that referenced this pull request Jul 18, 2023
@frappe-bot
chore(release): Bumped to Version 13.52.6
128ea0d 
## [13.52.6](v13.52.5...v13.52.6) (2023-07-18)

### Bug Fixes

* allow manual asset receipt mov from nowhere (backport [#36093](#36093)) ([#36095](#36095)) ([2993eb5](2993eb5))
* HSN code not showing up in GST itemised register reports ([#36142](#36142)) ([1d3917b](1d3917b))
* improve "Update Items" modal ([#36105](#36105)) ([3bc899f](3bc899f))

### Performance Improvements

* index in `Item` and `Item Variant Attribute` (backport [#36133](#36133)) ([#36145](#36145)) ([120de24](120de24))
frappe-pr-bot pushed a commit that referenced this pull request Jul 18, 2023
@frappe-bot
chore(release): Bumped to Version 14.31.0
22a19e4 
# [14.31.0](v14.30.7...v14.31.0) (2023-07-18)

### Bug Fixes

* `TypeError` while creating WO from PP (backport [#36136](#36136)) ([#36137](#36137)) ([dd51010](dd51010))
* Account balance patch and query fixes ([#36117](#36117)) ([0147754](0147754))
* Accounts closing balance patch ([#36113](#36113)) ([cf29156](cf29156))
* allow manual asset receipt mov from nowhere ([#36093](#36093)) ([4aaa1a1](4aaa1a1))
* Ambiguous column error while submitting stock entry ([#36058](#36058)) ([a3a052b](a3a052b))
* circular dependency during reposting causing timeout error ([2c21404](2c21404))
* get_dimension with_cost_center_and_project=false is not working ([#35974](#35974)) ([42c93a1](42c93a1))
* Handle multi-company in patch ([#36127](#36127)) ([e7f5754](e7f5754))
* improve "Update Items" modal ([#36105](#36105)) ([b86571d](b86571d))
* incorrect Balance Qty in the stock ledger for the item with Serial and Batch no ([373b868](373b868))
* incorrect Reserved Qty for Production Plan in BIN for multi-uom case ([2f632d0](2f632d0))
* Opening balance in TB report ([#36171](#36171)) ([313ad7a](313ad7a))
* Opening entries showing up incorrectly in TB report ([#36135](#36135)) ([d10e5e6](d10e5e6))
* Remove current fiscal year from Global Defaults ([#35960](#35960)) ([b877fa6](b877fa6))
* Trailing opening entries in Accounts closing balance ([#36175](#36175)) ([8a607db](8a607db))
* validate docs in closed accounting period on save ([#36157](#36157)) ([5985e02](5985e02))

### Features

* add local holidays ([#36116](#36116)) ([94caf7f](94caf7f))
* add project filter in reports importing financial statements js file ([#36097](#36097)) ([63e26e3](63e26e3))

### Performance Improvements

* index in `Item` and `Item Variant Attribute` (backport [#36133](#36133)) ([#36144](#36144)) ([6198983](6198983))
* send SLA doctypes in boot ([adb6918](adb6918))
@ankush ankush mentioned this pull request Oct 20, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
backport version-13-hotfix backport version-14-hotfix backport to version 14
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@barredterra @deepeshgarg007