Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incorrect available qty for backdated stock reco with batch #36581

Merged
merged 1 commit into from
Aug 10, 2023
Merged

fix: incorrect available qty for backdated stock reco with batch #36581

merged 1 commit into from
Aug 10, 2023

Conversation

rohitwaghchaure
Copy link
Collaborator

@rohitwaghchaure rohitwaghchaure commented Aug 10, 2023 •
edited
Loading

  1. Create backdated Purchase Receipt for the batched item with 100 qty.
  2. Create delivery note on the current date with 100 qty and same batch.
  3. Create backdated Stock Reconciliation entry after the Purchase Receipt entry date and change the qty from 100 to 200
  4. Create Two Backdated Stock Reconciliations before the above stock reco and after the Purchase Receipt date for the same item with different valuation rate.
  5. You will notice that the Backdated Stock Reconciliations causing the incorrect available qty
Screenshot 2023-08-10 at 4 11 48 PM

@github-actions github-actions bot added the stock label Aug 10, 2023
@rohitwaghchaure rohitwaghchaure merged commit 2800ad3 into frappe:version-14-hotfix Aug 10, 2023
15 checks passed
@rohitwaghchaure
Copy link
Collaborator Author

@Mergifyio backport version-14

@mergify
Copy link
Contributor

mergify bot commented Aug 10, 2023 •
edited
Loading

backport version-14

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 10, 2023
@rohitwaghchaure @mergify
fix: incorrect available qty for backdated stock reco with batch (#36581
efdb93c 
)

(cherry picked from commit 2800ad3)
@mergify mergify bot mentioned this pull request Aug 10, 2023
Merged
rohitwaghchaure added a commit that referenced this pull request Aug 10, 2023
@mergify @rohitwaghchaure
fix: incorrect available qty for backdated stock reco with batch (bac…
bb112ec 
…kport #36581) (#36585)

fix: incorrect available qty for backdated stock reco with batch (#36581)

(cherry picked from commit 2800ad3)

Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com>
frappe-pr-bot pushed a commit that referenced this pull request Aug 10, 2023
@frappe-bot
chore(release): Bumped to Version 14.34.2
35450d7 
## [14.34.2](v14.34.1...v14.34.2) (2023-08-10)

### Bug Fixes

* incorrect available qty for backdated stock reco with batch (backport [#36581](#36581)) ([#36585](#36585)) ([bb112ec](bb112ec))
frappe-pr-bot pushed a commit that referenced this pull request Aug 16, 2023
@frappe-bot
chore(release): Bumped to Version 14.35.0
b773465 
# [14.35.0](v14.34.3...v14.35.0) (2023-08-16)

### Bug Fixes

* Allow backdated repayment cancels for term loans ([1377cf4](1377cf4))
* allow negative stock condition for batch item ([#36586](#36586)) ([ee04c6d](ee04c6d))
* AR/AP report based on payment terms ([#36574](#36574)) ([ac0fff7](ac0fff7))
* better remarks on Cr note created by Reconciliation ([5443592](5443592))
* Button Alignment center in hero slider ([#36607](#36607)) ([b131f70](b131f70)), closes [#36561](#36561)
* cr/dr note should be posted for exc gain/loss ([349601b](349601b))
* disallow mulitple SO with same PO No ([b901cfd](b901cfd))
* don't show disabled items in `Item Shortage Report` (backport [#36550](#36550)) ([#36571](#36571)) ([19cfcea](19cfcea))
* fetch `Stock UOM` from Item if not set (backport [#36606](#36606)) ([#36617](#36617)) ([8b13185](8b13185))
* Group Account total not showing in Financial Statements ([2912648](2912648))
* incorrect available qty for backdated stock reco with batch ([#36581](#36581)) ([2800ad3](2800ad3))
* incorrect gain/loss on allocation change on reconciliation tool ([39c439d](39c439d))
* Make default sales update frequency as monthly instead of each transaction ([4ca1f3b](4ca1f3b))
* move company rename to long queue ([8083c0b](8083c0b))
* precision issue while submitting the stock entry ([#36575](#36575)) ([a864e07](a864e07))
* re-add permission that was unintentionally removed ([#36663](#36663)) ([99777d3](99777d3))
* **RFQ:** link to supplier portal ([eb2f68e](eb2f68e))
* standard formula to calculate the "difference" ([#36612](#36612)) ([716d5c0](716d5c0))
* Tax withholding post LDC limit consumed ([#36611](#36611)) ([1deebe8](1deebe8))
* **test:** replace hardcoded reference to adv with dynamic one ([2e6bfa3](2e6bfa3))
* **test:** test case breakage in Github Actions ([3542df7](3542df7))
* unhide `uom` and `stock_uom` fields in print view ([b49309c](b49309c))
* validation blocks partial payment for SO and PO ([ce08f03](ce08f03))
* wrap none type rate under flt (backport [#36602](#36602)) ([#36604](#36604)) ([63c061e](63c061e))
* wrong currency on financial-statement based reports ([#36524](#36524)) ([3044f46](3044f46))

### Features

* add voucher totals in tds payable report ([#36568](#36568)) ([90b390c](90b390c))
* daily asset depreciation method ([#36587](#36587)) ([2918127](2918127))
* Reallow customizing company abbreviation on setup. ([#36646](#36646)) ([ca34b63](ca34b63))

### Performance Improvements

* **invoice:** Faster return amount query (backport [#36556](#36556)) ([#36557](#36557)) ([fe41be9](fe41be9))
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 14.35.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@commit-lint commit-lint bot mentioned this pull request Sep 12, 2023
Merged
@rohitwaghchaure rohitwaghchaure mentioned this pull request Nov 2, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@s-aga-r s-aga-r Awaiting requested review from s-aga-r s-aga-r is a code owner

Assignees
No one assigned
Labels
released stock
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rohitwaghchaure @frappe-pr-bot