Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incorrect available qty for backdated stock reco with batch #37858

Merged
merged 2 commits into from
Nov 3, 2023
Merged

fix: incorrect available qty for backdated stock reco with batch #37858

merged 2 commits into from
Nov 3, 2023

Conversation

rohitwaghchaure
Copy link
Collaborator

Backport #36581

@github-actions github-actions bot added needs-tests This PR needs automated unit-tests. stock labels Nov 2, 2023
@rohitwaghchaure rohitwaghchaure force-pushed the repost-currect-quantity-for-stock-reco branch 2 times, most recently from 7503f48 to 05b6ede Compare November 3, 2023 06:37
@rohitwaghchaure rohitwaghchaure force-pushed the repost-currect-quantity-for-stock-reco branch from 05b6ede to 4dec4bf Compare November 3, 2023 06:58
@codecov Codecov
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #37858 (4dec4bf) into develop (ed1c198) will increase coverage by 0.03%.
Report is 9 commits behind head on develop.
The diff coverage is 85.71%.

@@             Coverage Diff             @@
##           develop   #37858      +/-   ##
===========================================
+ Coverage    67.34%   67.38%   +0.03%     
===========================================
  Files          755      755              
  Lines        60145    60169      +24     
===========================================
+ Hits         40506    40542      +36     
+ Misses       19639    19627      -12
Files Coverage Δ
...serial_and_batch_bundle/serial_and_batch_bundle.py 72.96% <100.00%> (+0.03%) ⬆️
erpnext/stock/report/stock_ledger/stock_ledger.py 66.66% <ø> (ø)
...er_invariant_check/stock_ledger_invariant_check.py 34.32% <0.00%> (ø)
...ctype/stock_reconciliation/stock_reconciliation.py 73.90% <93.87%> (+4.08%) ⬆️
erpnext/stock/stock_ledger.py 83.53% <60.00%> (-0.05%) ⬇️

... and 1 file with indirect coverage changes

@rohitwaghchaure rohitwaghchaure merged commit d4c0dbf into frappe:develop Nov 3, 2023
13 checks passed
mergify bot pushed a commit that referenced this pull request Dec 17, 2023
@rohitwaghchaure @mergify
fix: incorrect available qty for backdated stock reco with batch (#37858
0766aa1 
)

* fix: incorrect available qty for backdated stock reco with batch

* test: added test case

(cherry picked from commit d4c0dbf)
@mergify mergify bot mentioned this pull request Dec 17, 2023
Merged
rohitwaghchaure added a commit that referenced this pull request Dec 17, 2023
@mergify @rohitwaghchaure
fix: incorrect available qty for backdated stock reco with batch (bac…
18bd330 
…kport #37858) (#38811)

fix: incorrect available qty for backdated stock reco with batch (#37858)

* fix: incorrect available qty for backdated stock reco with batch

* test: added test case

(cherry picked from commit d4c0dbf)

Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com>
frappe-pr-bot pushed a commit that referenced this pull request Dec 20, 2023
@frappe-bot
chore(release): Bumped to Version 15.7.0
2a5164d 
# [15.7.0](v15.6.1...v15.7.0) (2023-12-20)

### Bug Fixes

* asset patch failure due to missing shift_based column (backport [#38776](#38776)) ([#38777](#38777)) ([6e92c78](6e92c78))
* barcode scanning for the stock entry (backport [#38716](#38716)) ([#38718](#38718)) ([1dcb065](1dcb065))
* **demo:** Demo setup for canadian COA ([7d84441](7d84441))
* fetch exc rate of multi currency journals ([f55b561](f55b561))
* fetch item_tax_template values if fields with fetch_from exisit ([fba28d6](fba28d6))
* groups for current accounts in German CoAs ([58de991](58de991))
* homepage not working (backport [#38755](#38755)) ([#38756](#38756)) ([ad3a5b5](ad3a5b5))
* if not budget then don't validate (backport [#38861](#38861)) ([#38865](#38865)) ([5ec75fb](5ec75fb))
* incoming rate for sales return with Moving Average valuation method (backport [#38849](#38849)) (backport [#38863](#38863)) ([#38866](#38866)) ([d65be69](d65be69))
* incorrect available qty for backdated stock reco with batch (backport [#37858](#37858)) ([#38811](#38811)) ([18bd330](18bd330))
* Init internal child table values ([7802f6c](7802f6c))
* item variant with manufacturer (backport [#38845](#38845)) (backport [#38847](#38847)) ([#38851](#38851)) ([7320440](7320440))
* not able to cancel SCR with Batch (backport [#38817](#38817)) (backport [#38821](#38821)) ([#38829](#38829)) ([4bd1a5f](4bd1a5f))
* not able to make inter-company po from so (backport [#38826](#38826)) (backport [#38828](#38828)) ([#38833](#38833)) ([02ceee6](02ceee6))
* on closed unreserved the production plan qty (backport [#38848](#38848)) (backport [#38859](#38859)) ([#38862](#38862)) ([cbbc6af](cbbc6af))
* **pe:** show split alert only on splitting ([77dba48](77dba48))
* Reset SLA on issue doesn't work (backport [#38789](#38789)) ([#38791](#38791)) ([2045306](2045306))
* serial and batch bundle return not working (backport [#38754](#38754)) ([#38806](#38806)) ([8990c48](8990c48))
* set `fg-itm-qty` based on `qty` instead of the other way round in Subcontracting POs (backport [#38842](#38842)) ([#38855](#38855)) ([4e27174](4e27174))
* show bill_date and bill_no in Purchase Register ([4ed86db](4ed86db))
* skip jvs against bank accounts ([bf8a2d0](bf8a2d0))
* supplier removed on selection of item (backport [#38712](#38712)) ([#38713](#38713)) ([feb452b](feb452b))
* timezone aware SLA banner (backport [#38745](#38745)) ([#38747](#38747)) ([a551660](a551660))
* **ux:** don't override Item Name and Description in MR (backport [#38720](#38720)) ([#38763](#38763)) ([703be50](703be50))
* validation error on reconciling PE to Journals as Invoice ([aa5e16e](aa5e16e))
* wrong currency in Stock Balance report (backport [#38778](#38778)) ([#38780](#38780)) ([7fc8150](7fc8150))
* wrong paid and cn amount on pos invoice ([cff9e47](cff9e47))

### Features

* RFQ print preview ([f30bede](f30bede))
* set lead name from email ([f770621](f770621))

### Performance Improvements

* index `return_against` on delivery note (backport [#38827](#38827)) ([#38832](#38832)) ([6ad75e7](6ad75e7))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@s-aga-r s-aga-r Awaiting requested review from s-aga-r s-aga-r is a code owner

Assignees
No one assigned
Labels
backport version-15-hotfix needs-tests This PR needs automated unit-tests. stock
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rohitwaghchaure