Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: batch selection issue #41692

Merged

Conversation

rohitwaghchaure
Copy link
Collaborator

Issue

Batch No dropdown showing blank values
Screenshot 2024-05-30 at 5 19 39 PM

But it shows batch no, if user manually type the batch id
Screenshot 2024-05-30 at 5 19 49 PM

After Fix
Screenshot 2024-05-30 at 5 21 38 PM

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label May 30, 2024
@rohitwaghchaure rohitwaghchaure added backport version-15-hotfix and removed needs-tests This PR needs automated unit-tests. labels May 30, 2024
@rohitwaghchaure rohitwaghchaure merged commit 968120d into frappe:develop May 30, 2024
18 checks passed
mergify bot pushed a commit that referenced this pull request May 30, 2024
(cherry picked from commit 968120d)
rohitwaghchaure added a commit that referenced this pull request May 30, 2024
fix: batch selection issue (#41692)

(cherry picked from commit 968120d)

Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com>
mergify bot added a commit that referenced this pull request May 30, 2024
fix: batch selection issue (#41692)

(cherry picked from commit 968120d)

Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com>
(cherry picked from commit 24775db)
rohitwaghchaure pushed a commit that referenced this pull request May 30, 2024
fix: batch selection issue (backport #41692) (#41693)

fix: batch selection issue (#41692)

(cherry picked from commit 968120d)

Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com>
(cherry picked from commit 24775db)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
frappe-pr-bot pushed a commit that referenced this pull request May 30, 2024
## [15.26.1](v15.26.0...v15.26.1) (2024-05-30)

### Bug Fixes

* batch selection issue (backport [#41692](#41692)) (backport [#41693](#41693)) ([#41694](#41694)) ([64835b9](64835b9))
aarifshoaib pushed a commit to aarifshoaib/cleaning-erpnext that referenced this pull request Jun 3, 2024
## [15.26.1](frappe/erpnext@v15.26.0...v15.26.1) (2024-05-30)

### Bug Fixes

* batch selection issue (backport [#41692](frappe/erpnext#41692)) (backport [#41693](frappe/erpnext#41693)) ([#41694](frappe/erpnext#41694)) ([64835b9](frappe/erpnext@64835b9))
frappe-pr-bot pushed a commit that referenced this pull request Jun 5, 2024
# [15.27.0](v15.26.1...v15.27.0) (2024-06-05)

### Bug Fixes

* Auditor permissions (backport [#41659](#41659)) ([#41661](#41661)) ([27f3981](27f3981))
* bank account no fieldname mismatch (backport [#41778](#41778)) ([#41783](#41783)) ([b94a6f2](b94a6f2))
* batch selection issue (backport [#41692](#41692)) ([#41693](#41693)) ([24775db](24775db))
* **Company:** Allow Equity type account in unrealised exchange gain/loss account (backport [#41740](#41740)) ([#41747](#41747)) ([460ee5d](460ee5d))
* condition filter for transaction pricing rule ([e493b11](e493b11))
* convert percentage from str to float (backport [#41766](#41766)) ([#41776](#41776)) ([cd0852f](cd0852f))
* Copy depreciation schedule on asset split only if it exists (backport [#41775](#41775)) ([#41784](#41784)) ([03bf480](03bf480))
* filtered out data having none values in date field (backport [#41457](#41457)) ([#41765](#41765)) ([97b1b7f](97b1b7f))
* Filters in account balance report ([0b9d89b](0b9d89b))
* French chart of account the 4191 code must be of type Income Account ([797b718](797b718))
* get assets received but not billed account only if any asset item is received (backport [#41734](#41734)) ([#41735](#41735)) ([638c944](638c944))
* Ignore disabling default currency field while creating new company (backport [#41699](#41699)) ([#41761](#41761)) ([dc922ab](dc922ab))
* incorrect accumulated depr amount in asset depr ledger (backport [#41654](#41654)) ([#41763](#41763)) ([a93cd02](a93cd02))
* incorrect batch selection while sales return (backport [#41768](#41768)) ([#41772](#41772)) ([95c0dc9](95c0dc9))
* key error for stock ledger report (backport [#41700](#41700)) ([#41703](#41703)) ([b22d714](b22d714))
* link opportunity in prospect after creating opportunity from prospect (backport [#41769](#41769)) ([#41777](#41777)) ([d30aee5](d30aee5))
* local var referenced before assignment (backport [#41780](#41780)) ([#41782](#41782)) ([3777cae](3777cae))
* **minor:** corrected wrong filter condition (backport [#41755](#41755)) ([#41762](#41762)) ([a67fa68](a67fa68))
* payment term when creating PO from SO (backport [#41376](#41376)) ([#41744](#41744)) ([806ff5b](806ff5b))
* Select both account number and company in the account form (backport [#41731](#41731)) ([#41737](#41737)) ([c5d72cd](c5d72cd))
* show material to supplier button (backport [#41686](#41686)) ([#41688](#41688)) ([1a24914](1a24914))
* **stock settings:** Allowed any number in stock frozen upto days field (backport [#41736](#41736)) ([#41749](#41749)) ([278682f](278682f))
* test for pricing rule transaction with cond ([0823de8](0823de8))
* Transaction currency value in Journal Entry (backport [#41717](#41717)) ([#41720](#41720)) ([77f58ca](77f58ca))
* TypeError: 'float' object is not iterable (backport [#41758](#41758)) ([#41764](#41764)) ([12addb7](12addb7))
* Use full name instead of abbreviation ([#41759](#41759)) ([5448d5d](5448d5d))
* work order created message pops up if no items are selected (backport [#41677](#41677)) ([#41682](#41682)) ([4e9faf6](4e9faf6))

### Features

* optional to reconcile all serial nos / batches in stock reconciliation (backport [#41696](#41696)) ([#41713](#41713)) ([38249f4](38249f4))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant