-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: show material to supplier button #41686
Merged
rohitwaghchaure
merged 1 commit into
frappe:develop
from
rohitwaghchaure:fixed-show-material-to-supplier-button
May 30, 2024
Merged
fix: show material to supplier button #41686
rohitwaghchaure
merged 1 commit into
frappe:develop
from
rohitwaghchaure:fixed-show-material-to-supplier-button
May 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
322265a
to
13c17b4
Compare
mergify bot
pushed a commit
that referenced
this pull request
May 30, 2024
(cherry picked from commit be9f960)
rohitwaghchaure
added a commit
that referenced
this pull request
May 30, 2024
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jun 5, 2024
# [15.27.0](v15.26.1...v15.27.0) (2024-06-05) ### Bug Fixes * Auditor permissions (backport [#41659](#41659)) ([#41661](#41661)) ([27f3981](27f3981)) * bank account no fieldname mismatch (backport [#41778](#41778)) ([#41783](#41783)) ([b94a6f2](b94a6f2)) * batch selection issue (backport [#41692](#41692)) ([#41693](#41693)) ([24775db](24775db)) * **Company:** Allow Equity type account in unrealised exchange gain/loss account (backport [#41740](#41740)) ([#41747](#41747)) ([460ee5d](460ee5d)) * condition filter for transaction pricing rule ([e493b11](e493b11)) * convert percentage from str to float (backport [#41766](#41766)) ([#41776](#41776)) ([cd0852f](cd0852f)) * Copy depreciation schedule on asset split only if it exists (backport [#41775](#41775)) ([#41784](#41784)) ([03bf480](03bf480)) * filtered out data having none values in date field (backport [#41457](#41457)) ([#41765](#41765)) ([97b1b7f](97b1b7f)) * Filters in account balance report ([0b9d89b](0b9d89b)) * French chart of account the 4191 code must be of type Income Account ([797b718](797b718)) * get assets received but not billed account only if any asset item is received (backport [#41734](#41734)) ([#41735](#41735)) ([638c944](638c944)) * Ignore disabling default currency field while creating new company (backport [#41699](#41699)) ([#41761](#41761)) ([dc922ab](dc922ab)) * incorrect accumulated depr amount in asset depr ledger (backport [#41654](#41654)) ([#41763](#41763)) ([a93cd02](a93cd02)) * incorrect batch selection while sales return (backport [#41768](#41768)) ([#41772](#41772)) ([95c0dc9](95c0dc9)) * key error for stock ledger report (backport [#41700](#41700)) ([#41703](#41703)) ([b22d714](b22d714)) * link opportunity in prospect after creating opportunity from prospect (backport [#41769](#41769)) ([#41777](#41777)) ([d30aee5](d30aee5)) * local var referenced before assignment (backport [#41780](#41780)) ([#41782](#41782)) ([3777cae](3777cae)) * **minor:** corrected wrong filter condition (backport [#41755](#41755)) ([#41762](#41762)) ([a67fa68](a67fa68)) * payment term when creating PO from SO (backport [#41376](#41376)) ([#41744](#41744)) ([806ff5b](806ff5b)) * Select both account number and company in the account form (backport [#41731](#41731)) ([#41737](#41737)) ([c5d72cd](c5d72cd)) * show material to supplier button (backport [#41686](#41686)) ([#41688](#41688)) ([1a24914](1a24914)) * **stock settings:** Allowed any number in stock frozen upto days field (backport [#41736](#41736)) ([#41749](#41749)) ([278682f](278682f)) * test for pricing rule transaction with cond ([0823de8](0823de8)) * Transaction currency value in Journal Entry (backport [#41717](#41717)) ([#41720](#41720)) ([77f58ca](77f58ca)) * TypeError: 'float' object is not iterable (backport [#41758](#41758)) ([#41764](#41764)) ([12addb7](12addb7)) * Use full name instead of abbreviation ([#41759](#41759)) ([5448d5d](5448d5d)) * work order created message pops up if no items are selected (backport [#41677](#41677)) ([#41682](#41682)) ([4e9faf6](4e9faf6)) ### Features * optional to reconcile all serial nos / batches in stock reconciliation (backport [#41696](#41696)) ([#41713](#41713)) ([38249f4](38249f4))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Set over transfer allowance still Transfer -> material to supplier button not showing on the SCO
Buying Settings
![Screenshot 2024-05-30 at 12 07 12 PM](https://private-user-images.githubusercontent.com/8780500/335085183-6757ac45-8b99-4f36-ac34-481ce2514bfc.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQyOTIzMTIsIm5iZiI6MTcyNDI5MjAxMiwicGF0aCI6Ii84NzgwNTAwLzMzNTA4NTE4My02NzU3YWM0NS04Yjk5LTRmMzYtYWMzNC00ODFjZTI1MTRiZmMucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgyMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MjJUMDIwMDEyWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9Y2JjODAwNGMzYjY0NzJjNzlmZWVhYWUxYzExOWUzYjMxYjA5MmRlMWQ1YWZmYmRiZGRkZjk2Njk1NjE2MDUyOCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.O9r5VbhQMGeGh8Z89RS9u0r5ixjIMjzUzDlCg4Jd63Q)
Subcontracting Order
![Screenshot 2024-05-30 at 11 03 21 AM](https://private-user-images.githubusercontent.com/8780500/335085591-8ce98c94-f79b-4a23-b0d1-2e1ca9f5a100.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQyOTIzMTIsIm5iZiI6MTcyNDI5MjAxMiwicGF0aCI6Ii84NzgwNTAwLzMzNTA4NTU5MS04Y2U5OGM5NC1mNzliLTRhMjMtYjBkMS0yZTFjYTlmNWExMDAucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgyMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MjJUMDIwMDEyWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NzZhNGI5ZjhhYTVlZGZhZTFmZmQwM2MxMGIyNDE3Y2EwMjJkZjVhYWVjNGViMWI1NTFiMjZmNmEzNDlhMmZiYiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.fsokfCuj8V1qBkFNLBvfulRPYnluuICfPFJ9MVjgFsw)
After Fix
![Screenshot 2024-05-30 at 12 07 03 PM](https://private-user-images.githubusercontent.com/8780500/335085063-9691bd9b-fa54-4db3-8a42-ac75917184df.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQyOTIzMTIsIm5iZiI6MTcyNDI5MjAxMiwicGF0aCI6Ii84NzgwNTAwLzMzNTA4NTA2My05NjkxYmQ5Yi1mYTU0LTRkYjMtOGE0Mi1hYzc1OTE3MTg0ZGYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgyMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MjJUMDIwMDEyWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YjcxZTM2YWE2NzA4MGFjYWVjNGNhZmZjY2U4Zjg1OWJkZDIwOGY0MDdhNWFhZGZjZTJmNDgxOTEzYTg4NDhlYyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.k9Y8gGyDmy9KnC2kH_KtJKuyGJY1D8KiofS0YmKWqhY)