feat: search in translated title, if we show title (backport #17828) #18395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* refactor: use meta.translated_doctype * refactor: get_title_field_query * feat: search in title, if we show title * refactor: build_for_autosuggest * style: black * fix: don't order translated doctypes by untranslated relevance * feat: match all fields for translated doctypes * feat: translate all fields in description, remove redundant title * refactor: title in link * fix: show name in description for title links (cherry picked from commit 3d17e15)
mergify
bot
requested review from
a team and
shariquerik
and removed request for
a team
github-actions
bot
added
the
add-test-cases
frappe-pr-bot
pushed a commit
that referenced
this pull request
Oct 18, 2022
# [14.12.0](v14.11.1...v14.12.0) (2022-10-18) ### Bug Fixes * add flags to set_permission for docshares ([#18416](#18416)) ([#18429](#18429)) ([a2ba0aa](a2ba0aa)) * correct import for markupsafe.escape ([c2f1c57](c2f1c57)) * **dx:** resolve_class ([#18417](#18417)) ([#18421](#18421)) ([c47de0d](c47de0d)) * explicitly set doctype in queries ([#18403](#18403)) ([#18405](#18405)) ([6848ee9](6848ee9)) * format currency value as float while grid upload ([5eb803c](5eb803c)) * google calendar sync times ([#18384](#18384)) ([#18394](#18394)) ([7c9ee6d](7c9ee6d)) * Notifications. Get Alerts for Today button [#18423](#18423) ([#18428](#18428)) ([63e3c61](63e3c61)) * progress bar not disappearing ([#18375](#18375)) ([#18392](#18392)) ([e0d6d0b](e0d6d0b)) * reshuffle __newname field to accommodate under 1st Tab Break ([#18406](#18406)) ([#18427](#18427)) ([f833e5d](f833e5d)) * Show error page even when routing fails ([#18437](#18437)) ([#18438](#18438)) ([5d3e97a](5d3e97a)) * **UI:** child table custom horizontal scroll ([ec09123](ec09123)) * **UI:** Child table responsive ([cb866f9](cb866f9)) * **UI:** consider 2px border at grid end ([c85fb2d](c85fb2d)) * **UI:** lesser margin if cell is focused ([f3ad63a](f3ad63a)) ### Features * allow syncing new fields in Doctype Layout ([#18408](#18408)) ([c73e2e2](c73e2e2)) * search in translated title, if we show title ([#17828](#17828)) ([#18395](#18395)) ([73758d7](73758d7)) ### Performance Improvements * Perform `db.set_value` with single query only (backport [#18305](#18305)) ([#18349](#18349)) ([23caa1f](23caa1f))
|
🎉 This PR is included in version 14.12.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #17828 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com