feat: meaningful report pdf name (backport #18422) #18480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* feat: meaningful report pdf name * feat: limited filename length * chore: uncomment line (cherry picked from commit f383669)
mergify
bot
requested review from
a team and
shariquerik
and removed request for
a team
frappe-pr-bot
pushed a commit
that referenced
this pull request
Oct 25, 2022
# [14.13.0](v14.12.0...v14.13.0) (2022-10-25) ### Bug Fixes * consider now datetime if the default value is now for datetime field ([b42013c](b42013c)) * delete custom tables when doctype is deleted ([#18433](#18433)) ([#18471](#18471)) ([cb4d825](cb4d825)) * dont db_set on unsaved document ([798206c](798206c)) * **frappe.client:** delete child doc via parent ([8806eae](8806eae)) * google calendar sync times (system tz) ([#18458](#18458)) ([#18459](#18459)) ([871415a](871415a)) * Improve Translation on To Do list view ([#18484](#18484)) ([ddec3e0](ddec3e0)) * map view doesnt open ([#18487](#18487)) ([ed54235](ed54235)) * **minor:** consider lowercase value for comparision in set_formatted_input for datetime field ([a190830](a190830)) * only execute generator if value is not found in redis cache ([#18472](#18472)) ([#18479](#18479)) ([342edb7](342edb7)) * raise error if child doc not found ([0dcf5e6](0dcf5e6)) * validate website settings ([#18446](#18446)) ([#18469](#18469)) ([9e29a94](9e29a94)) ### Features * configurable default views ([#18409](#18409)) ([#18434](#18434)) ([5c0bb7e](5c0bb7e)) * db storage usage report ([#18464](#18464)) ([#18467](#18467)) ([7cfe2d2](7cfe2d2)) * meaningful report pdf name ([#18422](#18422)) ([#18480](#18480)) ([f650150](f650150))
|
🎉 This PR is included in version 14.13.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
stephenBDT
pushed a commit
to alias/frappe
that referenced
this pull request
Nov 7, 2022
* feat: meaningful report pdf name * feat: limited filename length * chore: uncomment line (cherry picked from commit f383669) Co-authored-by: Dany Robert <danyrt@wahni.com>
stephenBDT
pushed a commit
to alias/frappe
that referenced
this pull request
Nov 7, 2022
# [14.13.0](frappe/frappe@v14.12.0...v14.13.0) (2022-10-25) ### Bug Fixes * consider now datetime if the default value is now for datetime field ([b42013c](frappe@b42013c)) * delete custom tables when doctype is deleted ([frappe#18433](frappe#18433)) ([frappe#18471](frappe#18471)) ([cb4d825](frappe@cb4d825)) * dont db_set on unsaved document ([798206c](frappe@798206c)) * **frappe.client:** delete child doc via parent ([8806eae](frappe@8806eae)) * google calendar sync times (system tz) ([frappe#18458](frappe#18458)) ([frappe#18459](frappe#18459)) ([871415a](frappe@871415a)) * Improve Translation on To Do list view ([frappe#18484](frappe#18484)) ([ddec3e0](frappe@ddec3e0)) * map view doesnt open ([frappe#18487](frappe#18487)) ([ed54235](frappe@ed54235)) * **minor:** consider lowercase value for comparision in set_formatted_input for datetime field ([a190830](frappe@a190830)) * only execute generator if value is not found in redis cache ([frappe#18472](frappe#18472)) ([frappe#18479](frappe#18479)) ([342edb7](frappe@342edb7)) * raise error if child doc not found ([0dcf5e6](frappe@0dcf5e6)) * validate website settings ([frappe#18446](frappe#18446)) ([frappe#18469](frappe#18469)) ([9e29a94](frappe@9e29a94)) ### Features * configurable default views ([frappe#18409](frappe#18409)) ([frappe#18434](frappe#18434)) ([5c0bb7e](frappe@5c0bb7e)) * db storage usage report ([frappe#18464](frappe#18464)) ([frappe#18467](frappe#18467)) ([7cfe2d2](frappe@7cfe2d2)) * meaningful report pdf name ([frappe#18422](frappe#18422)) ([frappe#18480](frappe#18480)) ([f650150](frappe@f650150))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #18422 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com