fix(UX): shift-select checkboxes ranges (backport #19367) #19368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
This doesn't work if document names have spaces in them. This is because data props are urlencoded while we are comparing it with raw data. (cherry picked from commit 272d9e0)
mergify
bot
requested review from
a team and
phot0n
and removed request for
a team
frappe-pr-bot
pushed a commit
that referenced
this pull request
Dec 27, 2022
# [14.21.0](v14.20.0...v14.21.0) (2022-12-27) ### Bug Fixes * Allow emailing disabled user ([#19382](#19382)) ([#19383](#19383)) ([fb7f645](fb7f645)) * **error snapshot:** fix seen update qeury in error snapshot to work with postgres ([#19373](#19373)) ([#19374](#19374)) ([0ab6a30](0ab6a30)) * **minor:** dont set autoincrement autoname by default for child table ([8ff3f4c](8ff3f4c)) * not able to make delivery note from pick list ([#19418](#19418)) ([#19420](#19420)) ([d2d776c](d2d776c)) * shift-select checkboxes ranges ([#19367](#19367)) ([#19368](#19368)) ([bd79b03](bd79b03)) * **subscription:** Allow remote_login even if subscription.expiry is not set ([1d777dc](1d777dc)) ### Features * hook `ignore_links_on_delete` to skip doctypes on delete ([#19347](#19347)) ([#19356](#19356)) ([a457447](a457447))
|
🎉 This PR is included in version 14.21.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
developmentforpeople
pushed a commit
to developmentforpeople/frappe
that referenced
this pull request
Jan 3, 2023
This doesn't work if document names have spaces in them. This is because data props are urlencoded while we are comparing it with raw data. (cherry picked from commit 272d9e0) Co-authored-by: Ankush Menat <ankush@frappe.io>
developmentforpeople
pushed a commit
to developmentforpeople/frappe
that referenced
this pull request
Jan 3, 2023
# [14.21.0](frappe/frappe@v14.20.0...v14.21.0) (2022-12-27) ### Bug Fixes * Allow emailing disabled user ([frappe#19382](frappe#19382)) ([frappe#19383](frappe#19383)) ([fb7f645](frappe@fb7f645)) * **error snapshot:** fix seen update qeury in error snapshot to work with postgres ([frappe#19373](frappe#19373)) ([frappe#19374](frappe#19374)) ([0ab6a30](frappe@0ab6a30)) * **minor:** dont set autoincrement autoname by default for child table ([8ff3f4c](frappe@8ff3f4c)) * not able to make delivery note from pick list ([frappe#19418](frappe#19418)) ([frappe#19420](frappe#19420)) ([d2d776c](frappe@d2d776c)) * shift-select checkboxes ranges ([frappe#19367](frappe#19367)) ([frappe#19368](frappe#19368)) ([bd79b03](frappe@bd79b03)) * **subscription:** Allow remote_login even if subscription.expiry is not set ([1d777dc](frappe@1d777dc)) ### Features * hook `ignore_links_on_delete` to skip doctypes on delete ([frappe#19347](frappe#19347)) ([frappe#19356](frappe#19356)) ([a457447](frappe@a457447))
stephenBDT
pushed a commit
to alias/frappe
that referenced
this pull request
Jan 10, 2023
This doesn't work if document names have spaces in them. This is because data props are urlencoded while we are comparing it with raw data. (cherry picked from commit 272d9e0) Co-authored-by: Ankush Menat <ankush@frappe.io>
stephenBDT
pushed a commit
to alias/frappe
that referenced
this pull request
Jan 10, 2023
# [14.21.0](frappe/frappe@v14.20.0...v14.21.0) (2022-12-27) ### Bug Fixes * Allow emailing disabled user ([frappe#19382](frappe#19382)) ([frappe#19383](frappe#19383)) ([fb7f645](frappe@fb7f645)) * **error snapshot:** fix seen update qeury in error snapshot to work with postgres ([frappe#19373](frappe#19373)) ([frappe#19374](frappe#19374)) ([0ab6a30](frappe@0ab6a30)) * **minor:** dont set autoincrement autoname by default for child table ([8ff3f4c](frappe@8ff3f4c)) * not able to make delivery note from pick list ([frappe#19418](frappe#19418)) ([frappe#19420](frappe#19420)) ([d2d776c](frappe@d2d776c)) * shift-select checkboxes ranges ([frappe#19367](frappe#19367)) ([frappe#19368](frappe#19368)) ([bd79b03](frappe@bd79b03)) * **subscription:** Allow remote_login even if subscription.expiry is not set ([1d777dc](frappe@1d777dc)) ### Features * hook `ignore_links_on_delete` to skip doctypes on delete ([frappe#19347](frappe#19347)) ([frappe#19356](frappe#19356)) ([a457447](frappe@a457447))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #19367 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com