feat: redis cache decorator #20452
Merged
feat: redis cache decorator #20452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nextchamp-saqib
requested review from
a team and
shariquerik
and removed request for
a team
github-actions
bot
added
the
add-test-cases
ankush
requested changes
Mar 24, 2023
|
@nextchamp-saqib add tests :) |
gavindsouza
reviewed
Mar 24, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #20452 +/- ##
===========================================
- Coverage 63.82% 63.71% -0.12%
===========================================
Files 758 758
Lines 68645 68809 +164
Branches 6193 6193
===========================================
+ Hits 43816 43843 +27
- Misses 21316 21453 +137
Partials 3513 3513
Flags with carried forward coverage won't be shown. Click here to find out more. |
redis cache utils already support this, extending so everyone can use it
ankush
previously approved these changes
Mar 26, 2023
ankush
added
the
tests-failing
|
Weirdly site cache tests failing... how 🥴 |
ankush
approved these changes
Mar 27, 2023
ankush
added
defer backport
ankush
removed
the
defer backport
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as
@site_cachebut set cache in redis instead of web worker.extends: #17012
no-docs