feat: improve attach_print and allow using its output in email.make #21837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use print_language context manager - Move filename and ignore_print_permissions closer to usage
barredterra
requested review from
a team and
surajshetty3416
and removed request for
a team
github-actions
bot
added
the
add-test-cases
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #21837 +/- ##
===========================================
- Coverage 62.10% 61.89% -0.21%
===========================================
Files 767 765 -2
Lines 72993 72904 -89
Branches 6302 6271 -31
===========================================
- Hits 45330 45122 -208
- Misses 24215 24250 +35
- Partials 3448 3532 +84
Flags with carried forward coverage won't be shown. Click here to find out more. |
barredterra
added
backport version-14-hotfix
barredterra
changed the title
barredterra
changed the title
Instead of "[]" to avoid useless JSON parsing.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
ankush
pushed a commit
that referenced
this pull request
Aug 29, 2023
…backport #21837) (#22144) * refactor: attach_print - Use print_language context manager - Move filename and ignore_print_permissions closer to usage * feat: letterhead param for attach_print * feat: handle attachments from frappe.attach_print In email.make() * test: add_attachments to communication * fix: use None as default for attachments Instead of "[]" to avoid useless JSON parsing. * chore: update docstings * refactor: add type hints to add_attachments
frappe-pr-bot
pushed a commit
that referenced
this pull request
Aug 30, 2023
# [14.47.0](v14.46.0...v14.47.0) (2023-08-30) ### Bug Fixes * add missing parameters for search_widget ([#22052](#22052)) ([#22181](#22181)) ([755f1cc](755f1cc)) * **Assignment Rule:** also run `on_cancel` and `on_update_after_submit` (backport [#22064](#22064)) ([#22098](#22098)) ([08e5d1f](08e5d1f)) * check workflow state field to avoid error ([5a82a45](5a82a45)) * clear server script cache on delete ([#22207](#22207)) ([#22208](#22208)) ([48a1b55](48a1b55)) * delete doctype after migrating ([#22195](#22195)) ([#22196](#22196)) ([b3679f9](b3679f9)) * dont allow rename+merge for case changes ([#22237](#22237)) ([1c7d225](1c7d225)) * **Email Inline Embed:** escape regex expression ([#22201](#22201)) ([2404259](2404259)) * limit job count in RQ failed registry (backport [#22162](#22162)) ([#22199](#22199)) ([451a6f7](451a6f7)) * translation in assignments ([#22183](#22183)) ([cae7290](cae7290)) * typerror on custom reports ([cd746a5](cd746a5)) * **UX:** Highlight which permission is missing ([#22240](#22240)) ([999c24e](999c24e)) ### Features * improve attach_print and allow using its output in email.make (backport [#21837](#21837)) ([#22144](#22144)) ([be21740](be21740))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the
print_languagecontext manager infrappe.attach_printAdd missing
letterheadparam tofrappe.attach_printMove
filenameandignore_print_permissionscloser to usageIn
frappe.sendmailwe can supply the output offrappe.attach_printas attachment. This PR enables the same functionality foremail.make.