fix: strip html and show text #22656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quill editor adds html which is useless for user so strip html using html2text and render Text only. If no text is found it will render No Text Found in + "Field Label" (ex. Description).
maharshivpatel
requested review from
surajshetty3416 and
ankush
and removed request for
a team
surajshetty3416
requested changes
Oct 10, 2023
| link.textContent = value.toString(); | ||
| // "Text Editor" and some other fieldtypes can have html tags in them so strip and show text. | ||
| // If no text is found show "No Text Found in {Field Label}" | ||
| let textValue = frappe.utils.html2text(value) || "No Text Found in " + subject_field.label; |
There was a problem hiding this comment.
Let's keep it empty if no text is found instead of "No Text Found in" since it'll be hard to distinguish among other text.
We can show "[image]" for images in the description?
There was a problem hiding this comment.
leaving it blank will be confusing to users on where to click?
[skip ci]
ankush
added
backport version-13-hotfix
backport version-14-hotfix
mergify bot
pushed a commit
that referenced
this pull request
Oct 10, 2023
* fix: strip html and show text Quill editor adds html which is useless for user so strip html using html2text and render Text only. If no text is found it will render No Text Found in + "Field Label" (ex. Description). * fix: remove placeholder text [skip ci] --------- Co-authored-by: Ankush Menat <ankush@frappe.io> (cherry picked from commit 7752136)
mergify bot
pushed a commit
that referenced
this pull request
Oct 10, 2023
* fix: strip html and show text Quill editor adds html which is useless for user so strip html using html2text and render Text only. If no text is found it will render No Text Found in + "Field Label" (ex. Description). * fix: remove placeholder text [skip ci] --------- Co-authored-by: Ankush Menat <ankush@frappe.io> (cherry picked from commit 7752136)
This was referenced Oct 10, 2023
ankush
pushed a commit
that referenced
this pull request
Oct 10, 2023
* fix: strip html and show text Quill editor adds html which is useless for user so strip html using html2text and render Text only. If no text is found it will render No Text Found in + "Field Label" (ex. Description). * fix: remove placeholder text [skip ci] --------- Co-authored-by: Ankush Menat <ankush@frappe.io> (cherry picked from commit 7752136) Co-authored-by: Maharshi Patel <39730881+maharshivpatel@users.noreply.github.com>
ankush
pushed a commit
that referenced
this pull request
Oct 10, 2023
* fix: strip html and show text Quill editor adds html which is useless for user so strip html using html2text and render Text only. If no text is found it will render No Text Found in + "Field Label" (ex. Description). * fix: remove placeholder text [skip ci] --------- Co-authored-by: Ankush Menat <ankush@frappe.io> (cherry picked from commit 7752136) Co-authored-by: Maharshi Patel <39730881+maharshivpatel@users.noreply.github.com>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Oct 11, 2023
# [14.52.0](v14.51.0...v14.52.0) (2023-10-11) ### Bug Fixes * add rate limiting and type hints for `add_feedback` ([9049a4f](9049a4f)) * allow larger URLs in Integration Request ([844fd76](844fd76)) * Apply address all perm only if owner ([de7f13f](de7f13f)) * avoid double translation ([fda329f](fda329f)) * changed table style to match grid style ([7e77bea](7e77bea)) * conditional webform with list view enabled ([45be3d3](45be3d3)) * Escape filename in sidebar ([8a9728c](8a9728c)) * Fix breakpoints CSS variables using map-get ([2fadf43](2fadf43)) * Give All role permission to read/create own address and contact ([#22642](#22642)) ([e4a7577](e4a7577)) * improved validation for address and contact ([ef5709a](ef5709a)) * keyerror on reports with subtotal ([6562139](6562139)) * no perm if doc doesn't exist ([d283b55](d283b55)) * strip html and show text ([#22656](#22656)) ([#22677](#22677)) ([55c0602](55c0602)) * **UX:** Bring responsive multi-column design to module and role editors ([3bcf15d](3bcf15d)) * **UX:** Responsive, column-major design for multicheck elements. ([5fc944a](5fc944a)) ### Features * bulk update fields select sorted by translated labels ([#22318](#22318)) ([65122b4](65122b4))
frappe-pr-bot
pushed a commit
that referenced
this pull request
Oct 17, 2023
## [13.58.13](v13.58.12...v13.58.13) (2023-10-17) ### Bug Fixes * Apply address all perm only if owner ([f6105df](f6105df)) * avoid double translation (backport [#22578](#22578)) ([2c267ea](2c267ea)) * improved validation for address and contact (backport [#22574](#22574)) ([45c5756](45c5756)) * strip html and show text ([#22656](#22656)) ([#22676](#22676)) ([d371d59](d371d59)) * validation permission on `tag` creation ([#22753](#22753)) ([#22754](#22754)) ([6247aa0](6247aa0))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quill editor adds html which is useless for user so strip html using html2text and render Text only. If no text is found it will render No Text Found in + "Field Label" (ex. Description).
Before
Before.Fix.quill.mov
After
After.fix.quill.mov