fix: strip html and show text (backport #22656) #22676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* fix: strip html and show text Quill editor adds html which is useless for user so strip html using html2text and render Text only. If no text is found it will render No Text Found in + "Field Label" (ex. Description). * fix: remove placeholder text [skip ci] --------- Co-authored-by: Ankush Menat <ankush@frappe.io> (cherry picked from commit 7752136)
mergify
bot
requested review from
a team and
ankush
and removed request for
a team
frappe-pr-bot
pushed a commit
that referenced
this pull request
Oct 17, 2023
## [13.58.13](v13.58.12...v13.58.13) (2023-10-17) ### Bug Fixes * Apply address all perm only if owner ([f6105df](f6105df)) * avoid double translation (backport [#22578](#22578)) ([2c267ea](2c267ea)) * improved validation for address and contact (backport [#22574](#22574)) ([45c5756](45c5756)) * strip html and show text ([#22656](#22656)) ([#22676](#22676)) ([d371d59](d371d59)) * validation permission on `tag` creation ([#22753](#22753)) ([#22754](#22754)) ([6247aa0](6247aa0))
|
🎉 This PR is included in version 13.58.13 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #22656 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com