fix: validate permission on tag creation
#22753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruthra-kumar
requested review from
a team and
ankush
and removed request for
a team
github-actions
bot
added
the
add-test-cases
ankush
reviewed
Oct 16, 2023
Codecov Report
@@ Coverage Diff @@
## develop #22753 +/- ##
===========================================
- Coverage 62.31% 62.02% -0.29%
===========================================
Files 768 768
Lines 73560 75019 +1459
Branches 6342 6342
===========================================
+ Hits 45837 46533 +696
- Misses 24131 24894 +763
Partials 3592 3592
Flags with carried forward coverage won't be shown. Click here to find out more. |
ruthra-kumar
force-pushed
the
permission_for_adding_tags
branch
3 times, most recently
from
cacbd67
to
2447a09
Compare
ankush
force-pushed
the
permission_for_adding_tags
branch
from
2447a09
to
05871e9
Compare
Add/remove both are controlled by update
ankush
force-pushed
the
permission_for_adding_tags
branch
from
05871e9
to
b056204
Compare
ankush
added
backport version-13-hotfix
backport version-14-hotfix
mergify bot
pushed a commit
that referenced
this pull request
Oct 16, 2023
* fix: validation permission on `tag` creation * refactor: apply checks on all operations Add/remove both are controlled by update --------- Co-authored-by: Ankush Menat <ankush@frappe.io> (cherry picked from commit d06a580) # Conflicts: # frappe/desk/doctype/tag/tag.py
mergify bot
pushed a commit
that referenced
this pull request
Oct 16, 2023
* fix: validation permission on `tag` creation * refactor: apply checks on all operations Add/remove both are controlled by update --------- Co-authored-by: Ankush Menat <ankush@frappe.io> (cherry picked from commit d06a580)
ankush
pushed a commit
that referenced
this pull request
Oct 16, 2023
* fix: validation permission on `tag` creation * refactor: apply checks on all operations Add/remove both are controlled by update --------- Co-authored-by: Ankush Menat <ankush@frappe.io> (cherry picked from commit d06a580) Co-authored-by: ruthra kumar <ruthra@erpnext.com>
ankush
pushed a commit
that referenced
this pull request
Oct 16, 2023
* fix: validation permission on `tag` creation * refactor: apply checks on all operations Add/remove both are controlled by update --------- Co-authored-by: Ankush Menat <ankush@frappe.io> (cherry picked from commit d06a580)
ankush
pushed a commit
that referenced
this pull request
Oct 16, 2023
* fix: validation permission on `tag` creation * refactor: apply checks on all operations Add/remove both are controlled by update --------- Co-authored-by: Ankush Menat <ankush@frappe.io> (cherry picked from commit d06a580) Co-authored-by: ruthra kumar <ruthra@erpnext.com>
ruthra-kumar
changed the title
tag creationtag creation
frappe-pr-bot
pushed a commit
that referenced
this pull request
Oct 17, 2023
## [13.58.13](v13.58.12...v13.58.13) (2023-10-17) ### Bug Fixes * Apply address all perm only if owner ([f6105df](f6105df)) * avoid double translation (backport [#22578](#22578)) ([2c267ea](2c267ea)) * improved validation for address and contact (backport [#22574](#22574)) ([45c5756](45c5756)) * strip html and show text ([#22656](#22656)) ([#22676](#22676)) ([d371d59](d371d59)) * validation permission on `tag` creation ([#22753](#22753)) ([#22754](#22754)) ([6247aa0](6247aa0))
frappe-pr-bot
pushed a commit
that referenced
this pull request
Oct 17, 2023
## [14.52.1](v14.52.0...v14.52.1) (2023-10-17) ### Bug Fixes * Don't mutate `df` object in frappe.format ([589e26d](589e26d)) * duplicate column in report conflict ([219b18e](219b18e)) * email from 'Table Multiselect' field ([#22733](#22733)) ([#22740](#22740)) ([b30826d](b30826d)) * enable server script while testing ([313cf7a](313cf7a)) * fixed the conflict between fieldname in General Ledger Report ([9c87707](9c87707)) * sync doctype layout on update standard field ([#22699](#22699)) ([#22742](#22742)) ([fa2a88e](fa2a88e)) * Use same filter in report view and list view ([196a71e](196a71e)) * **UX:** Add 'Due Date' to Quick Entry Form, default to Today. ([d973f83](d973f83)) * validation permission on `tag` creation ([#22753](#22753)) ([#22755](#22755)) ([cdc16ab](cdc16ab)) * work-around to fix issue with syncing Google Contacts ([#22649](#22649)) ([#22743](#22743)) ([4430798](4430798)), closes [#22648](#22648) * works for multiple rows now after saving ([be31d56](be31d56)) * workspace don't strip filter info on save. ([c2c2db8](c2c2db8))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent users from adding tags to doctype they lack access to.