feat: Enabling Redirection to a Custom URL on Notification Click #22956

TechnicalShree · 2023-10-28T11:02:51Z

Please provide enough information so that others can review your pull request:

Enabling Redirection to a Custom URL on Notification Click.

Explain the details for making this change. What existing problem does the pull request solve?

Screenshots/GIFs

Closes #22815

no-docs

chromonav · 2023-10-28T11:54:39Z

@TechnicalShree i think you will need to add cypress tests

frappe/utils/data.py

frappe/public/js/frappe/ui/notifications/notifications.js

frappe/desk/doctype/notification_log/notification_log.json

Co-authored-by: Ankush Menat <ankushmenat@gmail.com>

codecov · 2023-11-01T05:47:02Z

Codecov Report

Merging #22956 (ede8934) into develop (94b2e50) will decrease coverage by 0.78%.
Report is 73 commits behind head on develop.
The diff coverage is 71.51%.

❗ Current head ede8934 differs from pull request most recent head b3a07b8. Consider uploading reports for the commit b3a07b8 to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #22956      +/-   ##
===========================================
- Coverage    62.18%   61.40%   -0.78%     
===========================================
  Files          770      771       +1     
  Lines        73970    76773    +2803     
  Branches      6346     6339       -7     
===========================================
+ Hits         45997    47144    +1147     
- Misses       24361    26020    +1659     
+ Partials      3612     3609       -3

Flag	Coverage Δ
server	`70.73% <73.50%> (+0.02%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

shariquerik

Can you add a screen recording?
Also, where do we set custom_uri? it should be custom_url not uri

TechnicalShree · 2023-11-06T19:35:48Z

Can you add a screen recording? Also, where do we set custom_uri? it should be custom_url not uri

@shariquerik
https://komododecks.com/recordings/XnaaTPRVJT8SLKNYawym

we have changed that field form custom_uri to the link suggested by the @ankush .

frappe/desk/doctype/notification_log/notification_log.json

shariquerik · 2023-11-18T15:48:05Z

@TechnicalShree Can you make the changes? or give me access to push

shariquerik

@TechnicalShree Also need to include link type check here, it should also must have created automatically.

link: DF.Data | None

TechnicalShree · 2023-11-18T17:16:31Z

@TechnicalShree Also need to include link type check here, it should also must have created automatically.

link: DF.Data | None

@shariquerik I am no sure, but I think that's because of my local setup issue. now its generated using new bench instance.

shariquerik · 2023-11-20T06:31:28Z

@TechnicalShree Can you give me access to push on your fork? there are conflicts if you can resolve it or give me access will merge it quickly after resolving

TechnicalShree · 2023-11-20T07:24:24Z

@TechnicalShree Can you give me access to push on your fork? there are conflicts if you can resolve it or give me access will merge it quickly after resolving
@shariquerik Conflicts have been resolved now.

) * feat: notification custom routing * Update frappe/public/js/frappe/ui/notifications/notifications.js Co-authored-by: Ankush Menat <ankushmenat@gmail.com> * code refactoring * field name correction * fix: json * fix: auto generation * lint fix * fix: lint --------- Co-authored-by: Ankush Menat <ankushmenat@gmail.com> (cherry picked from commit 90cf6bb) # Conflicts: # frappe/desk/doctype/notification_log/notification_log.py

…kport #22956) (#23318) Co-authored-by: TechnicalShree <87521583+TechnicalShree@users.noreply.github.com>

# [15.2.0](v15.1.0...v15.2.0) (2023-11-22) ### Bug Fixes * added all options to add/remove section/column in section header ([05c7d67](05c7d67)) * added Dropdown component ([1349b74](1349b74)) * always show section header ([6ba6a99](6ba6a99)) * call auth hooks before raising error (backport [#23255](#23255)) ([#23268](#23268)) ([128fac7](128fac7)) * copy any flags if required in rename_doc() only on validate ([d790ec2](d790ec2)) * correct max file size in boot ([9e2b701](9e2b701)) * disable only save button, not the entire form ([349e4d7](349e4d7)) * don't copy value of "Is Standard" ([205ec4e](205ec4e)) * dont rename link fields in Virtual doctypes ([#23294](#23294)) ([99a3b4d](99a3b4d)) * email linking (backport [#23224](#23224)) ([#23226](#23226)) ([a02adef](a02adef)) * **email:** Allow users to pull all (read & unread) emails during initial sync ([a48fd81](a48fd81)) * **event/sync_communication:** add `distinct` while querying communication links ([1eb0f7e](1eb0f7e)) * Font for arabic and not supported languages ([#23234](#23234)) ([#23326](#23326)) ([f99b9d4](f99b9d4)) * Form Builder / Workflow Builder fixes (backport [#23238](#23238)) ([#23244](#23244)) ([c0ca3a8](c0ca3a8)) * honour max file size in upload file ([e63de38](e63de38)) * Ignore `None` returned by RQ job ([aeab15b](aeab15b)) * ignore case of filetype ([5bc6d1f](5bc6d1f)) * ignore invalid token so auth hooks can apply ([23e1a48](23e1a48)) * incorrect date range when relinking files ([#23197](#23197)) ([ab78bef](ab78bef)) * increase length for address lines ([2e126b6](2e126b6)) * **minor:** mobile menu & sidebar attachment text ([#23013](#23013)) ([#23014](#23014)) ([cd14e2a](cd14e2a)) * **minor:** web and timeline styles ([#23083](#23083)) ([c752ae5](c752ae5)) * move field description to doctype definition ([68f3748](68f3748)) * not able to edit private workspace (backport [#23241](#23241)) ([#23245](#23245)) ([f8eb101](f8eb101)) * remove link - modifying while iterating ([d5105ed](d5105ed)) * remove quotes from IMAP Folder Name ([#23242](#23242)) ([#23325](#23325)) ([9089f29](9089f29)) * removed unsed code from Column.vue ([406e0a5](406e0a5)) * review points when added more then once. ([#23239](#23239)) ([#23344](#23344)) ([11eb9a8](11eb9a8)) * send correct username in userinfo ([#23177](#23177)) ([#23178](#23178)) ([8c61435](8c61435)) * test docstatus change from workflow ([6e7aa5e](6e7aa5e)) * Update email_message in the send_welcome_email function to use the use_html check for Email Template ([78559be](78559be)) * web_form_list.js invalid condition_json ([2804192](2804192)) * **web_form:** check properties for title field as well ([64eda83](64eda83)) * **WebForm:** Add missing keyboard.js dep for some controls ([2fd07ee](2fd07ee)) * **WebForm:** Replace `get_cached_value` with `get_value` ([8989289](8989289)) * **web:** Send first_day_of_the_week and number_format in bootinfo ([a6308c3](a6308c3)) * **workflow:** avoid implicit docstatus altering ([c3a1912](c3a1912)) * workspace loading issue ([#23179](#23179)) ([e06f128](e06f128)) ### Features * Enabling Redirection to a Custom URL on Notification Click (backport [#22956](#22956)) ([#23318](#23318)) ([b52fac5](b52fac5)) * workflow state wise status override (backport [#23207](#23207)) ([#23315](#23315)) ([a8fab7b](a8fab7b)) ### Reverts * code control loosing focus when edit (for now reverting need better fix) ([8dfe6a7](8dfe6a7))

feat: notification custom routing

6c85bd3

TechnicalShree requested review from a team and shariquerik and removed request for a team October 28, 2023 11:02

github-actions bot added the add-test-cases Add test case to validate fix or enhancement label Oct 28, 2023

surajshetty3416 assigned shariquerik Oct 30, 2023

ankush reviewed Oct 30, 2023

View reviewed changes

frappe/utils/data.py Outdated Show resolved Hide resolved

ankush requested changes Oct 30, 2023

View reviewed changes

frappe/public/js/frappe/ui/notifications/notifications.js Outdated Show resolved Hide resolved

frappe/desk/doctype/notification_log/notification_log.json Outdated Show resolved Hide resolved

TechnicalShree and others added 2 commits October 30, 2023 22:02

Update frappe/public/js/frappe/ui/notifications/notifications.js

bbeb214

Co-authored-by: Ankush Menat <ankushmenat@gmail.com>

code refactoring

9d09c4b

TechnicalShree requested a review from ankush November 1, 2023 05:08

shariquerik requested changes Nov 2, 2023

View reviewed changes

field name correction

8066dfa

TechnicalShree requested a review from shariquerik November 8, 2023 05:17

shariquerik requested changes Nov 16, 2023

View reviewed changes

frappe/desk/doctype/notification_log/notification_log.json Show resolved Hide resolved

fix: json

5af70b1

TechnicalShree requested a review from shariquerik November 18, 2023 16:43

shariquerik requested changes Nov 18, 2023

View reviewed changes

fix: auto generation

c5cfa8a

shariquerik added squash fix-frappe-linter and removed add-test-cases Add test case to validate fix or enhancement labels Nov 18, 2023

lint fix

2bf5652

shariquerik removed the fix-frappe-linter label Nov 20, 2023

shariquerik enabled auto-merge (squash) November 20, 2023 06:27

shariquerik disabled auto-merge November 20, 2023 06:27

Merge branch 'develop' into custom-page-redirection-in-notifications

ede8934

fix: lint

b3a07b8

shariquerik merged commit 90cf6bb into frappe:develop Nov 20, 2023
18 of 23 checks passed

shariquerik added the backport version-15-hotfix Backport the PR to v15 label Nov 20, 2023

mergify bot mentioned this pull request Nov 20, 2023

feat: Enabling Redirection to a Custom URL on Notification Click (backport #22956) #23318

Merged

shariquerik pushed a commit that referenced this pull request Nov 20, 2023

feat: Enabling Redirection to a Custom URL on Notification Click (bac…

b52fac5

…kport #22956) (#23318) Co-authored-by: TechnicalShree <87521583+TechnicalShree@users.noreply.github.com>

github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Enabling Redirection to a Custom URL on Notification Click #22956

feat: Enabling Redirection to a Custom URL on Notification Click #22956

TechnicalShree commented Oct 28, 2023 •

edited by shariquerik

chromonav commented Oct 28, 2023

codecov bot commented Nov 1, 2023 •

edited

shariquerik left a comment

TechnicalShree commented Nov 6, 2023

shariquerik commented Nov 18, 2023

shariquerik left a comment •

edited

TechnicalShree commented Nov 18, 2023

shariquerik commented Nov 20, 2023

TechnicalShree commented Nov 20, 2023

feat: Enabling Redirection to a Custom URL on Notification Click #22956

feat: Enabling Redirection to a Custom URL on Notification Click #22956

Conversation

TechnicalShree commented Oct 28, 2023 • edited by shariquerik

chromonav commented Oct 28, 2023

codecov bot commented Nov 1, 2023 • edited

Codecov Report

shariquerik left a comment

Choose a reason for hiding this comment

TechnicalShree commented Nov 6, 2023

shariquerik commented Nov 18, 2023

shariquerik left a comment • edited

Choose a reason for hiding this comment

TechnicalShree commented Nov 18, 2023

shariquerik commented Nov 20, 2023

TechnicalShree commented Nov 20, 2023

TechnicalShree commented Oct 28, 2023 •

edited by shariquerik

codecov bot commented Nov 1, 2023 •

edited

shariquerik left a comment •

edited