Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not able to edit private workspace #23241

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

shariquerik
Copy link
Member

@shariquerik shariquerik commented Nov 16, 2023

Fixes: #23214

  1. Was not able to edit private workspace icon
  2. Only show the icon field for the public workspace and the indicator color field for the private workspace
  3. Fixed Webform UI test

@shariquerik shariquerik requested review from a team and surajshetty3416 and removed request for a team and surajshetty3416 November 16, 2023 09:29
@shariquerik shariquerik added the backport version-15-hotfix Backport the PR to v15 label Nov 16, 2023
@shariquerik
Copy link
Member Author

Unrelated test failing

@shariquerik shariquerik merged commit bfe5d81 into frappe:develop Nov 16, 2023
21 of 23 checks passed
shariquerik added a commit that referenced this pull request Nov 16, 2023
Co-authored-by: Shariq Ansari <sharique.rik@gmail.com>
frappe-pr-bot pushed a commit that referenced this pull request Nov 22, 2023
# [15.2.0](v15.1.0...v15.2.0) (2023-11-22)

### Bug Fixes

* added all options to add/remove section/column in section header ([05c7d67](05c7d67))
* added Dropdown component ([1349b74](1349b74))
* always show section header ([6ba6a99](6ba6a99))
* call auth hooks before raising error (backport [#23255](#23255)) ([#23268](#23268)) ([128fac7](128fac7))
* copy any flags if required in rename_doc() only on validate ([d790ec2](d790ec2))
* correct max file size in boot ([9e2b701](9e2b701))
* disable only save button, not the entire form ([349e4d7](349e4d7))
* don't copy value of "Is Standard" ([205ec4e](205ec4e))
* dont rename link fields in Virtual doctypes ([#23294](#23294)) ([99a3b4d](99a3b4d))
* email linking (backport [#23224](#23224)) ([#23226](#23226)) ([a02adef](a02adef))
* **email:** Allow users to pull all (read & unread) emails during initial sync ([a48fd81](a48fd81))
* **event/sync_communication:** add `distinct` while querying communication links ([1eb0f7e](1eb0f7e))
* Font for arabic and not supported languages ([#23234](#23234)) ([#23326](#23326)) ([f99b9d4](f99b9d4))
* Form Builder / Workflow Builder fixes (backport [#23238](#23238)) ([#23244](#23244)) ([c0ca3a8](c0ca3a8))
* honour max file size in upload file ([e63de38](e63de38))
* Ignore `None` returned by RQ job ([aeab15b](aeab15b))
* ignore case of filetype ([5bc6d1f](5bc6d1f))
* ignore invalid token so auth hooks can apply ([23e1a48](23e1a48))
* incorrect date range when relinking files ([#23197](#23197)) ([ab78bef](ab78bef))
* increase length for address lines ([2e126b6](2e126b6))
* **minor:** mobile menu & sidebar attachment text ([#23013](#23013)) ([#23014](#23014)) ([cd14e2a](cd14e2a))
* **minor:** web and timeline styles ([#23083](#23083)) ([c752ae5](c752ae5))
* move field description to doctype definition ([68f3748](68f3748))
* not able to edit private workspace (backport [#23241](#23241)) ([#23245](#23245)) ([f8eb101](f8eb101))
* remove link - modifying while iterating ([d5105ed](d5105ed))
* remove quotes from IMAP Folder Name ([#23242](#23242)) ([#23325](#23325)) ([9089f29](9089f29))
* removed unsed code from Column.vue ([406e0a5](406e0a5))
* review points when added more then once. ([#23239](#23239)) ([#23344](#23344)) ([11eb9a8](11eb9a8))
* send correct username in userinfo ([#23177](#23177)) ([#23178](#23178)) ([8c61435](8c61435))
* test docstatus change from workflow ([6e7aa5e](6e7aa5e))
* Update email_message in the send_welcome_email function to use the use_html check for Email Template ([78559be](78559be))
* web_form_list.js  invalid condition_json  ([2804192](2804192))
* **web_form:** check properties for title field as well ([64eda83](64eda83))
* **WebForm:** Add missing keyboard.js dep for some controls ([2fd07ee](2fd07ee))
* **WebForm:** Replace `get_cached_value` with `get_value` ([8989289](8989289))
* **web:** Send first_day_of_the_week and number_format in bootinfo ([a6308c3](a6308c3))
* **workflow:** avoid implicit docstatus altering ([c3a1912](c3a1912))
* workspace loading issue ([#23179](#23179)) ([e06f128](e06f128))

### Features

* Enabling Redirection to a Custom URL on Notification Click (backport [#22956](#22956)) ([#23318](#23318)) ([b52fac5](b52fac5))
* workflow state wise status override (backport [#23207](#23207)) ([#23315](#23315)) ([a8fab7b](a8fab7b))

### Reverts

* code control loosing focus when edit (for now reverting need better fix) ([8dfe6a7](8dfe6a7))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-15-hotfix Backport the PR to v15
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User without Workspace Manager role can't edit private workspace
1 participant