Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DX): PEP517 compatible build in new apps (backport #21704) #23776

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 13, 2023

This is an automatic backport of pull request #21704 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* chore: remove setup.py requirements.txt boilerplate

* feat(DX): PEP517 compatible builds on new apps

closes #21612

(cherry picked from commit 8436f77)

# Conflicts:
#	frappe/utils/boilerplate.py
@mergify mergify bot requested a review from a team December 13, 2023 15:40
@mergify mergify bot added the conflicts label Dec 13, 2023
@mergify mergify bot requested review from shariquerik and removed request for a team December 13, 2023 15:40
@mergify mergify bot assigned ankush Dec 13, 2023
@barredterra
Copy link
Collaborator

barredterra commented Dec 13, 2023

I've successfully tested the commands new-app, install-app, uninstall-app and remove-app with this PR.

@ankush
Copy link
Member

ankush commented Dec 13, 2023

This just affects new-app, so should be fine IMO. It's just a boilerplate generation utility.

@ankush ankush merged commit 9daefb6 into version-14-hotfix Dec 13, 2023
9 of 10 checks passed
@ankush ankush deleted the mergify/bp/version-14-hotfix/pr-21704 branch December 13, 2023 17:56
@ankush
Copy link
Member

ankush commented Dec 13, 2023

Fwiw I never port developer facing changes because I kinda assume most devs run development branch. I guess that isn't the case outside of Frappe.

@barredterra
Copy link
Collaborator

For erpnext customisations, we usually target the stable version in use by the customer.

frappe-pr-bot pushed a commit that referenced this pull request Dec 18, 2023
# [14.60.0](v14.59.0...v14.60.0) (2023-12-18)

### Bug Fixes

* cast SQL booleans to python ([2c3859f](2c3859f))
* consider height istead of width ([ebd4b4a](ebd4b4a))
* Consider user and sender both for "system user" ([#23806](#23806)) ([#23809](#23809)) ([162c10f](162c10f))
* **jinja:** Update error message in validate_template function ([#23783](#23783)) ([#23795](#23795)) ([557cb45](557cb45))
* load 100 records for larger screen ([2b8bf8c](2b8bf8c))
* remove web_form rate limit key ([#23767](#23767)) ([#23768](#23768)) ([56f5d0e](56f5d0e))
* skip using frm object for routing to audit trail ([#23603](#23603)) ([#23779](#23779)) ([b0d6f94](b0d6f94))

### Features

* `describe-database-table` to get stats about a table (backport [#23813](#23813)) ([#23814](#23814)) ([1e8edb4](1e8edb4))
* **DX:** PEP517 compatible build in new apps (backport [#21704](#21704)) ([#23776](#23776)) ([9daefb6](9daefb6))

### Performance Improvements

* **migrate:** Only re-evaluate users which are potentially changed ([#23820](#23820)) ([#23822](#23822)) ([3c0aea5](3c0aea5))
* **migrate:** update only affected users via role profile ([#23821](#23821)) ([#23824](#23824)) ([ae0fc07](ae0fc07))
* Primary key is never nullable (backport [#23788](#23788)) ([#23789](#23789)) ([e1b49c9](e1b49c9))
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 14.60.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants