Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pip effectively deprecated use of setuptools (in read-only directories) #21612

Closed
blaggacao opened this issue Jul 9, 2023 · 1 comment · Fixed by #21704
Closed

pip effectively deprecated use of setuptools (in read-only directories) #21612

blaggacao opened this issue Jul 9, 2023 · 1 comment · Fixed by #21704
Assignees
@ankush

Comments

@blaggacao
Copy link
Contributor

blaggacao commented Jul 9, 2023 •
edited

frappe/frappe/utils/boilerplate.py

Lines 135 to 136 in cb156b6

with open(os.path.join(dest, hooks.app_name, "setup.py"), "w") as f:
f.write(frappe.as_unicode(setup_template.format(**hooks)))

Since the workarround has been removed there is no more work around.

Solution: move to flit (as in frappe proper)

Impact:

Community modules can't be built from read-only sources, throwing the following error:

Jul 08 20:53:21 roble pristina-setup-start[61771]:   error: subprocess-exited-with-error
Jul 08 20:53:21 roble pristina-setup-start[61771]:
Jul 08 20:53:21 roble pristina-setup-start[61771]:   × python setup.py bdist_wheel did not run successfully.
Jul 08 20:53:21 roble pristina-setup-start[61771]:   │ exit code: 1
Jul 08 20:53:21 roble pristina-setup-start[61771]:   ╰─> [5 lines of output]
Jul 08 20:53:21 roble pristina-setup-start[61771]:       running bdist_wheel
Jul 08 20:53:21 roble pristina-setup-start[61771]:       running build
Jul 08 20:53:21 roble pristina-setup-start[61771]:       running build_py
Jul 08 20:53:21 roble pristina-setup-start[61771]:       creating build
Jul 08 20:53:21 roble pristina-setup-start[61771]:       error: could not create 'build': Read-only file system
Jul 08 20:53:21 roble pristina-setup-start[61771]:       [end of output]
@blaggacao blaggacao changed the title pip deprecated use of setuptools (in read-only directories) pip effectively deprecated use of setuptools (in read-only directories) Jul 9, 2023
This was referenced Jul 9, 2023
Closed
Closed
Closed
@ankush ankush self-assigned this Jul 17, 2023
@ankush
Copy link
Member

ankush commented Jul 17, 2023

We can use remove setup.py and stick to pyproject.toml for new apps.

Existing apps will have to upgrade on their own.

@ankush ankush mentioned this issue Jul 17, 2023
Merged
ankush added a commit to ankush/frappe that referenced this issue Jul 17, 2023
@ankush
feat(DX): PEP517 compatible builds on new apps
0e48357 
closes frappe#21612
ankush added a commit that referenced this issue Jul 17, 2023
@ankush
feat(DX): PEP517 compatible build in new apps (#21704)
8436f77 
* chore: remove setup.py requirements.txt boilerplate

* feat(DX): PEP517 compatible builds on new apps

closes #21612
pateljannat pushed a commit to pateljannat/frappe that referenced this issue Jul 31, 2023
@ankush @pateljannat
feat(DX): PEP517 compatible build in new apps (frappe#21704)
4ef8119 
* chore: remove setup.py requirements.txt boilerplate

* feat(DX): PEP517 compatible builds on new apps

closes frappe#21612
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2023
mergify bot pushed a commit that referenced this issue Dec 13, 2023
@ankush @mergify
feat(DX): PEP517 compatible build in new apps (#21704)
8df62eb 
* chore: remove setup.py requirements.txt boilerplate

* feat(DX): PEP517 compatible builds on new apps

closes #21612

(cherry picked from commit 8436f77)

# Conflicts:
#	frappe/utils/boilerplate.py
ankush added a commit that referenced this issue Dec 13, 2023
@mergify @ankush @barredterra
feat(DX): PEP517 compatible build in new apps (backport #21704) (#23776)
9daefb6 
* feat(DX): PEP517 compatible build in new apps (#21704)

* chore: remove setup.py requirements.txt boilerplate

* feat(DX): PEP517 compatible builds on new apps

closes #21612

(cherry picked from commit 8436f77)

# Conflicts:
#	frappe/utils/boilerplate.py

* chore: resolve conflicts

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
Co-authored-by: barredterra <14891507+barredterra@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ankush ankush

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(DX): PEP517 compatible build in new apps ankush/frappe
2 participants
@blaggacao @ankush