Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DX): PEP517 compatible build in new apps #21704

Merged
merged 2 commits into from
Jul 17, 2023
Merged

Conversation

ankush
Copy link
Member

@ankush ankush commented Jul 17, 2023

closes #21612

PIP will overtime move away from setup.py installs completely, so if you maintain Frappe app it's wise to add pyproject.toml file. Copy Frappe's and modify values if you're unsure how to do it.

frappe/pyproject.toml

Lines 1 to 87 in e38078a

[project]
name = "frappe"
authors = [
{ name = "Frappe Technologies Pvt Ltd", email = "developers@frappe.io"}
]
description = "Metadata driven, full-stack low code web framework"
requires-python = ">=3.10"
readme = "README.md"
dynamic = ["version"]
dependencies = [
# core dependencies
"Babel~=2.12.1",
"Click~=8.1.3",
"filelock~=3.8.0",
"filetype~=1.2.0",
"GitPython~=3.1.31",
"Jinja2~=3.1.2",
"Pillow~=9.5.0",
"PyJWT~=2.7.0",
"PyMySQL==1.0.3",
"pypdf~=3.9.1",
"PyPika~=0.48.9",
"PyQRCode~=1.2.1",
"PyYAML~=6.0",
"RestrictedPython~=6.0",
"WeasyPrint==59.0",
"Werkzeug~=2.3.4",
"Whoosh~=2.7.4",
"beautifulsoup4~=4.12.2",
"bleach-allowlist~=1.0.3",
"bleach~=3.3.0",
"cairocffi==1.5.1",
"chardet~=5.1.0",
"croniter~=1.3.15",
"cryptography~=41.0.1",
"email-reply-parser~=0.5.12",
"git-url-parse~=1.2.2",
"gunicorn~=20.1.0",
"html5lib~=1.1",
"ipython~=8.10.0",
"ldap3~=2.9",
"markdown2~=2.4.8",
"MarkupSafe>=2.1.0,<3",
"maxminddb-geolite2==2018.703",
"num2words~=0.5.12",
"oauthlib~=3.2.2",
"openpyxl~=3.1.2",
"passlib~=1.7.4",
"pdfkit~=1.0.0",
"phonenumbers==8.13.13",
"premailer~=3.8.0",
"psutil~=5.9.5",
"psycopg2-binary~=2.9.1",
"pyOpenSSL~=23.2.0",
"pycryptodome~=3.18.0",
"pydantic==2.0",
"pyotp~=2.8.0",
"python-dateutil~=2.8.2",
"pytz==2023.3",
"rauth~=0.7.3",
"redis~=4.5.5",
"hiredis~=2.2.3",
"requests-oauthlib~=1.3.1",
"requests~=2.31.0",
"rq~=1.15.1",
"rsa>=4.1",
"semantic-version~=2.10.0",
"sqlparse~=0.4.4",
"tenacity~=8.2.2",
"terminaltables~=3.1.10",
"traceback-with-variables~=2.0.4",
"xlrd~=2.0.1",
"zxcvbn~=4.4.28",
"markdownify~=0.11.6",
# integration dependencies
"boto3~=1.18.49",
"dropbox~=11.36.0",
"google-api-python-client~=2.2.0",
"google-auth-oauthlib~=0.4.4",
"google-auth~=1.29.0",
"posthog~=3.0.1",
]
[build-system]
requires = ["flit_core >=3.4,<4"]
build-backend = "flit_core.buildapi"

ref:

docs: https://frappeframework.com/docs/v14/user/en/tutorial/create-an-app

@ankush ankush requested review from a team and shariquerik and removed request for a team July 17, 2023 07:09
@ankush ankush added the squash label Jul 17, 2023
@ankush ankush changed the title feat(DX): PIP517 compatible build in new apps feat(DX): PEP517 compatible build in new apps Jul 17, 2023
@ankush ankush merged commit 8436f77 into frappe:develop Jul 17, 2023
1 check passed
@ankush ankush deleted the flit branch July 17, 2023 07:26
pateljannat pushed a commit to pateljannat/frappe that referenced this pull request Jul 31, 2023
* chore: remove setup.py requirements.txt boilerplate

* feat(DX): PEP517 compatible builds on new apps

closes frappe#21612
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2023
@barredterra barredterra added the backport version-14-hotfix backport to version 14 label Dec 13, 2023
@barredterra
Copy link
Collaborator

barredterra commented Dec 13, 2023

New apps created with/for v14 don't get a pyproject.toml yet, which can cause issues already. Hence, I suggest backporting this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pip effectively deprecated use of setuptools (in read-only directories)
2 participants