Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter Implementation is set operator (backport #25182) #25195

Merged
merged 2 commits into from Mar 2, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 2, 2024

This is an automatic backport of pull request #25182 done by Mergify.
Cherry-pick of eff50e1 has failed:

On branch mergify/bp/version-15-hotfix/pr-25182
Your branch is up to date with 'origin/version-15-hotfix'.

You are currently cherry-picking commit eff50e1cd3.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   frappe/utils/data.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   frappe/tests/test_utils.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* Implementation is set operator. fix issue #25180

* Refactored filtrer operator `is`,
Add tests

* fix: Correct implementation for `is set`

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
(cherry picked from commit eff50e1)

# Conflicts:
#	frappe/tests/test_utils.py
@mergify mergify bot requested a review from a team as a code owner March 2, 2024 14:00
@mergify mergify bot added the conflicts label Mar 2, 2024
@mergify mergify bot requested review from akhilnarang and removed request for a team March 2, 2024 14:00
Copy link
Contributor Author

mergify bot commented Mar 2, 2024

Cherry-pick of eff50e1 has failed:

On branch mergify/bp/version-15-hotfix/pr-25182
Your branch is up to date with 'origin/version-15-hotfix'.

You are currently cherry-picking commit eff50e1cd3.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   frappe/utils/data.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   frappe/tests/test_utils.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@ankush ankush enabled auto-merge (squash) March 2, 2024 14:14
@ankush ankush merged commit 20a7879 into version-15-hotfix Mar 2, 2024
17 checks passed
@ankush ankush deleted the mergify/bp/version-15-hotfix/pr-25182 branch March 2, 2024 14:29
frappe-pr-bot pushed a commit that referenced this pull request Mar 5, 2024
# [15.17.0](v15.16.1...v15.17.0) (2024-03-05)

### Bug Fixes

* add "If Owner" column to roles viewer ([#25218](#25218)) ([#25220](#25220)) ([adf6a2a](adf6a2a))
* always show is_standard on web form ([#25144](#25144)) ([#25148](#25148)) ([196483b](196483b))
* better error message ([b94e978](b94e978))
* dont translate numbers ([#25208](#25208)) ([#25210](#25210)) ([c659eca](c659eca))
* escalate print failures ([a987c2d](a987c2d))
* escape single quotes ([#25104](#25104)) ([#25154](#25154)) ([adb7e38](adb7e38)), closes [/github.com//pull/25078#discussion_r1504084483](https://github.com//github.com/frappe/frappe/pull/25078/issues/discussion_r1504084483)
* Export `None` as type if select as no options ([#25211](#25211)) ([#25212](#25212)) ([79a8afd](79a8afd))
* filter Implementation is set operator ([#25182](#25182)) ([#25195](#25195)) ([20a7879](20a7879)), closes [#25180](#25180)
* No need to sort keys while saving JSON to DB ([#25205](#25205)) ([#25206](#25206)) ([a471499](a471499))
* Only validate fetch from when user modifies it ([72da497](72da497))
* race condition on deletes (backport [#25170](#25170)) ([#25171](#25171)) ([1657d55](1657d55))
* **search:** Don't break when query doesn't return title ([#25168](#25168)) ([#25197](#25197)) ([3dafbf9](3dafbf9))
* **setup_module_map:** fix caching ([338c895](338c895))
* specify print_language in communication attachments ([4e53b12](4e53b12))
* task_id parameter for publish_progress ([30a2f27](30a2f27))
* update file attached_to details in submitted doc ([#25141](#25141)) ([73f1a73](73f1a73))
* Use current language in attachment prints ([ea4c11b](ea4c11b))
* use name for RQ worker instead of PID ([#25175](#25175)) ([#25177](#25177)) ([7264734](7264734))
* **UX:** correctly disable standard web form form ([#25143](#25143)) ([2d907e7](2d907e7))
* **UX:** list filter take zero as null ([#25156](#25156)) ([#25222](#25222)) ([963ff89](963ff89))
* **UX:** reload form after renaming field ([#25159](#25159)) ([#25161](#25161)) ([7754e4a](7754e4a))
* **UX:** set default print language from print format ([c11f140](c11f140))

### Features

* Add doc rename hook in server script ([#25085](#25085)) ([#25110](#25110)) ([b729c03](b729c03))
* let users unlock stuck documents (backport [#24782](#24782)) ([#25225](#25225)) ([b0db641](b0db641))
* task_id for submit_cancel_or_update_docs ([bf8d102](bf8d102))
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 15.17.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants