fix: reserved keywords as col name in dynamic link checks #25718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
add-test-cases
ankush
added
backport version-14-hotfix
ankush
changed the title
mergify bot
pushed a commit
that referenced
this pull request
Mar 29, 2024
(cherry picked from commit 87ffe25)
mergify bot
pushed a commit
that referenced
this pull request
Mar 29, 2024
(cherry picked from commit 87ffe25)
This was referenced Mar 29, 2024
ankush
added a commit
that referenced
this pull request
Mar 29, 2024
ankush
added a commit
that referenced
this pull request
Mar 29, 2024
frappe-pr-bot
pushed a commit
that referenced
this pull request
Apr 2, 2024
# [14.70.0](v14.69.0...v14.70.0) (2024-04-02) ### Bug Fixes * advertise insights to system manager only ([9ad5e58](9ad5e58)) * incorrect status on data import (backport [#25660](#25660)) ([#25702](#25702)) ([2b35e4b](2b35e4b)) * incorrect UI icon for desc sort ([#25687](#25687)) ([#25688](#25688)) ([8042ef8](8042ef8)) * invalid filter on email acccount ([#25674](#25674)) ([#25675](#25675)) ([ca5daed](ca5daed)) * make ads translatable ([#25710](#25710)) ([53d28ad](53d28ad)) * make insights ad translatable ([85e5f2f](85e5f2f)) * Merge conflicts ([4e7dd03](4e7dd03)) * non-html notifications from files ([2aa939a](2aa939a)) * preserve original error message ([#25682](#25682)) ([#25684](#25684)) ([0737e84](0737e84)) * **query_report:** don't crash if undefined ([8f2408d](8f2408d)), closes [#25562](#25562) * reserved keywords as col name ([#25718](#25718)) ([#25725](#25725)) ([7a99b75](7a99b75)) * translatable web footer ([7558acf](7558acf)) * Use CssParser to correctly pass options to wkhtmltopdf ([fa1f3fc](fa1f3fc)) * Use doctype setting to set auto-extracted file as private ([e939391](e939391)) * Use regex in failing test ([3d7e572](3d7e572)) ### Features * **customize_form:** allow setting `creation` as a default sort field ([#25760](#25760)) ([2b7bb06](2b7bb06)) * **notification:** specify message type (html, md, txt) ([fe6cbdd](fe6cbdd))
frappe-pr-bot
pushed a commit
that referenced
this pull request
Apr 2, 2024
# [15.20.0](v15.19.1...v15.20.0) (2024-04-02) ### Bug Fixes * advertise insights to system manager only ([7046320](7046320)) * cint -> avoid precision loss if already integer ([#25735](#25735)) ([#25737](#25737)) ([6c822e0](6c822e0)) * **enqueue:** pass the original method argument here ([#25722](#25722)) ([2c14450](2c14450)), closes [/github.com/frappe/frappe/blob/87d121f47a4afc507442a97bf1854bb3d17f42c6/frappe/email/doctype/email_queue/email_queue.py#L735-L736](https://github.com//github.com/frappe/frappe/blob/87d121f47a4afc507442a97bf1854bb3d17f42c6/frappe/email/doctype/email_queue/email_queue.py/issues/L735-L736) * **event:** clear message after handling exception ([eb9e88e](eb9e88e)) * fieldname extraction (backport [#24411](#24411)) ([#25670](#25670)) ([ed4e1b3](ed4e1b3)), closes [#22892](#22892) * incorrect status on data import (backport [#25660](#25660)) ([#25703](#25703)) ([0165c75](0165c75)) * incorrect UI icon for desc sort ([#25687](#25687)) ([#25689](#25689)) ([f7f2849](f7f2849)) * invalid filter on email acccount ([#25674](#25674)) ([#25676](#25676)) ([c15b47a](c15b47a)) * let's colored tags in listview ([#25552](#25552)) ([4e17959](4e17959)) * make ads translatable ([217ef0b](217ef0b)) * make insights ad translatable ([43e6734](43e6734)) * message update in custom app if is_standard ([#25754](#25754)) ([86ad2e6](86ad2e6)) * non-html notifications from files ([a35e9ba](a35e9ba)) * preserve original error message ([#25682](#25682)) ([#25685](#25685)) ([3d364b7](3d364b7)) * reserved keywords as col name ([#25718](#25718)) ([#25726](#25726)) ([fca1c1a](fca1c1a)) * **restore:** check backup directory and bench directory if we can't find the file ([e6e4258](e6e4258)) * translatable web footer ([99bbd94](99bbd94)) * Use CssParser to correctly pass options to wkhtmltopdf ([e9811ea](e9811ea)) * Use doctype setting to set auto-extracted file as private (backport [#24828](#24828)) ([#25673](#25673)) ([14ccbe7](14ccbe7)) ### Features * allow skipping msgprint ([59813db](59813db)), closes [/github.com/frappe/frappe/blob/version-15/frappe/desk/doctype/event/event.py#L398](https://github.com//github.com/frappe/frappe/blob/version-15/frappe/desk/doctype/event/event.py/issues/L398) * **customize_form:** allow setting `creation` as a default sort field ([#25760](#25760)) ([d540c72](d540c72)) * **notification:** specify message type (html, md, txt) ([e9a8a14](e9a8a14)) ### Reverts * Revert "fix: message update in custom app if is_standard (#25754)" (#25767) ([f5a17f7](f5a17f7)), closes [#25754](#25754) [#25767](#25767)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If fieldname is
orderthen this doesn't work. Wrapped in grave quotes to avoid this.