fix: Use doctype setting to set auto-extracted file as private

[marination]

• Use make_attachments_public to determine the file privacy while auto creating files from the text editor field
  

  

• Currently, all files in the text editor field are automatically public and there is no way to control this behaviour except manually setting the file as private each time.

[ankush]

TODO:

• test communication crafted using this
• test pdf crafted using this

[marination]

@ankush not sure how to handle test pdf crafted using this, i can't seem to get content out of pdfreader's pages. Would be nice if you could handle this one.

[ankush]

@marination this doesn't work afaik

We use cookies from current request and pass it to wkhtml so it can read private images. However when it's done from background jobs it's not possible.

frappe/frappe/utils/pdf.py

Lines 179 to 193 in 4e1ed29

	def get_cookie_options():
	options = {}
	if frappe.session and frappe.session.sid and hasattr(frappe.local, "request"):
	# Use wkhtmltopdf's cookie-jar feature to set cookies and restrict them to host domain
	cookiejar = f"/tmp/{frappe.generate_hash()}.jar"
	# Remove port from request.host
	# https://werkzeug.palletsprojects.com/en/0.16.x/wrappers/#werkzeug.wrappers.BaseRequest.host
	domain = frappe.utils.get_host_name().split(":", 1)[0]
	with open(cookiejar, "w") as f:
	f.write(f"sid={frappe.session.sid}; Domain={domain};\n")
	options["cookie-jar"] = cookiejar
	return options

---

Possible fix that we have discussed before:

• For communication: send images as inline attachments with some sane max size limit (~5mb)
• For PDFs - send images as base64 encoded source to wkhtml so private file isn't a problem.

Both are long pending design flaws, will have get it fixed somehow to make this work 😔

[ankush]

update: working on base64-ing private images rn. Once we have this it's easier to port this change without breaking anything.

#24980

[ankush]

the world of email is 💩

https://sendgrid.com/blog/embedding-images-emails-facts/

[barredterra]

How about this approach:

• All images dropped in Text Editor are stored as private files
• Images contained in an email are made available publicly, but non-enumerable (fix: dont allow querying files to website users #25094) and under a non-guessable URL (say, 64 character hash)

This way we stay close to the current implementation but get fairly good security.