Creation of unnecessary __init__.py files

[Saboti215]

Description of the issue

I am using multiple self created pages inside my application. Since version 14, I encountered some issues with the automatic creation of __init__.py files in the pages directory. Each of my pages have multiple sub-directories to manage the files. One example page looks like this:

dashboard/
├── admin_card.js
├── config
│   ├── defaults.js
│   └── __init__.py        <-- not needed
├── dashboard.js
├── dashboard_widget.js
├── index.html
├── index.js
├── index.py
├── __init__.py
├── interface
│   ├── dashboard.py
│   └── __init__.py        <-- maybe not needed
└── styles
    ├── index.scss
    └── __init__.py        <-- not needed

But during bench migrate, frappe will automatically create __init__.py files in all of my sub directories. Since the init files are only needed for python modules, I want to get rid of them everywhere else.

Context information (for bug reports)

Output of bench version

erpnext 14.63.1
frappe 14.66.2

Steps to reproduce the issue

1. Create a new page with multiple sub directories
2. bench migrate
3. __init__.py files will be generated in each sub directory.

Observed result

__init__.py files are generated in every sub directoy.

Expected result

__init__.py files should only be generated on the top-level directory of the page.

Stacktrace / full error message

/

Additional information

I think the issue is caused by the function get_pages_from_path in router.py. My suggestion is to just create the init-file inside the top-level directory. It could be easier to move this functionality out of the function get_pages_from_path, since regarding it's name it should only get the pages without creating anything.

[frappe-pr-bot]

🎉 This issue has been resolved in version 15.24.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[frappe-pr-bot]

🎉 This issue has been resolved in version 14.73.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀