Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Increase folder link field size (backport #26381) #26383

Merged
merged 3 commits into from
May 9, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 9, 2024

File name is 255 because it's bootstrapped using mariadb.sql, so users
can create 255 char long folders but can't store anything in it.


This is an automatic backport of pull request #26381 done by Mergify.

* fix: increase folder length to 255

File `name` is 255 because it's bootstrapped using mariadb.sql, so users
can create 255 char long folders but can't store anything in it.

* fix(UX): slightly better character len message

Highlight field by making it bold.

(cherry picked from commit 5351763)

# Conflicts:
#	frappe/core/doctype/file/file.json
#	frappe/model/base_document.py
@mergify mergify bot added the conflicts label May 9, 2024
@mergify mergify bot requested review from a team and ankush and removed request for a team May 9, 2024 06:41
@mergify mergify bot assigned ankush May 9, 2024
Copy link
Contributor Author

mergify bot commented May 9, 2024

Cherry-pick of 5351763 has failed:

On branch mergify/bp/version-14-hotfix/pr-26381
Your branch is up to date with 'origin/version-14-hotfix'.

You are currently cherry-picking commit 53517630ae.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   frappe/core/doctype/file/file.json
	both modified:   frappe/model/base_document.py

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@ankush ankush enabled auto-merge (squash) May 9, 2024 06:42
@ankush ankush added the Skip CI Doesn't run Ci for this PR. label May 9, 2024
@ankush ankush merged commit 30db235 into version-14-hotfix May 9, 2024
8 of 11 checks passed
@ankush ankush deleted the mergify/bp/version-14-hotfix/pr-26381 branch May 9, 2024 07:22
frappe-pr-bot pushed a commit that referenced this pull request May 14, 2024
## [14.74.1](v14.74.0...v14.74.1) (2024-05-14)

### Bug Fixes

* allow navigating to `Table MultiSelect` fields using tab ([1e5faff](1e5faff))
* **document_follow:** `following` was treated as a string not a boolean ([bdc48ad](bdc48ad))
* german translations ([#26370](#26370)) ([167e4e6](167e4e6))
* Increase folder link field size ([#26381](#26381)) ([#26383](#26383)) ([30db235](30db235))
* **integrations:** add back `response.raise_for_status()` ([dcf191c](dcf191c))
* make rename_doc work pre_model_sync ([#26419](#26419)) ([0d631ce](0d631ce))
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 14.74.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
conflicts released Skip CI Doesn't run Ci for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants