feat(recorder): Suggest index for optimizing query #26433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Query is most important yet it was only taking 2 cols, unreadable.
This reverts commit eadfe86fd834f43925956fa6d759127aaf363441.
ankush
requested review from
a team and
akhilnarang
and removed request for
a team
github-actions
bot
added
the
add-test-cases
ankush
force-pushed
the
query_optimzier
branch
2 times, most recently
from
8783cf3
to
8527b92
Compare
ankush
added
backport version-15-hotfix
ankush
added a commit
that referenced
this pull request
May 16, 2024
…26435) * fix(DX): fix up column widths in recorder grid Query is most important yet it was only taking 2 cols, unreadable. (cherry picked from commit aba8d4e) # Conflicts: # frappe/core/doctype/recorder_query/recorder_query.json * fix: Avoid erasing recorder during clear_cache This reverts commit eadfe86fd834f43925956fa6d759127aaf363441. (cherry picked from commit 16c8a30) * fix(UX): colour duration to highlight bad rows (cherry picked from commit 49f8f4f) * feat(recorder): Suggest query index (cherry picked from commit 4e251e9) # Conflicts: # frappe/core/doctype/recorder/recorder.py * feat: Add identified index from UI (cherry picked from commit b169f87) # Conflicts: # frappe/commands/site.py --------- Co-authored-by: Ankush Menat <ankush@frappe.io>
frappe-pr-bot
pushed a commit
that referenced
this pull request
May 22, 2024
# [15.28.0](v15.27.0...v15.28.0) (2024-05-22) ### Bug Fixes * "Not assigned" filter ([#26468](#26468)) ([#26470](#26470)) ([ee6545b](ee6545b)) * compute modal title server side ([#26192](#26192)) ([3b787ac](3b787ac)) * condition of event participants ([#26300](#26300)) ([#26456](#26456)) ([31be0b9](31be0b9)) * default tree view ([07883a7](07883a7)) * Don't fiddle with child table indexes ([#26450](#26450)) ([#26453](#26453)) ([7e0d734](7e0d734)) * **DX:** Don't run CI if there are no tests (backport [#26457](#26457)) ([#26466](#26466)) ([72c693e](72c693e)) * enable fetch_from for Time fieldtype ([#25266](#25266)) ([#26471](#26471)) ([#26483](#26483)) ([f1267ca](f1267ca)) * **grid_row:** don't crash when undefined ([116ba1c](116ba1c)) * preserve checked items after a search ([befcce1](befcce1)) ### Features * **recorder:** Suggest index for optimizing query (backport [#26433](#26433)) ([#26435](#26435)) ([4b780cd](4b780cd)) ### Performance Improvements * num2words, babel, gettext, sentry imports ([#26475](#26475)) ([#26477](#26477)) ([e79e5f9](e79e5f9))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recorder can now suggest indexes that might help speed up a particular recording.
As of now this is based on simple heuristics that developers also follow:
This works like 80% of the time where problem is a missing index. Hire experts for other 20% 😄
docs https://frappeframework.com/docs/user/en/profiling#query-optimization-using-recorder