-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(recorder): Suggest index for optimizing query (backport #26433) #26435
feat(recorder): Suggest index for optimizing query (backport #26433) #26435
Conversation
Query is most important yet it was only taking 2 cols, unreadable. (cherry picked from commit aba8d4e) # Conflicts: # frappe/core/doctype/recorder_query/recorder_query.json
This reverts commit eadfe86fd834f43925956fa6d759127aaf363441. (cherry picked from commit 16c8a30)
(cherry picked from commit 49f8f4f)
(cherry picked from commit 4e251e9) # Conflicts: # frappe/core/doctype/recorder/recorder.py
(cherry picked from commit b169f87) # Conflicts: # frappe/commands/site.py
Cherry-pick of aba8d4e has failed:
Cherry-pick of 4e251e9 has failed:
Cherry-pick of b169f87 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
# [15.28.0](v15.27.0...v15.28.0) (2024-05-22) ### Bug Fixes * "Not assigned" filter ([#26468](#26468)) ([#26470](#26470)) ([ee6545b](ee6545b)) * compute modal title server side ([#26192](#26192)) ([3b787ac](3b787ac)) * condition of event participants ([#26300](#26300)) ([#26456](#26456)) ([31be0b9](31be0b9)) * default tree view ([07883a7](07883a7)) * Don't fiddle with child table indexes ([#26450](#26450)) ([#26453](#26453)) ([7e0d734](7e0d734)) * **DX:** Don't run CI if there are no tests (backport [#26457](#26457)) ([#26466](#26466)) ([72c693e](72c693e)) * enable fetch_from for Time fieldtype ([#25266](#25266)) ([#26471](#26471)) ([#26483](#26483)) ([f1267ca](f1267ca)) * **grid_row:** don't crash when undefined ([116ba1c](116ba1c)) * preserve checked items after a search ([befcce1](befcce1)) ### Features * **recorder:** Suggest index for optimizing query (backport [#26433](#26433)) ([#26435](#26435)) ([4b780cd](4b780cd)) ### Performance Improvements * num2words, babel, gettext, sentry imports ([#26475](#26475)) ([#26477](#26477)) ([e79e5f9](e79e5f9))
馃帀 This PR is included in version 15.28.0 馃帀 The release is available on GitHub release Your semantic-release bot 馃摝馃殌 |
Recorder can now suggest indexes that might help speed up a particular recording.
As of now this is based on simple heuristics that developers also follow:
Works like 80% of the time where problem is a missing index. Hire experts for other use cases 馃槃
docs https://frappeframework.com/docs/user/en/profiling#query-optimization-using-recorder
This is an automatic backport of pull request #26433 done by Mergify.