Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't fiddle with child table indexes #26450

Merged
merged 1 commit into from
May 16, 2024
Merged

Conversation

ankush
Copy link
Member

@ankush ankush commented May 16, 2024

  • Link fields when referred to increase idx
  • This is used in search.py to rank most referred documents higher than
  • This doesn't make for child table links at all.

@ankush ankush added backport version-14-hotfix backport to version 14 backport version-15-hotfix Backport the PR to v15 labels May 16, 2024
@github-actions github-actions bot added the add-test-cases Add test case to validate fix or enhancement label May 16, 2024
- Link fields when referred to increase idx
- This is used in search.py to rank most referred documents higher than
- This doesn't make for child table links at all.
@ankush ankush merged commit 803f7b3 into frappe:develop May 16, 2024
23 checks passed
@ankush ankush deleted the idx_mess branch May 16, 2024 11:39
mergify bot pushed a commit that referenced this pull request May 16, 2024
- Link fields when referred to increase idx
- This is used in search.py to rank most referred documents higher than
- This doesn't make for child table links at all.

(cherry picked from commit 803f7b3)
mergify bot pushed a commit that referenced this pull request May 16, 2024
- Link fields when referred to increase idx
- This is used in search.py to rank most referred documents higher than
- This doesn't make for child table links at all.

(cherry picked from commit 803f7b3)
ankush added a commit that referenced this pull request May 16, 2024
- Link fields when referred to increase idx
- This is used in search.py to rank most referred documents higher than
- This doesn't make for child table links at all.

(cherry picked from commit 803f7b3)

Co-authored-by: Ankush Menat <ankush@frappe.io>
ankush added a commit that referenced this pull request May 16, 2024
- Link fields when referred to increase idx
- This is used in search.py to rank most referred documents higher than
- This doesn't make for child table links at all.

(cherry picked from commit 803f7b3)

Co-authored-by: Ankush Menat <ankush@frappe.io>
frappe-pr-bot pushed a commit that referenced this pull request May 22, 2024
# [15.28.0](v15.27.0...v15.28.0) (2024-05-22)

### Bug Fixes

* "Not assigned" filter ([#26468](#26468)) ([#26470](#26470)) ([ee6545b](ee6545b))
* compute modal title server side ([#26192](#26192)) ([3b787ac](3b787ac))
* condition of event participants ([#26300](#26300)) ([#26456](#26456)) ([31be0b9](31be0b9))
* default tree view ([07883a7](07883a7))
* Don't fiddle with child table indexes ([#26450](#26450)) ([#26453](#26453)) ([7e0d734](7e0d734))
* **DX:** Don't run CI if there are no tests (backport [#26457](#26457)) ([#26466](#26466)) ([72c693e](72c693e))
* enable fetch_from for Time fieldtype ([#25266](#25266)) ([#26471](#26471)) ([#26483](#26483)) ([f1267ca](f1267ca))
* **grid_row:** don't crash when undefined ([116ba1c](116ba1c))
* preserve checked items after a search ([befcce1](befcce1))

### Features

* **recorder:** Suggest index for optimizing query (backport [#26433](#26433)) ([#26435](#26435)) ([4b780cd](4b780cd))

### Performance Improvements

* num2words, babel, gettext, sentry imports ([#26475](#26475)) ([#26477](#26477)) ([e79e5f9](e79e5f9))
frappe-pr-bot pushed a commit that referenced this pull request May 22, 2024
# [14.75.0](v14.74.1...v14.75.0) (2024-05-22)

### Bug Fixes

* "Not assigned" filter (backport [#26468](#26468)) ([#26469](#26469)) ([6bb3534](6bb3534))
* condition of event participants ([#26300](#26300)) ([#26455](#26455)) ([d940902](d940902))
* **contact list:** add space before designation ([a67ebab](a67ebab))
* Don't fiddle with child table indexes ([#26450](#26450)) ([#26452](#26452)) ([d0d6d93](d0d6d93))
* **DX:** Don't run CI if there are no tests (backport [#26457](#26457)) ([#26465](#26465)) ([d129c01](d129c01))
* enable fetch_from for Time fieldtype ([#25266](#25266)) ([#26471](#26471)) ([#26485](#26485)) ([9cd3bf6](9cd3bf6))
* **grid_row:** don't crash when undefined ([0f91073](0f91073))
* Ignore link doctype in comments ([#26484](#26484)) ([910d4a7](910d4a7))
* pass user and shared params when checking for cache keys ([#26402](#26402)) ([#26403](#26403)) ([30799f7](30799f7))
* preserve checked items after a search ([ae9cdd2](ae9cdd2))

### Features

* what's new (v15 port of [#21014](#21014)) (backport [#25986](#25986)) ([#26494](#26494)) ([6a561d9](6a561d9))

### Performance Improvements

* num2words, babel, gettext, sentry imports (backport [#26475](#26475)) ([#26476](#26476)) ([ea873fd](ea873fd))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
add-test-cases Add test case to validate fix or enhancement backport version-14-hotfix backport to version 14 backport version-15-hotfix Backport the PR to v15
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant