Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't automatically add system manager #26540

Merged
merged 6 commits into from
May 24, 2024

Conversation

barredterra
Copy link
Collaborator

@barredterra barredterra commented May 22, 2024

The possibility of accidentally turning an unprivileged user into a System Manager is more dangerous than useful. All sites have an Administrator who can add a missing System Manager role, if required.

@github-actions github-actions bot added the add-test-cases Add test case to validate fix or enhancement label May 22, 2024
@barredterra barredterra requested a review from ankush May 22, 2024 18:38
@ankush ankush added the defer backport Backports for some PR are deferred for a week or two to test them properly before releasing label May 24, 2024
@ankush ankush enabled auto-merge (squash) May 24, 2024 08:25
@ankush ankush merged commit 4a7de16 into frappe:develop May 24, 2024
23 checks passed
@barredterra barredterra deleted the no-auto-manager branch May 24, 2024 08:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2024
@barredterra barredterra added backport version-14-hotfix backport to version 14 backport version-15-hotfix Backport the PR to v15 and removed defer backport Backports for some PR are deferred for a week or two to test them properly before releasing add-test-cases Add test case to validate fix or enhancement labels Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14 backport version-15-hotfix Backport the PR to v15
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants