Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: kanban filters fixes (backport #26605) #26609

Merged
merged 1 commit into from
May 30, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 30, 2024

Fixes:

  1. After filtering the kanban the state.cards(previous result) is concatenated again to filtered results
  2. Remove all filters(X) button only works if there are any standard fields. Views like like kanban don't have any standard fields

no-docs


This is an automatic backport of pull request #26605 done by Mergify.

* fix(kanban): don't concat old cards after filter

- this was messing up rendering filtered cards

* fix: refresh not working without standard fields

(cherry picked from commit d09ef54)
@mergify mergify bot requested review from a team and akhilnarang and removed request for a team May 30, 2024 07:13
@ankush ankush merged commit 06924c1 into version-14-hotfix May 30, 2024
11 checks passed
@ankush ankush deleted the mergify/bp/version-14-hotfix/pr-26605 branch May 30, 2024 08:15
frappe-pr-bot pushed a commit that referenced this pull request Jun 4, 2024
## [14.76.1](v14.76.0...v14.76.1) (2024-06-04)

### Bug Fixes

* **address_query:** show search fields in description if set ([466b428](466b428))
* **address_query:** use title field if set ([00562b7](00562b7))
* Auto Email Report not working when Add Total Row is enabled ([#26667](#26667)) ([3077f26](3077f26))
* Avoid concurrent TODO updates ([#26593](#26593)) ([df821ee](df821ee))
* bypass IP restriction for the methods required for our socketio backend ([b8eca5c](b8eca5c))
* don't copy "Standard" on dashboard chart (backport [#26649](#26649)) ([#26650](#26650)) ([6fe6717](6fe6717))
* fail on cypress install failure ([bf2f9c2](bf2f9c2))
* kanban filters fixes ([#26605](#26605)) ([#26609](#26609)) ([06924c1](06924c1))
* **link-preview:** Correct synchronization of preview data on change. ([#26641](#26641)) ([#26653](#26653)) ([23e4e48](23e4e48))
* **make_request:** don't blindly try to check the content-type ([862840d](862840d))
* never show virtual fields in list view (backport [#24666](#24666)) ([#26578](#26578)) ([58db67d](58db67d))

### Performance Improvements

* memory leak on kanban refresh ([#26597](#26597)) ([#26598](#26598)) ([a45237d](a45237d))
* use base32 space for random names instead of base16 (backport [#25497](#25497)) ([#26655](#26655)) ([335cd28](335cd28)), closes [#25546](#25546)
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 14.76.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants