Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: memory leak on kanban refresh #26597

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

ankush
Copy link
Member

@ankush ankush commented May 29, 2024

closes #24156

Every filter change refreshes entire kanban board from scratch because of this condition.

image

@ankush ankush requested review from a team and akhilnarang and removed request for a team May 29, 2024 10:21
@ankush ankush merged commit dce308b into frappe:develop May 29, 2024
25 checks passed
@ankush ankush deleted the mem_kanban branch May 29, 2024 10:35
@ankush ankush added backport version-14-hotfix backport to version 14 backport version-15-hotfix Backport the PR to v15 labels May 29, 2024
mergify bot pushed a commit that referenced this pull request May 29, 2024
mergify bot pushed a commit that referenced this pull request May 29, 2024
ankush added a commit that referenced this pull request May 30, 2024
(cherry picked from commit dce308b)

Co-authored-by: Ankush Menat <ankush@frappe.io>
ankush added a commit that referenced this pull request May 30, 2024
(cherry picked from commit dce308b)

Co-authored-by: Ankush Menat <ankush@frappe.io>
frappe-pr-bot pushed a commit that referenced this pull request Jun 4, 2024
## [15.29.1](v15.29.0...v15.29.1) (2024-06-04)

### Bug Fixes

* **address_query:** show search fields in description if set ([4db0b53](4db0b53))
* **address_query:** use title field if set ([01a00e3](01a00e3))
* allow creation of workspace based on desk role perms ([fb898f7](fb898f7))
* Auto Email Report not working when Add Total Row is enabled ([#26668](#26668)) ([e585657](e585657))
* Avoid concurrent TODO updates ([#26594](#26594)) ([cee96b9](cee96b9))
* bypass IP restriction for the methods required for our socketio backend ([42011c9](42011c9))
* **checkbox:** Fix checkbox size on small screens ([#26596](#26596)) ([#26612](#26612)) ([fc2a852](fc2a852))
* delete old user notification settings when merging users ([#26604](#26604)) ([#26619](#26619)) ([af1a47d](af1a47d))
* don't copy "Standard" on dashboard chart (backport [#26649](#26649)) ([#26651](#26651)) ([719522d](719522d))
* front-end bug in 'customize_form.js', triggered by delete actions on child-tables ([#26344](#26344)) ([b9f4845](b9f4845)), closes [#26041](#26041) [#26041](https://github.com/frappe/issues/26041) [#26041](#26041)
* kanban filters fixes ([#26605](#26605)) ([#26610](#26610)) ([af7f550](af7f550))
* **link-preview:** Correct synchronization of preview data on change. ([#26641](#26641)) ([#26654](#26654)) ([c34c1d1](c34c1d1))
* **make_request:** don't blindly try to check the content-type ([2fc914f](2fc914f))
* **number_card:** ensure value is returned ([0a91f04](0a91f04))
* **UX:** multi-tab experience ([#26309](#26309)) ([#26646](#26646)) ([3e4fff7](3e4fff7))

### Performance Improvements

* memory leak on kanban refresh ([#26597](#26597)) ([#26599](#26599)) ([8b8a297](8b8a297))
* rearrange some frequent jobs ([#26591](#26591)) ([#26603](#26603)) ([d9b7d73](d9b7d73))
frappe-pr-bot pushed a commit that referenced this pull request Jun 4, 2024
## [14.76.1](v14.76.0...v14.76.1) (2024-06-04)

### Bug Fixes

* **address_query:** show search fields in description if set ([466b428](466b428))
* **address_query:** use title field if set ([00562b7](00562b7))
* Auto Email Report not working when Add Total Row is enabled ([#26667](#26667)) ([3077f26](3077f26))
* Avoid concurrent TODO updates ([#26593](#26593)) ([df821ee](df821ee))
* bypass IP restriction for the methods required for our socketio backend ([b8eca5c](b8eca5c))
* don't copy "Standard" on dashboard chart (backport [#26649](#26649)) ([#26650](#26650)) ([6fe6717](6fe6717))
* fail on cypress install failure ([bf2f9c2](bf2f9c2))
* kanban filters fixes ([#26605](#26605)) ([#26609](#26609)) ([06924c1](06924c1))
* **link-preview:** Correct synchronization of preview data on change. ([#26641](#26641)) ([#26653](#26653)) ([23e4e48](23e4e48))
* **make_request:** don't blindly try to check the content-type ([862840d](862840d))
* never show virtual fields in list view (backport [#24666](#24666)) ([#26578](#26578)) ([58db67d](58db67d))

### Performance Improvements

* memory leak on kanban refresh ([#26597](#26597)) ([#26598](#26598)) ([a45237d](a45237d))
* use base32 space for random names instead of base16 (backport [#25497](#25497)) ([#26655](#26655)) ([335cd28](335cd28)), closes [#25546](#25546)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14 backport version-15-hotfix Backport the PR to v15
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory Leak when working with Filters
1 participant