Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Bug: when adding a comment, the comment won't appear. #1138

Merged
merged 1 commit into from
May 1, 2023
Merged

[FIX] Bug: when adding a comment, the comment won't appear. #1138

merged 1 commit into from
May 1, 2023

Conversation

kurogeek
Copy link
Contributor

When adding a comment, the comment won't appear on the conversation thread after create a comment. The agents need to refresh to see the added comment.

This PR fixes it.

@kurogeek kurogeek marked this pull request as draft April 28, 2023 08:23
@kurogeek kurogeek marked this pull request as ready for review April 28, 2023 08:23
@ssiyad
Copy link
Contributor

ssiyad commented May 1, 2023

We should ideally be using socket events for this. While a refresh 'works' when you add a comment, it won't when it is added from elsewhere. But this could go in until #1129 is merged

@ssiyad ssiyad merged commit efd7001 into frappe:main May 1, 2023
@ssiyad ssiyad added the bug-fix label May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants