Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: agent portal: response editor: conditionally hide email fields #1238

Merged
merged 1 commit into from
May 27, 2023

Conversation

ssiyad
Copy link
Contributor

@ssiyad ssiyad commented May 27, 2023

With email workflow enabled

image

With email workflow disabled

image

@codecov
Copy link

codecov bot commented May 27, 2023

Codecov Report

Patch coverage: 27.27% and project coverage change: +0.55 🎉

Comparison is base (75e655f) 12.87% compared to head (3b398a9) 13.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1238      +/-   ##
==========================================
+ Coverage   12.87%   13.43%   +0.55%     
==========================================
  Files          52       52              
  Lines        1848     1846       -2     
==========================================
+ Hits          238      248      +10     
+ Misses       1610     1598      -12     
Impacted Files Coverage Δ
...esk/doctype/hd_ticket_comment/hd_ticket_comment.py 0.00% <0.00%> (ø)
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py 22.62% <12.50%> (+0.11%) ⬆️
helpdesk/utils.py 39.13% <66.66%> (+39.13%) ⬆️
helpdesk/__init__.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ssiyad ssiyad merged commit f313854 into frappe:main May 27, 2023
@ssiyad ssiyad deleted the feat/hide_emails_if_skip branch May 27, 2023 08:05
@ssiyad ssiyad added the enhancement New feature or request label Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant