Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed filter on non-existent column in grievance chart #501

Merged
merged 1 commit into from
May 9, 2023

Conversation

ruchamahabal
Copy link
Member

Closes #497

There is no company field in Employee Grievance & doctype was incorrectly set

@codecov-commenter
Copy link

Codecov Report

Merging #501 (03bc7c5) into develop (423ecaf) will decrease coverage by 0.12%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #501      +/-   ##
===========================================
- Coverage    72.87%   72.76%   -0.12%     
===========================================
  Files          190      190              
  Lines         9856     9856              
===========================================
- Hits          7183     7172      -11     
- Misses        2673     2684      +11     

see 3 files with indirect coverage changes

@ruchamahabal ruchamahabal merged commit 5dc91f3 into frappe:develop May 9, 2023
mergify bot pushed a commit that referenced this pull request May 9, 2023
ruchamahabal added a commit that referenced this pull request May 9, 2023
#501) (#504)

Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
frappe-pr-bot pushed a commit that referenced this pull request May 10, 2023
## [14.3.1](v14.3.0...v14.3.1) (2023-05-10)

### Bug Fixes

* loan fieldname in salary register report ([#510](#510)) ([15bbda3](15bbda3))
* removed filter on non-existent column in grievance chart (backport [#501](#501)) ([#504](#504)) ([7d6a5e6](7d6a5e6))
* **Salary Slip:** exchange rate overwritten on form load (backport [#507](#507)) ([#508](#508)) ([9cf39a5](9cf39a5))

### Performance Improvements

* refactor `get_all_nodes` in Org Chart ([b68a7bb](b68a7bb))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dashboard-view/Employee Lifecycle
2 participants