fix: remove condition( if not self.assignment_based_on:)

[Jeevansyriac]

issue: When we assign a leave policy without selecting based on then earned leave count shows as 0

[Jeevansyriac]

@ruchamahabal

[Jeevansyriac]

@ruchamahabal please check

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.86%. Comparing base (a8f2490) to head (21c0d8a).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1644      +/-   ##
===========================================
- Coverage    72.90%   72.86%   -0.04%     
===========================================
  Files          203      203              
  Lines        11244    11242       -2     
===========================================
- Hits          8197     8192       -5     
- Misses        3047     3050       +3     

Files	Coverage Δ
...leave_policy_assignment/leave_policy_assignment.py	88.48% <100.00%> (+0.46%)	⬆️

... and 2 files with indirect coverage changes

[ruchamahabal]

I think this was done intentionally during design to have earned leave based on leave period/DOJ only (unsure why). On rethinking it, open-ended date ranges should also support this but the Leave Policy should be mandatory for earned leaves since the total leaves for the year come from there.

Can you verify this in the modified flow and add a test for earned leave allocation with this option?

[Jeevansyriac]

#1697

[ruchamahabal]

Closing this as a duplicate of #1697